feat(timeline): show curator event note on Zeitstrahl (#844) #883

Merged

marcel merged 6 commits from feat/issue-844-event-note into main 2026-06-16 16:27:54 +02:00

Conversation 0 Commits 6 Files Changed 15 +305 -11

marcel commented 2026-06-16 15:10:15 +02:00

Owner

Copy Link

Summary

Threads the existing TimelineEvent.description field through the list DTO and renders it as an expandable note on /zeitstrahl for curated PERSONAL and HISTORICAL events.

• REQ-001 description added as nullable 18th field on TimelineEntryDTO; TimelineService.mapEvent() populates it, letters and derived events get null; api.ts regenerated
• REQ-002 XSS safety via Svelte {...} interpolation — no {@html} (confirmed by grep gate)
• REQ-003 white-space: pre-line applied as inline style so newlines are preserved
• REQ-004 EventNote wired into EventPill.svelte (PERSONAL) and WorldBand.svelte (HISTORICAL) below the title line
• REQ-005 Notes longer than 3 lines are clamped with a "mehr anzeigen" toggle (aria-expanded=false)
• REQ-006 Short notes render fully with no toggle
• REQ-007 Toggle expands → collapses with correct aria state and i18n labels
• REQ-008 null, empty, or blank-only descriptions render nothing

Test plan

• TimelineServiceTest — 3 new unit tests (REQ-001): description populated, null when absent, null for letters
• TimelineControllerTest — 1 new slice test: JSON includes description field (REQ-001)
• event-note.svelte.spec.ts — 8 vitest-browser component tests (REQ-002–REQ-008): all pass
• e2e/zeitstrahl-note.spec.ts — 2 Playwright tests: seed PERSONAL + HISTORICAL events with description via API, assert note appears under title on /zeitstrahl
• RTM rows REQ-001–REQ-008 for #844 added, all Done

Closes #844

🤖 Generated with Claude Code

## Summary Threads the existing `TimelineEvent.description` field through the list DTO and renders it as an expandable note on `/zeitstrahl` for curated PERSONAL and HISTORICAL events. - **REQ-001** `description` added as nullable 18th field on `TimelineEntryDTO`; `TimelineService.mapEvent()` populates it, letters and derived events get `null`; `api.ts` regenerated - **REQ-002** XSS safety via Svelte `{...}` interpolation — no `{@html}` (confirmed by grep gate) - **REQ-003** `white-space: pre-line` applied as inline style so newlines are preserved - **REQ-004** `EventNote` wired into `EventPill.svelte` (PERSONAL) and `WorldBand.svelte` (HISTORICAL) below the title line - **REQ-005** Notes longer than 3 lines are clamped with a "mehr anzeigen" toggle (`aria-expanded=false`) - **REQ-006** Short notes render fully with no toggle - **REQ-007** Toggle expands → collapses with correct aria state and i18n labels - **REQ-008** `null`, empty, or blank-only descriptions render nothing ## Test plan - [ ] `TimelineServiceTest` — 3 new unit tests (REQ-001): description populated, null when absent, null for letters - [ ] `TimelineControllerTest` — 1 new slice test: JSON includes `description` field (REQ-001) - [ ] `event-note.svelte.spec.ts` — 8 vitest-browser component tests (REQ-002–REQ-008): all pass - [ ] `e2e/zeitstrahl-note.spec.ts` — 2 Playwright tests: seed PERSONAL + HISTORICAL events with description via API, assert note appears under title on `/zeitstrahl` - [ ] RTM rows REQ-001–REQ-008 for #844 added, all `Done` Closes #844 🤖 Generated with [Claude Code](https://claude.com/claude-code)

marcel added 5 commits 2026-06-16 15:10:16 +02:00

feat(timeline): add description field to TimelineEntryDTO (REQ-001) ... afee9df8c0

Surfaces the existing TimelineEvent.description through the list DTO so
curated event notes reach the read view. Null for letters and derived
entries; populated from ev.getDescription() in mapEvent() only.

Refs #844
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(timeline): add note toggle i18n keys + regenerate api.ts (REQ-001/007) ... 9716319aad

Adds timeline_note_show_more / _show_less Paraglide keys (de/en/es) for
the expand/collapse affordance on long event notes. Regenerates api.ts
to include description?: string on TimelineEntryDTO.

Refs #844
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(timeline): add EventNote component with expand/collapse (REQ-002–008) ... ace9602f6e

Handles XSS escaping, whitespace-pre-line, 3-line clamp via inline style,
and a toggle button that is only shown when content actually overflows.

Refs #844
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(timeline): wire EventNote into EventPill + WorldBand (REQ-004) ... a63b8115a1

EventPill (PERSONAL curated events) and WorldBand (HISTORICAL events) now
render the curator note immediately below the title line. Derived events
and letters carry null description so EventNote renders nothing.

Refs #844
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(timeline): add Playwright e2e + RTM rows for event note (#844) ... 82979be705

zeitstrahl-note.spec.ts seeds PERSONAL and HISTORICAL events with
descriptions via API and asserts the note appears in DOM (REQ-001, REQ-004).
RTM rows REQ-001–REQ-008 for #844 all marked Done.

Closes #844
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-06-16 15:42:23 +02:00

fix(timeline): restore justify-center on EventPill outer wrapper ... 3ba5ae982b

YearBand.svelte.spec.ts queries '.justify-center .rounded-full' to assert
the pill is present. Replacing justify-center with items-center broke that
selector; adding both preserves the test contract while keeping flex-col
for the note below the pill.

Refs #844
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel merged commit 3ba5ae982b into main 2026-06-16 16:27:54 +02:00

marcel deleted branch feat/issue-844-event-note 2026-06-16 16:27:54 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

needs-discussion

Has an open decision or design question that must be resolved before implementation can start.

needs-review

Spec is drafted and awaiting the multi-persona /review-issue gate.

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

redesign-mappe

Mappe visual redesign — consistency alignment across the app (shared components + pages). See the design_handoff bundle.

refactor

Code restructuring without behaviour change

security

spec-required

Feature whose contract is its issue body (EARS REQ-NNN); the spec must pass review before implementation.

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens renovate_bot marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#883