fix(e2e): fix 4 failing e2e tests — strict mode locator and nested form #89

Merged
marcel merged 1 commits from feature/68-new-document-file-first into main 2026-03-27 10:07:16 +01:00
Owner

documents.spec.ts: replace getByText with getByRole('heading') to avoid
Svelte's #svelte-announcer matching the same text (strict mode violation).

SaveBar.svelte: move

out of the component
and into +page.svelte as a sibling of delete-form. The form was previously
nested inside , which is invalid HTML. The browser
auto-repaired it, causing a Svelte hydration mismatch that broke the edit
form's use:enhance, preventing version snapshots from being recorded —
leaving history tests with 0 versions instead of the expected 2.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

documents.spec.ts: replace getByText with getByRole('heading') to avoid Svelte's #svelte-announcer matching the same text (strict mode violation). SaveBar.svelte: move <form id="mark-for-review-form"> out of the component and into +page.svelte as a sibling of delete-form. The form was previously nested inside <form id="update-form">, which is invalid HTML. The browser auto-repaired it, causing a Svelte hydration mismatch that broke the edit form's use:enhance, preventing version snapshots from being recorded — leaving history tests with 0 versions instead of the expected 2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel added 1 commit 2026-03-27 10:07:06 +01:00
fix(e2e): fix 4 failing e2e tests — strict mode locator and nested form
Some checks failed
CI / Unit & Component Tests (pull_request) Has been cancelled
CI / Backend Unit Tests (pull_request) Has been cancelled
CI / E2E Tests (pull_request) Has been cancelled
CI / Unit & Component Tests (push) Successful in 2m23s
CI / Backend Unit Tests (push) Successful in 2m11s
CI / E2E Tests (push) Failing after 29m1s
fa9577052d
documents.spec.ts: replace getByText with getByRole('heading') to avoid
Svelte's #svelte-announcer matching the same text (strict mode violation).

SaveBar.svelte: move <form id="mark-for-review-form"> out of the component
and into +page.svelte as a sibling of delete-form. The form was previously
nested inside <form id="update-form">, which is invalid HTML. The browser
auto-repaired it, causing a Svelte hydration mismatch that broke the edit
form's use:enhance, preventing version snapshots from being recorded —
leaving history tests with 0 versions instead of the expected 2.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit fa9577052d into main 2026-03-27 10:07:16 +01:00
marcel deleted branch feature/68-new-document-file-first 2026-03-27 10:07:18 +01:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#89