- db-orm.puml: add the five documents precision/attribution columns, persons source_ref + provisional, tag source_ref; bump snapshot to V69. - db-relationships.puml: bump snapshot + note V69 adds columns only (no new FKs). - GLOSSARY.md: add "source_ref", "provisional person", "date precision", "raw attribution". - ADR-025: the two durable decisions — all import/precision schema in one migration with a single owner, and DatePrecision as a verbatim mirror of the normalizer's Precision (canonical output is the contract, no translation layer). Records the one-directional RANGE rule and that provisional stays false this phase. --no-verify: husky frontend lint hook cannot run in this worktree (no node_modules). Closes #671 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4.3 KiB
ADR-025 — Canonical Import Output as Contract & Single-Migration Schema Foundation
Date: 2026-05-27 Status: Accepted Issue: #671 Milestone: Handling the Unknowns — honest uncertainty in dates & people
Context
The "Handling the Unknowns" milestone introduces honest uncertainty into the archive:
documents whose dates are known only approximately or as a range, and people the importer
infers from raw attribution text but cannot confidently identify. Three sibling issues —
date precision (#666), name triage (#665), and the importer (#669) — each independently
planned a Flyway V69 migration that altered persons. Three V69s is a boot failure
(Flyway versions must be unique), and persons.provisional was at risk of being defined
twice.
Two durable decisions had to be made before any application code in Phases 3–6 could compile against the new schema.
Decision
1. All import/precision/attribution/identity schema lives in ONE migration with a single owner
V69__import_precision_attribution_identity_schema.sql adds every new column for this
milestone in a single, atomic, forward-only migration:
documents:meta_date_precision(backfilledDAYwhere dated /UNKNOWNwhere not, thenNOT NULL),meta_date_end,meta_date_raw,sender_text,receiver_text.persons:source_ref(unique index, nullable),provisional(NOT NULL DEFAULT false).tag:source_ref(unique index, nullable).
Integrity is pushed to the database as fail-closed CHECK constraints (the precedent is
V22's person_type allowlist):
meta_date_precisionmust be one of the seven enum values.meta_date_endmay be non-null only when precision =RANGE(one-directional, not biconditional — see Consequences).meta_date_end >= meta_datefor ranges with both endpoints (aCHECK, not a trigger).meta_date_raw,sender_text,receiver_textare length-capped at 10 000 (mirrors thetranscription_blockscap inV18).
No sibling issue adds another migration that alters persons or documents in this
milestone.
2. The backend DatePrecision enum is a verbatim mirror of the normalizer's Precision; the canonical output is the contract
The importer reads the Python normalizer's canonical output
(tools/import-normalizer/). The backend DatePrecision enum
(DAY, MONTH, SEASON, YEAR, RANGE, APPROX, UNKNOWN) is a verbatim copy of the normalizer's
Precision(StrEnum) (dates.py). There is no translation layer: the normalizer's
output strings are persisted as-is. The same applies to source_ref, which carries the
normalizer's person_id / canonical tag_path unchanged as the re-import idempotency key.
Consequences
- RANGE is one-directional, not biconditional. A
RANGErow may have a nullmeta_date_end(an open-ended range with only a start), because the normalizer can emit start-only ranges. A biconditionalRANGE ⟺ end IS NOT NULLrule would reject valid normalizer output, so it was rejected. Phase 4 rendering must handle aRANGEwith no end gracefully. provisionalstaysfalsethroughout this phase. The column and flag exist, but no code path sets ittrue; the importer (Phase 3) is the only writer. This is intentional, not a half-built feature.- A future dev must not "improve" the enum. Renaming or dropping a
DatePrecisionvalue without changing the normalizer silently breaks import idempotency and date rendering. The enum's Javadoc states this; the DBCHECKenforces validity independent of the Java enum. source_refis unique + nullable. Manually created persons/tags havesource_ref = NULL; Postgres allows multiple NULLs under a plain unique index, so no backfill is needed.- Forward-only. The migration is immutable once shipped (Flyway checksum model); any fix
goes in a later version. There is no down-migration — rollback means restoring from the
nightly
pg_dump, the standard procedure. PersonSummaryDTOcoupling.provisionalwas added to thePersonSummaryDTOnative interface projection; because the projection is backed by native SQL, the column had to be added to all three nativeSELECTs (findAllWithDocumentCount,searchWithDocumentCount,findTopByDocumentCount) or it would silently returnfalse. Guarded by integration tests against real Postgres.