8ce96294b0
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 2m50s
CI / OCR Service Tests (pull_request) Successful in 27s
CI / Backend Unit Tests (pull_request) Failing after 2m54s
CI / Unit & Component Tests (push) Failing after 2m49s
CI / OCR Service Tests (push) Successful in 30s
CI / Backend Unit Tests (push) Failing after 2m55s
Felix B1 (data-loss regression on /documents/[id]/edit) — DocumentEditLayout
still passes initialDateIso, initialLocation, initialDocumentLocation, but
my cycle-1 cleanup removed those props. Result: existing values rendered
empty and a save would have overwritten them with "". Restored the props
on WhoWhenSection and DescriptionSection; initialisation now lives in
onMount so it runs exactly once and never stomps a parent-driven update on
a later prop change.
Felix B2 — `DescriptionSection.svelte:36` still had the top-level
`currentTitle = untrack(() => initialTitle)` mutation that I cleaned up in
WhoWhenSection but missed here. Same onMount-once treatment.
Leonie B5 — `enrich/+page.svelte:105` referenced `<BulkSelectionBar>` but
the import was lost in a prettier pass; svelte-check errored out and the
bar never rendered, leaving an 8 rem dead zone from the pb-32 reservation.
One-line fix: add the import.
Leonie B6 — Esc handler in `BulkSelectionBar` was unscoped and stole
Escape from NotificationBell, ConfirmDialog, HelpPopover, etc. (e.g.
selecting docs → opening notification bell → Esc would close the bell
AND silently wipe the selection). Now bails when an open dialog,
expanded menu, or popover is detected.
Elicit C1 — `BulkDocumentEditLayout` topbar now branches on `mode`:
shows "Massenbearbeitung" + "{count} werden bearbeitet" in edit mode
instead of the upload-flavoured "Mehrere Dokumente hochladen" + "werden
erstellt" copy. New i18n keys `bulk_edit_topbar_title` and
`bulk_edit_count_pill` in DE/EN/ES.
Tests added:
- DocumentControllerTest.patchBulk_stripsCarriageReturnsAndNewlinesFromErrorMessages
(Sara C2 follow-up — pin sanitizeForLog as a regression test)
- BulkSelectionBar.spec — count=1 → "1 Dokument", count=2 → "2 Dokumente"
(Sara C6 follow-up — pin the new bulk_edit_n_selected_one/_other branch)
Refs #225, PR #331
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
75 lines
2.4 KiB
Svelte
75 lines
2.4 KiB
Svelte
<script lang="ts">
|
|
import { goto } from '$app/navigation';
|
|
import { m } from '$lib/paraglide/messages.js';
|
|
import { bulkSelectionStore } from '$lib/stores/bulkSelection.svelte';
|
|
|
|
let { canWrite }: { canWrite: boolean } = $props();
|
|
|
|
const count = $derived(bulkSelectionStore.size);
|
|
const visible = $derived(canWrite && count > 0);
|
|
|
|
function openBulkEdit() {
|
|
goto('/documents/bulk-edit');
|
|
}
|
|
|
|
function clearAll() {
|
|
bulkSelectionStore.clear();
|
|
}
|
|
|
|
// Escape clears the selection — keyboard escape hatch when the user has
|
|
// drilled into a 50-row selection and wants to bail without Tab-ing through
|
|
// the whole footer (WCAG 2.1.1). Bails when an open dialog, expanded menu,
|
|
// or popover is in front so we don't steal Esc from NotificationBell,
|
|
// ConfirmDialog, HelpPopover, etc.
|
|
function onEscape(e: KeyboardEvent) {
|
|
if (e.key !== 'Escape' || !visible) return;
|
|
if (e.defaultPrevented) return;
|
|
const overlay = document.querySelector(
|
|
'dialog[open], [aria-expanded="true"], [role="menu"]:not([hidden]), [role="dialog"]:not([hidden])'
|
|
);
|
|
if (overlay) return;
|
|
clearAll();
|
|
}
|
|
</script>
|
|
|
|
<svelte:window onkeydown={onEscape} />
|
|
|
|
{#if visible}
|
|
<div
|
|
data-testid="bulk-selection-bar"
|
|
class="fixed right-0 bottom-0 left-0 z-30 flex items-center justify-between gap-3 border-t border-line bg-surface px-4 py-3 pb-[max(0.75rem,env(safe-area-inset-bottom))] shadow-[0_-2px_8px_rgba(0,0,0,0.06)] sm:px-6"
|
|
>
|
|
<div class="flex items-baseline gap-3">
|
|
<span
|
|
class="font-sans text-sm font-medium text-ink"
|
|
data-testid="bulk-selection-count"
|
|
aria-live="polite"
|
|
aria-atomic="true"
|
|
>
|
|
{count === 1 ? m.bulk_edit_n_selected_one() : m.bulk_edit_n_selected_other({ count })}
|
|
</span>
|
|
<span class="hidden font-sans text-xs text-ink-3 sm:inline">
|
|
{m.bulk_edit_clear_hint_keyboard()}
|
|
</span>
|
|
</div>
|
|
<div class="flex items-center gap-2">
|
|
<button
|
|
type="button"
|
|
onclick={clearAll}
|
|
class="inline-flex min-h-[44px] items-center px-4 py-2 font-sans text-sm font-medium text-ink-2 transition-colors hover:text-ink"
|
|
data-testid="bulk-clear-all"
|
|
>
|
|
{m.bulk_edit_clear_selection()}
|
|
</button>
|
|
<button
|
|
type="button"
|
|
onclick={openBulkEdit}
|
|
class="inline-flex min-h-[44px] items-center bg-primary px-5 py-2 font-sans text-xs font-bold tracking-widest text-primary-fg uppercase transition-colors hover:bg-primary/90"
|
|
data-testid="bulk-edit-open"
|
|
>
|
|
{m.bulk_edit_button()}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
{/if}
|