f10b0cb73e
Addresses the remaining #792 review blockers and concerns in the journey editor cluster: - Interlude rows show 'Zwischentext' (dedicated key), not the add-button text - All four mutation handlers route the backend ErrorCode through getErrorMessage (a 409 duplicate no longer says 'bitte Seite neu laden') and console.error their failures so client-side errors leave a trace - Remove implements the spec'd pending state: row stays dimmed with an aria-live 'wird entfernt…' until the DELETE resolves; failure keeps the row - Move announcements fire after the reorder resolves (no false 'verschoben') - Touch targets ≥44px (remove ×, note links, create submit); focus moves to the new row after add, to a sensible neighbor after remove, back to × on confirm-cancel; drag handle is pointer-only; title/intro get aria-labels; publish-disabled reason is a visible hint, not a title tooltip - Amber warning styles use new --color-warning-* tokens with dark remaps - Blocked interlude-clear restores the draft instead of showing phantom text - useBlockDragDrop moves to $lib/shared/hooks — geschichte no longer imports another domain's internals - Test hardening: reorder-failure rollback (non-ok + reject), publish/ unpublish/empty-warning surface, destructive confirm path, maxlength assertions, JourneyCreate failure path, edit-page STORY/JOURNEY branch, fixture factory, m.* assertions, all fixed sleeps replaced with polling 67 component tests green across 6 spec files; transcription consumer of the moved hook re-verified (30 green). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
73 lines
2.5 KiB
TypeScript
73 lines
2.5 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from 'vitest';
|
|
import { cleanup, render } from 'vitest-browser-svelte';
|
|
import { page, userEvent } from 'vitest/browser';
|
|
import { m } from '$lib/paraglide/messages.js';
|
|
import JourneyAddBar from './JourneyAddBar.svelte';
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
describe('JourneyAddBar — interlude flow', () => {
|
|
it('interlude confirm button is natively disabled when text is empty (WCAG 4.1.2)', async () => {
|
|
render(JourneyAddBar, { onAddDocument: vi.fn(), onAddInterlude: vi.fn() });
|
|
|
|
await userEvent.click(page.getByText(m.journey_add_interlude()));
|
|
|
|
const confirmBtn = page.getByRole('button', {
|
|
name: m.journey_add_interlude_confirm(),
|
|
exact: true
|
|
});
|
|
await expect.element(confirmBtn).toBeDisabled();
|
|
});
|
|
|
|
it('confirm becomes enabled after typing text', async () => {
|
|
render(JourneyAddBar, { onAddDocument: vi.fn(), onAddInterlude: vi.fn() });
|
|
|
|
await userEvent.click(page.getByText(m.journey_add_interlude()));
|
|
await userEvent.fill(page.getByRole('textbox'), 'Eine schöne Reise');
|
|
|
|
const confirmBtn = page.getByRole('button', {
|
|
name: m.journey_add_interlude_confirm(),
|
|
exact: true
|
|
});
|
|
await expect.element(confirmBtn).toBeEnabled();
|
|
});
|
|
|
|
it('calls onAddInterlude with text on confirm', async () => {
|
|
const onAddInterlude = vi.fn();
|
|
render(JourneyAddBar, { onAddDocument: vi.fn(), onAddInterlude });
|
|
|
|
await userEvent.click(page.getByText(m.journey_add_interlude()));
|
|
await userEvent.fill(page.getByRole('textbox'), 'Reise nach Wien');
|
|
await userEvent.click(
|
|
page.getByRole('button', { name: m.journey_add_interlude_confirm(), exact: true })
|
|
);
|
|
|
|
expect(onAddInterlude).toHaveBeenCalledWith('Reise nach Wien');
|
|
});
|
|
|
|
it('limits the interlude textarea to 2000 characters', async () => {
|
|
render(JourneyAddBar, { onAddDocument: vi.fn(), onAddInterlude: vi.fn() });
|
|
|
|
await userEvent.click(page.getByText(m.journey_add_interlude()));
|
|
|
|
await expect.element(page.getByRole('textbox')).toHaveAttribute('maxlength', '2000');
|
|
});
|
|
});
|
|
|
|
describe('JourneyAddBar — document picker', () => {
|
|
it('reveals picker when "Brief hinzufügen" is clicked', async () => {
|
|
vi.stubGlobal(
|
|
'fetch',
|
|
vi.fn().mockResolvedValue({ ok: true, json: vi.fn().mockResolvedValue({ items: [] }) })
|
|
);
|
|
render(JourneyAddBar, { onAddDocument: vi.fn(), onAddInterlude: vi.fn() });
|
|
|
|
await userEvent.click(page.getByText(m.journey_add_document()));
|
|
|
|
await expect.element(page.getByRole('combobox')).toBeInTheDocument();
|
|
});
|
|
});
|