feat(journey-editor): JourneyEditor frontend — issue #753 #792
Reference in New Issue
Block a user
Delete Branch "feat/issue-753-journey-editor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
createBlockDragDrop<T>— accepts any{ id: string }shape, used by JourneyEditor alongside the existing transcription editorGeschichteSidebar.svelte— Status badge + PersonMultiSelect with<details>mobile collapsibles (44px touch targets)DocumentPickerDropdown.svelte— single-select document search witharia-disabledfor already-added items and sr-only "bereits enthalten" hintDocumentMultiSelect.svelteontocreateTypeahead— removes rawsetTimeoutdebounceJourneyItemRow.svelte— drag handle, move-up/down buttons, note textarea (PATCH on blur), interlude visual treatment, inline remove confirmJourneyAddBar.svelte— "Brief hinzufügen" opensDocumentPickerDropdown; "Zwischentext hinzufügen" opens inline draft form witharia-disabledconfirm until text non-emptyJourneyEditor.svelte— main orchestrator: title, intro textarea, drag-reorder list, optimistic remove/reorder (pre-mutation snapshot rollback on failure) and pessimistic add (item list updated only on API success),createUnsavedWarning,GeschichteSidebargeschichten/[id]/edit/+page.svelte— branches ongeschichte.type: JOURNEY →JourneyEditor, STORY →GeschichteEditor(unchanged)journey_*keys in de/en/es; 4 newErrorCodevalues; interlude CSS semantic tokens (--color-interlude-bg/border/label) with light + dark valuesDesign notes
maxlength="2000"per spec — discrepancy tracked in issue #793 for resolution.bodyfield; backend skips sanitizer for JOURNEY (implemented in issue #751).markDirty()— reorder/add/remove are persisted optimistically (remove/reorder) or pessimistically (add); only title + intro edits trigger the unsaved-changes guard.data-drag-handle/data-block-wrappercontract reused from transcription editor unchanged.handleAddDocumentandhandleAddInterludeonly updateitemsafter a successful API response;handleRemoveandhandleReorderpre-update with snapshot rollback on failure.Test plan
cd frontend && npx tsc --noEmit— no errors in any new filenpm run test -- --project=server— all server-side tests greenDocumentPickerDropdown,JourneyItemRow,JourneyAddBar,JourneyEditor— run with--project=clientin CI/geschichten/[id]/edit, verify JourneyEditor renders; add document, add interlude, reorder, check STORY type still opens GeschichteEditor🤖 Generated with Claude Code
Review round 2 addendum (2026-06-10)
Breaking API change (intentional):
POST/PATCH /api/geschichtennow returnGeschichteViewinstead of the rawGeschichteentity (author →AuthorView {id, displayName}, persons →PersonView[], nodocuments). Motivation: withopen-in-view: falsethe lazyitemsproxy is dead at serialization time — every save/publish 500'd. See ADR-036. The same round also droppedemailfromGeschichteSummary.AuthorSummaryand the generatedGeschichteschema no longer exists.Corrections to the original body:
disabled(notaria-disabled) sinceb30c0d7f.Regen artifacts:
src/lib/generated/api.tsregeneration swept in unrelated drift from the base branch (/api/admin/backfill-titlesadded,getConversationremoved,hasTranscription,subtreeDocumentCount) — these are spec catch-up, not changes of this PR.i18n register:
comp_typeahead_error/comp_typeahead_no_resultsare Sie-form on purpose — allerror_*strings are Sie project-wide (4c620619); the du-form in journey UI hints is a different message class.Deferred work tracked in #796 (E2E journey path, axe dual-theme/320px scan, mobile sticky save bar, intro auto-resize, publish-disabled focus hand-off, keyed-each + noteSaving race tests).
- useBlockDragDrop: add runtime expect() alongside expectTypeOf so browser-mode runner counts at least one assertion - JourneyAddBar: use exact:true on 'Hinzufügen' button — partial match was hitting '+ Brief hinzufügen' and '+ Zwischentext hinzufügen' too - JourneyEditor: fix 4 issues — drop wrong not.toBeInTheDocument() (placeholder creates accessible name); pass title:'' in publish-disabled test (default was non-empty); use getByPlaceholder for interlude textarea to avoid 4-element strict-mode violation; exact:true for 'Hinzufügen' button - DocumentPickerDropdown: use .click({force:true}) on aria-disabled option — userEvent refuses non-enabled elements Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>The screen-reader live announcement was calling m.journey_item_moved() without the required {position, total, newPosition} parameters, which the i18n template uses to build the full announcement string. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>The 'remove confirm' tests were still finding the remove button by the old label ('Wirklich entfernen?'). After the aria-label change the button is named 'Eintrag entfernen'; the visible confirmation text 'Wirklich entfernen?' in the DOM is unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>role=listbox + role=option without arrow-key navigation is misleading — the WAI-ARIA combobox pattern requires aria-activedescendant handling that isn't implemented. Downgraded to plain <ul>/<li>; input keeps role=combobox + aria-controls pointing to the list id. listboxId was a module-level constant so two simultaneous instances would share the same DOM id. Fixed with a <script module> counter. Updated spec queries from getByRole('option') to getByText() — tests behaviour, not the ARIA implementation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>PATCH /api/geschichten/{id} (save draft, publish) returned the raw entity; with open-in-view false, Jackson serialized the lazy items collection after the transaction closed and every save failed with LazyInitializationException. Write methods now assemble GeschichteView in-transaction, completing the read-model boundary already used by GET — entities no longer cross the controller. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>POST /api/geschichten/{id}/items with a documentId failed 500: Spring Data resolved the derived existsByGeschichteIdAndDocumentId path as a direct documentId attribute (shadowed by the transient getDocumentId() getter) instead of document.id, producing JPQL Hibernate cannot map. Existing tests only appended note items, so the document branch was never exercised. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>The OWASP sanitizer entity-encodes ('&' → '&') while JourneyReader renders the intro via Svelte text interpolation — a curator typing 'Müller & Söhne' saw 'Müller & Söhne', re-encoded cumulatively on every editor round-trip. JOURNEY bodies now bypass the sanitizer (safe: the reader never uses {@html}); STORY bodies keep the full allow-list sanitization. This makes the code match the PR's documented design note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>DocumentMetadataDrawer links to /geschichten?documentId={id}, but the list loader silently dropped the param — the user got the unfiltered list. The loader now validates the UUID and forwards it to GET /api/geschichten, returning it as documentIdFilter in page data. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.