• Joined on 2026-03-17
marcel created branch feat/issue-381-geschichten in marcel/familienarchiv 2026-05-02 18:14:35 +02:00
marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:07:09 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

Decisions Resolved

Three open questions from the persona reviews are now closed.

1. Font — Merriweather (no change)

Fraunces is not adopted. Story pages use the existing…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:03:31 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

📋 Elicit — Requirements Engineer (spec review)

The four spec files are high quality — impl-ref tables, visual mockups, and explicit implementation decisions are exactly what makes a spec…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:03:10 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🛠️ Tobias Wendt — DevOps & Platform Engineer (spec review)

Short update — the specs don't change the infrastructure picture, but there are three new operational details worth noting.

###…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:02:56 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🎨 Leonie Voss — UX Designer & Accessibility Strategist (spec review)

The specs are well-structured — the impl-ref tables are exactly the right level of precision for handoff. A few places…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:02:30 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🧪 Sara Holt — QA Engineer (spec review)

The four specs add substantial surface area that has no AC coverage in the original issue. I'm cataloguing the gaps and the new journeys.

AC…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:02:08 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🔒 Nora "NullX" Steiner — Security Engineer (spec review)

The four specs add two new attack surfaces not fully addressed in my earlier review. The existing concerns (XSS, DRAFT exposure)…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:01:48 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

👨‍💻 Felix Brandt — Senior Fullstack Developer (spec review)

The four spec files resolve the open decisions from my earlier review and add concrete implementation guidance. Here's what…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 17:01:24 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🏛️ Markus Keller — Application Architect (spec review)

The four spec files resolve several earlier open questions but also introduce scope that the issue body doesn't cover. I'm flagging…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:02:21 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Architecture / Data Model

  • Story body character limit — The body field is…
marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:02:04 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • Zero new infrastructure required. Geschichten are stored in PostgreSQL and served via the existing Spring Boot +…
marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:02:02 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

Navigation

The issue says "Geschichten" visible to all logged-in users. Looking at AppNav.svelte, the pattern…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:02:01 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🧪 Sara Holt — QA Engineer

Observations

Missing acceptance criteria / edge cases not covered by the spec:

  • US-BLOG-001, empty body: The spec requires a title to save. What…
marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:01:59 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🔒 Nora "NullX" Steiner — Security Engineer

Observations

Critical: Stored XSS via rich text body

The body field is rich text HTML stored in PostgreSQL and rendered in the browser.…

marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:01:57 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • Reusable components already exist: PersonTypeahead and PersonMultiSelect are the right building blocks for the…
marcel commented on issue marcel/familienarchiv#381 2026-05-02 11:01:55 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents

🏛️ Markus Keller — Application Architect

Observations

  • Module package: The existing layout is controller/, service/, repository/, model/ — but that's layer-first. The…
marcel opened issue marcel/familienarchiv#381 2026-05-02 09:33:25 +02:00
feat: Geschichten — blog-like family memory stories linked to persons and documents
marcel opened issue marcel/familienarchiv#380 2026-04-30 10:54:43 +02:00
feat(transcription): decouple @mention display text from person search
marcel commented on issue marcel/familienarchiv#370 2026-04-30 10:38:12 +02:00
feat(person-mention): discoverability hint for the @ trigger in the editor

Implementation complete

Branch: feat/issue-370-at-mention-placeholder-hint PR: #379

What was done

Implemented Leonie's design decision from the review comment: update the 3 existing…

marcel created pull request marcel/familienarchiv#379 2026-04-30 10:37:57 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder