marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel merged pull request marcel/familienarchiv#375 2026-04-29 21:33:18 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence
marcel pushed to fix/hover-card-placeholder-maiden-name at marcel/familienarchiv 2026-04-29 21:32:54 +02:00
b3fe9b1171 refactor(PersonMentionEditor): use data-editor-inner attribute for stable querySelector
3c7c7a9aa4 refactor(TranscriptionReadView): rename handleMentionLeave, closeTimer to \$state, add 150ms comment
9908f7afdc test(TranscriptionReadView): cover hover card timer and keyboard focus behavior
Compare 3 commits »
marcel commented on pull request marcel/familienarchiv#377 2026-04-29 21:32:52 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

  • No infrastructure changes: Docker Compose, CI pipeline, environment variables, and service…
marcel commented on pull request marcel/familienarchiv#377 2026-04-29 21:32:48 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

What I checked

  • Focus management: closeBtn?.focus({ preventScroll: true }) after scrollIntoView…
marcel commented on pull request marcel/familienarchiv#377 2026-04-29 21:32:43 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🧪 Sara Holt — QA Engineer

Verdict: ✅ Approved

What I checked

  • SegmentationColumn.svelte.spec.ts: link assertion updated from /documents/abc-123 to `/documents/abc-123?task…
marcel commented on pull request marcel/familienarchiv#377 2026-04-29 21:32:37 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🔒 Nora "NullX" Steiner — Security Engineer

Verdict: ✅ Approved

What I checked

  • Param comparison is strict: page.url.searchParams.get('task') === 'transcribe' — exact…
marcel commented on pull request marcel/familienarchiv#377 2026-04-29 21:32:35 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

What I checked

  • Layer boundary: purely frontend UI-state change — no backend, no server load function touched…
marcel commented on pull request marcel/familienarchiv#377 2026-04-29 21:32:28 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

None.

Suggestions

  • +page.svelte — tick().then() has no .catch(): The…
marcel commented on pull request marcel/familienarchiv#375 2026-04-29 21:31:54 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

All reviewer concerns addressed ✅

Keyboard focus gap (Leonie FINDING-01 / WCAG 2.1.1)

PersonHoverCard.svelte — added onfocusin and onfocusout to the card's root <div> so…

marcel created pull request marcel/familienarchiv#377 2026-04-29 21:31:36 +02:00
feat: auto-open transcription panel when navigating from mission-control cards
84ba728e08 feat(document-page): auto-open transcription panel when ?task=transcribe is present
6f40b2c32d feat(TranscriptionColumn): deep-link to transcription panel via ?task=transcribe
690eb234c4 feat(SegmentationColumn): deep-link to transcription panel via ?task=transcribe
Compare 3 commits »
marcel created branch feat/issue-376-auto-open-transcription-panel in marcel/familienarchiv 2026-04-29 21:31:28 +02:00
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:31:19 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

✅ Implementation complete

Three commits on feat/issue-376-auto-open-transcription-panel:

690eb234 — feat(SegmentationColumn): deep-link to transcription panel via ?task=transcribe

-…

marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:19:30 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🎯 Discussion Resolutions

After reviewing the persona feedback with the user, here are the agreed decisions:

Theme 1 — Implementation location

  • Decision: task param check lives in…
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:14:58 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🗳️ Decision Queue — 2 decisions needed before implementation

URL Behaviour

  • Strip ?task=transcribe from the URL after the panel opens, or keep it?
    • Strip (Felix, Nora,…
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:14:37 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🚀 Tobias Wendt — DevOps & Platform Engineer

Observations

  • Purely a frontend change. No Docker Compose modifications, no environment variables, no CI pipeline changes, no new services,…
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:14:31 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

  • The fix is the right call and the right scope. Passive enhancement: users navigating via normal search or person…
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:14:21 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🧪 Sara Holt — QA Engineer

Observations

  • Existing test will break: SegmentationColumn.svelte.spec.ts line 65 asserts toHaveAttribute('href', '/documents/abc-123'). After the…
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:14:12 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🔒 Nora "NullX" Steiner — Security Engineer

Observations

  • No server-side attack surface is introduced. The task param is read client-side in onMount only — it does not reach the…
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:14:04 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

🏛️ Markus Keller — Application Architect

Observations

  • This is entirely a frontend UI-state concern. No backend changes, no API changes, no Flyway migration, no new endpoints. The…