marcel

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:26:03 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

All five deliverables from issue #320 are implemented and match the spec. One requirements gap needs a conscious…

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:25:48 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Pure frontend feature addition — no infrastructure changes needed or introduced. A few operational notes:

###…

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:25:39 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: 🚫 Changes requested

The coach card and richtlinien page are structurally solid — good use of aria-label on the SVG,…

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:25:22 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

Good test coverage across the pyramid — 60 vitest-browser unit tests, 3 new E2E spec files, axe WCAG 2.1 AA checks…

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:25:06 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

No injection, no XSS surface, no authentication bypass from the application code itself. One…

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:24:54 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🏗️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

Frontend-only change, no layer boundary violations, no premature abstractions. Component decomposition is…

marcel commented on pull request marcel/familienarchiv#330

2026-04-24 23:24:39 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Clean implementation overall. TDD evidence is solid — 60 unit tests covering the new components,…

marcel pushed to feat/issue-317-bulk-upload at marcel/familienarchiv

2026-04-24 23:22:49 +02:00

c78a1d69dc test(bulk-upload): add unit tests for storeDocumentWithBatchMetadata

5131c8da31 fix(bulk-upload): truncate long chip titles with tooltip in FileSwitcherStrip

eb106c9ca7 fix(bulk-upload): enlarge scroll button touch targets to 44×44px

e742c36ef6 fix(bulk-upload): populate aria-live region with active file title

9ac01f7cc2 fix(bulk-upload): add aria-label to progress bar in UploadSaveBar

Compare 40 commits »

marcel created pull request marcel/familienarchiv#330

2026-04-24 23:21:20 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

marcel pushed to feat/issue-320-transcribe-coach at marcel/familienarchiv

2026-04-24 23:20:58 +02:00

marcel created branch feat/issue-320-transcribe-coach in marcel/familienarchiv

2026-04-24 23:20:57 +02:00

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:43:48 +02:00

feat(documents): bulk upload — split-panel with file switcher

Review concerns addressed

All open reviewer concerns from the multi-persona review have been resolved. Here's what was fixed, in commit order:

🐛 Bug fixes

**08c74ca3 — tagNames…

marcel pushed to feat/issue-317-bulk-upload at marcel/familienarchiv

2026-04-24 21:43:21 +02:00

88b16296bc test(bulk-upload): add unit tests for storeDocumentWithBatchMetadata

1255bb762a fix(bulk-upload): truncate long chip titles with tooltip in FileSwitcherStrip

23f114d04b fix(bulk-upload): enlarge scroll button touch targets to 44×44px

8484459b1a fix(bulk-upload): populate aria-live region with active file title

de96e88602 fix(bulk-upload): add aria-label to progress bar in UploadSaveBar

Compare 8 commits »

marcel pushed to main at marcel/familienarchiv

2026-04-24 21:42:36 +02:00

c3fac5b0ad feat(#320): guided empty state + Kurrent primer for first-time transcribers

03b180fe88 test(e2e): add transcribe-coach, richtlinien, and help-popover E2E specs; reducedMotion global default

b234db0472 feat(richtlinien): add /hilfe/transkription page with RichtlinienRuleCard

7c3a8e7651 feat(transcribe): add HelpPopover primitive and wire (?) chip into panel header

7fb9d74515 feat(transcribe): copy pass markieren→einrahmen in transcription_next_block_cta

Compare 7 commits »

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:02:17 +02:00

feat(documents): bulk upload — split-panel with file switcher

📋 Elicit — Requirements Engineer

Verdict: 🚫 Changes requested

Critical Gap: Core User Requirement Not Delivered

Tags (shared metadata) are entered but never saved

The PR…

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:02:03 +02:00

feat(documents): bulk upload — split-panel with file switcher

🖥️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

Concerns

1. Caddy max_request_body is not updated in this PR

application.yaml raises…

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:01:49 +02:00

feat(documents): bulk upload — split-panel with file switcher

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

Verdict: 🚫 Changes requested

Critical (blocks use)

1. goto('/documents') on every save discards error feedback…

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:01:29 +02:00

feat(documents): bulk upload — split-panel with file switcher

🧪 Sara Holt — Senior QA Engineer

Verdict: 🚫 Changes requested

Blockers

1. The save-and-error test is incomplete — goto is never verified

The spec tests that error chips…

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:01:12 +02:00

feat(documents): bulk upload — split-panel with file switcher

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

Security Smell (worth fixing)

**1. max-request-size: 500MB with no rate limiting or…

marcel commented on pull request marcel/familienarchiv#329

2026-04-24 21:00:53 +02:00

feat(documents): bulk upload — split-panel with file switcher

🏛️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

Layering & Boundary Check

The layering is correct throughout. DocumentController delegates to…