marcel

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 08:50:28 +02:00

feat(documents): bulk upload — split-panel with file switcher

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

Layer discipline is clean. DocumentBatchMetadataDTO lives in dto/, validateBatch and storeDocumentWithBatchMetadata…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 08:50:15 +02:00

feat(documents): bulk upload — split-panel with file switcher

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Great feature delivery. Component decomposition is clean — BulkDropZone, FileSwitcherStrip,…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:50:10 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

Reviewing against issue #320's stated scope and the PR description's own acceptance criteria.

Requirements coverage

The PR…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:49:57 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure changes in this PR. Reviewing from a CI/CD and deployment perspective.

What I checked

**E2E…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:49:49 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

This is a pure frontend PR — no backend changes, no new infrastructure, no schema changes. I reviewed it for structural…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:49:38 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

This PR is accessibility-first throughout. Several changes here are exactly what I would have asked for.

###…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:49:19 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🧪 Sara Holt — Senior QA Engineer

Verdict: ✅ Approved

The test coverage in this PR is thorough. A few structural observations.

Highlights

afterAll cleanup added to E2E specs…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:49:03 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

This PR is entirely frontend UI — no backend endpoints, no auth changes, no data persistence changes. I…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 08:48:49 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Good discipline throughout. A few observations worth flagging.

Highlights

**HelpPopover.svelte — module…

marcel commented on pull request marcel/familienarchiv#330

2026-04-25 01:32:08 +02:00

feat(#320): guided empty state + Kurrent primer for first-time transcribers

Review concerns addressed — 9 commits pushed

All blockers and suggestions from the 7 persona reviews have been resolved. Here's the full breakdown:

🎨 Design token: `--color-parchmen…

marcel pushed to feat/issue-320-transcribe-coach at marcel/familienarchiv

2026-04-25 01:31:38 +02:00

4f17c718d8 test(e2e): fix locators, add print assertion, cleanup, remove redundant emulateMedia

10768937ba chore(i18n): remove dead transcription_empty_draw_hint key

d2cee2a5b4 docs(richtlinien): document why prerender=true is auth-safe

0b1d67ca96 fix(richtlinien): <main> landmark + closing card h2 → h3

1715ceb53e fix(TranscribeCoachEmptyState): Tailwind grid instead of inline styles; step aria-labels

Compare 9 commits »

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 01:26:49 +02:00

feat(documents): bulk upload — split-panel with file switcher

Review concerns addressed — round 3

All open reviewer blockers and suggestions from the latest review cycle have been resolved in 3 new commits.

🔴 Blocker fixed (all reviewers)

**`…

marcel pushed to feat/issue-317-bulk-upload at marcel/familienarchiv

2026-04-25 01:26:21 +02:00

6b10daeeac fix(bulk-upload): accessibility improvements and fetch comment

74b473e3d7 fix(bulk-upload): match error chips by filename, not by chunk position

f1b3e8c2d8 fix(i18n): remove orphaned merge conflict markers from message files

Compare 3 commits »

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:58:50 +02:00

feat(documents): bulk upload — split-panel with file switcher

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

The implementation aligns well with the issue #317 requirements as described in the PR. One blocker and several…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:58:29 +02:00

feat(documents): bulk upload — split-panel with file switcher

🖥️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

No new infrastructure. One config change with operational implications.

Blockers

**1. Broken…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:58:15 +02:00

feat(documents): bulk upload — split-panel with file switcher

🎨 Leonie Voss — UX Designer & Accessibility Lead

Verdict: ⚠️ Approved with concerns

The bulk upload flow is well-structured and responsive. Accessibility work is evident (aria-live,…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:57:54 +02:00

feat(documents): bulk upload — split-panel with file switcher

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

Test coverage is strong. The blocker is the broken message files that will fail CI.

Blockers

**1. `messages/de.js…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:57:34 +02:00

feat(documents): bulk upload — split-panel with file switcher

🔐 Nora "NullX" Steiner — Security Engineer

Verdict: ⚠️ Approved with concerns

No critical vulnerabilities. Two items need attention before merge.

Blockers

**1. Broken JSON…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:57:17 +02:00

feat(documents): bulk upload — split-panel with file switcher

🏛️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

The overall approach is well-aligned with the monolith-first principle. No new services, no new infrastructur…

marcel commented on pull request marcel/familienarchiv#329

2026-04-25 00:57:00 +02:00

feat(documents): bulk upload — split-panel with file switcher

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

The architecture is solid and the component decomposition is clean. A few things warrant attention…