marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel pushed to main at marcel/familienarchiv 2026-04-24 13:20:31 +02:00
bdac5e42ad test(search): integration test covers paged search against real Postgres — address @saraholt
18b88672ec fix(pagination): bound controls render as aria-hidden spans — address @leonievoss
8fa061187e refactor(documents): extract buildSearchParams — address @felixbrandt
610915b2a2 refactor(test): extract UNPAGED Pageable constant — address @felixbrandt + @saraholt
78ac5d663d feat(documents): paginate search with a Pagination control
Compare 8 commits »
marcel deleted branch feat/issue-315-paginate-documents-search from marcel/familienarchiv 2026-04-24 13:20:29 +02:00
marcel closed issue marcel/familienarchiv#315 2026-04-24 13:20:27 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows
marcel merged pull request marcel/familienarchiv#316 2026-04-24 13:20:26 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows
marcel commented on pull request marcel/familienarchiv#316 2026-04-24 11:00:39 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows

Review Cycle 1 — Changes

Addressed

  • [@felixbrandt + @saraholt] PageRequest.of(0, 10_000) magic sentinel — extracted to a named UNPAGED constant on DocumentServiceTest and…
4f741a8701 test(search): integration test covers paged search against real Postgres — address @saraholt
a8edd0d9fd fix(pagination): bound controls render as aria-hidden spans — address @leonievoss
baf7ae3420 refactor(documents): extract buildSearchParams — address @felixbrandt
6808d9fb03 refactor(test): extract UNPAGED Pageable constant — address @felixbrandt + @saraholt
Compare 4 commits »
marcel closed issue marcel/familienarchiv#294 2026-04-24 10:48:58 +02:00
As a user creating a new document I want the same split-panel edit view as on existing documents, so I can enter metadata next to the file preview
marcel commented on issue marcel/familienarchiv#294 2026-04-24 10:48:57 +02:00
As a user creating a new document I want the same split-panel edit view as on existing documents, so I can enter metadata next to the file preview

Superseded by #317. The split-panel migration for /documents/new is now scoped together with the bulk-upload extension — they share the same route and the same split-panel layout decision.

The…

marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:48:53 +02:00
feat(documents): bulk upload — split-panel with file switcher

📎 Carried over from #294 (now closed — superseded by this issue)

Three items from #294 that should be explicit in the #317 scope:

1. Pre-implementation design decision (was #294's…

marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:45:19 +02:00
feat(documents): bulk upload — split-panel with file switcher

🗳️ Decision Queue — Action Required

3 decisions need your input before implementation starts. Everything else was turned into concrete recommendations.

Architecture

  • **Overload…
marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:45:03 +02:00
feat(documents): bulk upload — split-panel with file switcher

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • Blocker — multipart request limit: application.yaml sets max-file-size: 50MB but not max-request-size. Spring's…
marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:44:39 +02:00
feat(documents): bulk upload — split-panel with file switcher

🎨 Leonie Voss — UX & Accessibility Lead

Observations

  • The spec is thorough where it counts: AAA contrast verified in both themes (7.2:1 light / 9.2:1 dark for mint + navy), 44×44 touch…
marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:44:10 +02:00
feat(documents): bulk upload — split-panel with file switcher

🧪 Sara Holt — Senior QA Engineer

Observations

  • The unit + E2E plan in the issue is thorough on the frontend. The backend test coverage for the new behavior is under-specified — there…
marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:43:48 +02:00
feat(documents): bulk upload — split-panel with file switcher

🔐 Nora "NullX" Steiner — Application Security Engineer

Observations

  • Authorization is clean: /api/documents/quick-upload is already @RequirePermission(Permission.WRITE_ALL). Only…
marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:43:27 +02:00
feat(documents): bulk upload — split-panel with file switcher

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • Current /documents/new/+page.svelte is not the split-panel layout — it uses FileSectionNew.svelte + a collapsible…
marcel commented on issue marcel/familienarchiv#317 2026-04-24 10:43:01 +02:00
feat(documents): bulk upload — split-panel with file switcher

🏛️ Markus Keller — Senior Application Architect

Observations

  • Extending an existing endpoint instead of creating a new one fits the "simplest tool that works" principle — good call. -…
marcel commented on pull request marcel/familienarchiv#316 2026-04-24 10:33:34 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows

🎨 Leonie Voss — UX Designer & Accessibility Advocate

Verdict: ⚠️ Approved with concerns

What landed as expected

  • Plain <a href> for prev/next. No noScroll: true.…
marcel opened issue marcel/familienarchiv#317 2026-04-24 10:33:29 +02:00
feat(documents): bulk upload — split-panel with file switcher
marcel commented on pull request marcel/familienarchiv#316 2026-04-24 10:33:13 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

  • Zero compose/infra change. No new service, no new env var, no new port, no new volume, no…
marcel commented on pull request marcel/familienarchiv#316 2026-04-24 10:33:02 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

Coverage landed

  • Backend, controller (5 new): 200 path, rejection on oversized size, size-below-min, negative…