• Joined on 2026-03-17
marcel opened issue marcel/familienarchiv#315 2026-04-23 22:40:42 +02:00
feat(documents): paginate /documents search so first paint isn't 1500 rows
marcel commented on pull request marcel/familienarchiv#314 2026-04-23 22:36:23 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🎨 Leonie Voss — UX Designer & Accessibility Advocate

Verdict: ⚠️ Approved with concerns

What's right

  • 180×252, exact 5:7 A4 ratio. Matches DocumentThumbnail everywhere else…
marcel commented on pull request marcel/familienarchiv#314 2026-04-23 22:36:07 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

What I checked

  • No Compose changes. docker-compose.yml untouched, minio service handles thumbnail objects…
marcel commented on pull request marcel/familienarchiv#314 2026-04-23 22:35:54 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

What's solid

  • DocumentTest.java covers the three behavioural branches of the getter and locks the exact encoded URL…
marcel commented on pull request marcel/familienarchiv#314 2026-04-23 22:35:40 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🔒 Nora Steiner — Application Security Engineer

Verdict: Approved

Surface review

  • No injection. The URL is composed from id (UUID), a hardcoded path literal, and a…
marcel commented on pull request marcel/familienarchiv#314 2026-04-23 22:35:27 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🏛️ Markus Keller — Senior Application Architect

Verdict: Approved

Structure

  • Change stays inside the dashboard and model feature packages. No cross-boundary repository…
marcel commented on pull request marcel/familienarchiv#314 2026-04-23 22:35:16 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

What I checked

  • TDD evidence in commit history — every task has a red test before the green code. ✓
  • Guard…
marcel created pull request marcel/familienarchiv#314 2026-04-23 22:33:56 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance
marcel pushed to feat/issue-309-resume-strip-thumbnail at marcel/familienarchiv 2026-04-23 22:33:28 +02:00
89a15b7f27 feat(dashboard): fall back to document-text heroicon when no thumbnail yet
be7c368008 feat(dashboard): render real document thumbnail in resume strip
a7c573b8be refactor(thumbnails): drop frontend URL-builder now that backend owns the convention
3e5a3cb98a refactor(document-thumbnail): read doc.thumbnailUrl instead of composing locally
7f741f06bd chore(api): regenerate Document type with thumbnailUrl field
Compare 10 commits »
marcel created branch feat/issue-309-resume-strip-thumbnail in marcel/familienarchiv 2026-04-23 22:33:26 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-23 21:59:59 +02:00
0b33f323ee feat(briefwechsel): restore direction arrow next to row title
marcel pushed to main at marcel/familienarchiv 2026-04-23 21:53:51 +02:00
334b624063 feat(briefwechsel): bump row typography and drop relative-year chip
marcel pushed to main at marcel/familienarchiv 2026-04-23 21:39:06 +02:00
503ce49ef7 refactor(briefwechsel): TagChipList defaults max to 3
f5a30c71b7 i18n(briefwechsel): ThumbnailRow direction label via Paraglide
720f90299a refactor(e2e): visual spec shares seedBilateralPair + asserts person-bar
0e988a9d42 refactor(e2e): extract seedBilateralPair fixture + afterAll cleanup
8cb179a8a1 test(briefwechsel): visual spec seeds bilateral pair and asserts row structure
Compare 30 commits »
marcel deleted branch feat/issue-305-briefwechsel-thumbnail-rows from marcel/familienarchiv 2026-04-23 21:39:00 +02:00
marcel merged pull request marcel/familienarchiv#311 2026-04-23 21:38:58 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)
marcel closed issue marcel/familienarchiv#305 2026-04-23 21:38:58 +02:00
feature(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar
marcel commented on issue marcel/familienarchiv#309 2026-04-23 21:34:44 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🎯 Discussion Resolutions

After walking through every persona point with the user, here are the agreed decisions. These now act as the authoritative design for implementation.

Theme 1 —…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:21:25 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved

Both round-2 follow-ups I flagged are landed.

Direction label i18n (0da34d06)

Three locales, idiomatic…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:21:16 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Round 3 is still infrastructure-quiet. Issue #313 filed with the right labels (test, devops), scoped to one clear…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:21:12 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🧪 Sara Holt — QA & Test Strategist

Verdict: Approved

All four of my round-2 follow-ups resolved in the way I asked for.

Verified

  1. seedBilateralPair helper (00fa7674) —…