marcel

marcel commented on issue marcel/mealprep#51

2026-04-09 21:05:01 +02:00

feat(variety): implement C3 warning cards with recipe names and swap links (V1)

🧪 QA Engineer — Test Coverage

Questions & Observations

AC-5 is the sharpest edge case: Tags with only one affected day must produce no warning card. Test this explicitly with a…

marcel commented on issue marcel/mealprep#51

2026-04-09 21:04:44 +02:00

feat(variety): implement C3 warning cards with recipe names and swap links (V1)

🎨 Atlas — UI/UX Designer

Questions & Observations

"Tauschen →" link visual treatment: The spec mentions a "Tauschen →" link per row but doesn't specify the visual pattern. Is…

marcel commented on issue marcel/mealprep#51

2026-04-09 21:04:27 +02:00

feat(variety): implement C3 warning cards with recipe names and swap links (V1)

🧑‍💻 Kai — Frontend Engineer

Questions & Observations

$derived.by() usage is correct: Using $derived.by() for the two derived maps is the right Svelte 5 pattern. No concerns…

marcel commented on issue marcel/mealprep#52

2026-04-09 21:03:31 +02:00

feat(planner): desktop redesign — flip tiles, full-width grid, no right panel

⚙️ Backend Engineer

Questions & Observations

No backend changes in scope — as expected: "kein Backend-Änderungsbedarf" is the right call for V1. The flip and suggestion derivation…

marcel commented on issue marcel/mealprep#52

2026-04-09 21:03:17 +02:00

feat(planner): desktop redesign — flip tiles, full-width grid, no right panel

🔒 Sable — Security Engineer

Questions & Observations

No new API surface on flip — good: The spec correctly states "kein API-Aufruf beim Flip." This is a security positive. Verify…

marcel commented on issue marcel/mealprep#52

2026-04-09 21:02:56 +02:00

feat(planner): desktop redesign — flip tiles, full-width grid, no right panel

🧪 QA Engineer — Test Coverage

Questions & Observations

Tile states matrix: Four distinct states, four sets of tests. Confirm each has a dedicated component test:

marcel commented on issue marcel/mealprep#52

2026-04-09 21:02:36 +02:00

feat(planner): desktop redesign — flip tiles, full-width grid, no right panel

🎨 Atlas — UI/UX Designer

Questions & Observations

CSS token alignment for 14 new colour classes: The issue says "alle Farbwerte als CSS-Klassen in src/app.css". Clarify whether…

marcel commented on issue marcel/mealprep#52

2026-04-09 21:02:14 +02:00

feat(planner): desktop redesign — flip tiles, full-width grid, no right panel

🧑‍💻 Kai — Frontend Engineer

Questions & Observations

Flip state as $state(): The spec shows .card.flipped as a CSS class — in Svelte 5, the flipped state should live in a…

marcel commented on pull request marcel/mealprep#53

2026-04-09 20:36:32 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

⚙️ DevOps

Verdict: ⚠️ Approved with concerns

Concerns

1. Spring Boot request size not configured for image uploads Base64 encoding inflates file size by ~33%. A 1.5 MB JPEG…

marcel commented on pull request marcel/mealprep#53

2026-04-09 20:36:15 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

🎨 UI/UX Expert

Verdict: ✅ Approved

What works well

Image preview with remove button is clean and intuitive. The hover-to-red on "Bild entfernen" provides good destructive-acti…

marcel commented on pull request marcel/mealprep#53

2026-04-09 20:36:00 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

🔒 Security Expert

Verdict: 🚫 Changes requested

Blockers

1. No size limit on uploaded images — potential DoS / DB exhaustion heroImageUrl is stored as a text column with no…

marcel commented on pull request marcel/mealprep#53

2026-04-09 20:35:43 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

🧪 Tester — Test Coverage & Quality

Verdict: 🚫 Changes requested

Blockers

1. No regression test for the serves=null / cookTimeMin=null bug that was just fixed `RecipeService…

marcel commented on pull request marcel/mealprep#53

2026-04-09 20:35:28 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

🏛️ Architect — System Design & Layer Boundaries

Verdict: ⚠️ Approved with concerns

Blockers

**1. RecipeSummaryResponse includes heroImageUrl — list endpoint will become…

marcel commented on pull request marcel/mealprep#53

2026-04-09 20:35:12 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

1. IngredientEntry.quantity validation vs. frontend fallback mismatch `RecipeCreate…

marcel created pull request marcel/mealprep#53

2026-04-09 20:32:58 +02:00

feat(recipes): image upload, fix save 500, HelloFresh seed data

marcel created branch feat/issue-46-wire-suggestions-recipe-picker in marcel/mealprep

2026-04-09 20:23:33 +02:00

marcel pushed to feat/issue-46-wire-suggestions-recipe-picker at marcel/mealprep

2026-04-09 20:23:33 +02:00

520dae5adf feat(recipes): add image upload, fix save 500, seed HelloFresh data

116e400a91 refactor(planning): extract applyPenalties helper to unify score formula

49ed75a989 test(planner): verify mobile swap sheet triggers suggestion fetch

813ddf8214 feat(planner): change neutral badge copy to Kein Einfluss

7359eba946 feat(planner): hide RecipePicker inner header in swap context

Compare 10 commits »

marcel opened issue marcel/mealprep#52

2026-04-09 18:20:48 +02:00

feat(planner): desktop redesign — flip tiles, full-width grid, no right panel

marcel pushed to master at marcel/mealprep

2026-04-09 18:20:03 +02:00

f139dce82c docs(specs): add planner desktop redesign spec — flip tiles

marcel deleted branch feat/issue-46-wire-suggestions-recipe-picker from marcel/mealprep

2026-04-09 16:33:17 +02:00