marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/familienarchiv#209 2026-04-07 18:32:04 +02:00
feat(parser): improve GEB_PATTERN and store maiden name as alias

Complete Input/Output Table

Every geb-containing entry from the ODS, showing how each flows through the parser.

Direct geb inputs (after // pre-split where applicable)

marcel opened issue marcel/familienarchiv#212 2026-04-07 18:28:32 +02:00
feat(model): add title/salutation field to Person and make firstName optional
marcel opened issue marcel/familienarchiv#211 2026-04-07 18:28:13 +02:00
feat(model): add PersonType enum to distinguish persons from institutions/groups
marcel opened issue marcel/familienarchiv#210 2026-04-07 18:27:57 +02:00
feat(parser): strip parenthesized annotations in split() and preserve content
marcel opened issue marcel/familienarchiv#209 2026-04-07 18:27:47 +02:00
feat(parser): improve GEB_PATTERN and store maiden name as alias
marcel commented on pull request marcel/familienarchiv#208 2026-04-07 17:45:00 +02:00
feat(parser): support // separator and dot-compressed names

🛠️ Tobias Wendt — DevOps Engineer

Verdict: ✅ Approved

Infrastructure Impact

  • Pure Java code change — no new dependencies, no config changes, no Docker, CI, or deployment…
marcel commented on pull request marcel/familienarchiv#208 2026-04-07 17:44:55 +02:00
feat(parser): support // separator and dot-compressed names

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ✅ Approved

Assessment

This is a backend-only parsing change with no direct UI impact. No frontend components, routes, styles, or…

marcel commented on pull request marcel/familienarchiv#208 2026-04-07 17:44:49 +02:00
feat(parser): support // separator and dot-compressed names

🔒 Nora "NullX" Steiner — Security Engineer

Verdict: ✅ Approved

Attack Surface Analysis

  • Both changes are pure parsing logic in a backend utility class that processes spreadsheet…
marcel commented on pull request marcel/familienarchiv#208 2026-04-07 17:44:39 +02:00
feat(parser): support // separator and dot-compressed names

🧪 Sara Holt — QA Engineer

Verdict: ✅ Approved

Test Coverage Analysis

  • 12 new tests added, bringing PersonNameParserTest from 23 to 35 tests. All at the unit layer — correct…
marcel commented on pull request marcel/familienarchiv#208 2026-04-07 17:44:28 +02:00
feat(parser): support // separator and dot-compressed names

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

Architecture Check

  • Both changes are confined to PersonNameParser.java, a pure static utility class in the service…
marcel commented on pull request marcel/familienarchiv#208 2026-04-07 17:44:16 +02:00
feat(parser): support // separator and dot-compressed names

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

TDD Evidence

  • Red/green/refactor cycle followed correctly across 3 commits:
    1. Slash separator tests (RED) +…
marcel created pull request marcel/familienarchiv#208 2026-04-07 17:43:31 +02:00
feat(parser): support // separator and dot-compressed names
d6e74972eb test(parser): add regression and cross-feature interaction tests
0b57717586 feat(parser): normalize dot-compressed names in split()
59475efbcb feat(parser): support // as multi-person separator in parseReceivers
Compare 3 commits »
marcel created branch feat/issue-190-slash-separator-dot-compressed in marcel/familienarchiv 2026-04-07 17:43:17 +02:00
marcel commented on issue marcel/familienarchiv#190 2026-04-07 17:36:18 +02:00
feat(massimport): support // separator and dot-compressed names in PersonNameParser

Implementation Complete

All tasks done on branch feat/issue-190-slash-separator-dot-compressed.

Commits

  1. 59475ef **feat(parser): support // as multi-person separator in parseReceive…
marcel deleted branch feat/issue-181-person-name-aliases from marcel/familienarchiv 2026-04-07 16:44:27 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-07 16:44:26 +02:00
f435f2441c fix(model): add @JsonIgnore on PersonNameAlias.person to prevent LazyInitializationException
e204ed89b6 fix(ui): switch alias operations from client fetch to form actions
036843bf8f fix(ui): use mt-6 on save bar to match card spacing
9027f60760 fix(ui): use card-style save bar with mt-4 instead of full-bleed
0f5eebec29 fix(ui): move save bar to end of edit page after alias and danger zone
Compare 20 commits »
marcel closed issue marcel/familienarchiv#181 2026-04-07 16:44:26 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)
marcel merged pull request marcel/familienarchiv#206 2026-04-07 16:44:25 +02:00
feat: Person name aliases — support name changes over time #181
marcel opened issue marcel/familienarchiv#207 2026-04-07 16:34:48 +02:00
refactor: Replace native confirm() dialogs with a shared confirmation modal service