• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#176 2026-04-05 09:33:47 +02:00
feat: Annotation-backed collaborative transcription system

🔒 Nora "NullX" Steiner — Application Security Engineer

Questions & Observations

  • New attack surface: 7 API endpoints — this is the first feature that introduces user-generated…
marcel commented on issue marcel/familienarchiv#176 2026-04-05 09:33:27 +02:00
feat: Annotation-backed collaborative transcription system

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

  • 15 acceptance criteria — good coverage, but several are compound and need splitting for proper test mapping: …
marcel commented on issue marcel/familienarchiv#176 2026-04-05 09:33:11 +02:00
feat: Annotation-backed collaborative transcription system

🏗️ Markus Keller — Application Architect

Questions & Observations

  • This is the biggest feature in the project so far — new domain entity, new table, new service, new controller,…
marcel commented on issue marcel/familienarchiv#176 2026-04-05 09:32:52 +02:00
feat: Annotation-backed collaborative transcription system

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • This is a large feature — 7 new API endpoints, 2 Flyway migrations, 5+ new Svelte components, contenteditab…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 09:32:08 +02:00
feat: Expandable metadata header with labeled "Details" toggle

🔧 Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

  • No infrastructure impact — this is a purely frontend UI change. No new services, no new environment…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 09:32:03 +02:00
feat: Expandable metadata header with labeled "Details" toggle

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

  • 44×28px minimum tap target for the toggle — the spec calls this out, which is good for our 60+ users. But 28px height…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 09:31:44 +02:00
feat: Expandable metadata header with labeled "Details" toggle

🔒 Nora "NullX" Steiner — Application Security Engineer

Questions & Observations

  • Person links in the drawer — person names link to /persons/{id}. These are internal navigation…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 09:31:34 +02:00
feat: Expandable metadata header with labeled "Details" toggle

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

  • Acceptance criteria are testable — good. Each one maps to a concrete assertion. But a few gaps:
    • No…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 09:31:21 +02:00
feat: Expandable metadata header with labeled "Details" toggle

🏗️ Markus Keller — Application Architect

Questions & Observations

  • No backend changes needed — this is purely frontend, which is the right call. The metadata (date, sender,…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 09:31:07 +02:00
feat: Expandable metadata header with labeled "Details" toggle

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Component decomposition looks rightMetadataDrawer.svelte as a new component, Details toggle in…
marcel opened issue marcel/familienarchiv#177 2026-04-05 09:30:00 +02:00
feat: Transcription read mode (clean split)
marcel opened issue marcel/familienarchiv#176 2026-04-05 09:29:31 +02:00
feat: Annotation-backed collaborative transcription system
marcel opened issue marcel/familienarchiv#175 2026-04-05 09:29:00 +02:00
feat: Expandable metadata header with labeled "Details" toggle
marcel pushed to main at marcel/familienarchiv 2026-04-05 09:28:23 +02:00
46d64f50a5 docs(specs): add final specs for transcription feature
marcel commented on issue marcel/mealprep#42 2026-04-04 19:25:37 +02:00
feat: Add-to-Plan flows — C4 recipe picker, C5 quick actions, C6 day picker

💻 Kai — Frontend Engineer — Implementation Discussion Summary

Working through the open frontend architecture decisions before touching any code. Seven items discussed and resolved.


###…

marcel commented on pull request marcel/mealprep#43 2026-04-04 19:14:01 +02:00
feat: D1 — Shopping list (Issue #30)

📐 Architecture & DevOps Review

Verdict: Approved

What I checked

Layer boundaries, cross-cutting concern design, migration safety, Docker/deployment readiness, API design…

marcel commented on pull request marcel/mealprep#43 2026-04-04 19:13:29 +02:00
feat: D1 — Shopping list (Issue #30)

🎨 Atlas — UI/UX Designer

Verdict: ⚠️ Approved with concerns

What I checked

Design system compliance (tokens, fonts, spacing, radii), responsive layout, accessibility (WCAG 2.2 AA),…

marcel commented on pull request marcel/mealprep#43 2026-04-04 19:13:00 +02:00
feat: D1 — Shopping list (Issue #30)

🔒 Sable — Security Engineer

Verdict: ⚠️ Approved with concerns

What I checked

OWASP Top 10 against all changed code: access control, injection, authentication/authorization, data…

marcel commented on pull request marcel/mealprep#43 2026-04-04 19:12:33 +02:00
feat: D1 — Shopping list (Issue #30)

🧪 QA Engineer — Backend & Frontend Test Specialist

Verdict: ⚠️ Approved with concerns

What I checked

Test coverage, path analysis (happy/bad/edge), test quality and naming, missing…

marcel commented on pull request marcel/mealprep#43 2026-04-04 19:12:07 +02:00
feat: D1 — Shopping list (Issue #30)

🎨 Kai — Senior Frontend Engineer (Svelte 5 / SvelteKit 2)

Verdict: ⚠️ Approved with concerns

What I checked

Svelte 5 runes usage, SvelteKit 2 patterns (+page.server.ts / form…