marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 11:39:04 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

  • Flyway migrations (V18, V19, V20): Clean SQL, proper FK constraints with named indexes,…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 11:38:47 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

Blockers

None — the implementation follows the spec and discussion resolutions well.

Concerns

1.…

marcel commented on pull request marcel/familienarchiv#178 2026-04-05 11:38:21 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: 🚫 Changes requested

Blockers

  1. HTML sanitization via regex is insufficient (TranscriptionService.java:109): …
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 11:37:59 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: 🚫 Changes requested

Blockers

  1. Zero new tests in a 1,281-line addition PR. This is the single biggest quality gap I've…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 11:37:31 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🏗️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

Blockers

  1. TranscriptionService directly injects AnnotationService AND DocumentService —…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 11:37:04 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: 🚫 Changes requested

Blockers

  1. No tests anywhere in this PR. This is a TDD violation — every new behavior must have a…
marcel created pull request marcel/familienarchiv#178 2026-04-05 11:35:40 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)
1efd3d8e23 feat(transcription): add frontend transcription editing UI (#176)
5211e0b9f7 feat(topbar): add expandable metadata drawer with Details toggle (#175)
234f83c40b feat(i18n): add translation keys for metadata drawer and transcription
a46b1a2e84 feat(transcription): add backend entities, service, and controller
5231476c27 feat(transcription): add Flyway migrations for transcription blocks
Compare 5 commits »
marcel commented on issue marcel/familienarchiv#176 2026-04-05 11:03:15 +02:00
feat: Annotation-backed collaborative transcription system

🏗️ Markus Keller — Application Architect

Interactive architecture discussion with the project owner. All 7 items were resolved.

Resolved Items

  1. **Domain boundary: TranscriptionBlock…
marcel commented on issue marcel/familienarchiv#176 2026-04-05 10:42:51 +02:00
feat: Annotation-backed collaborative transcription system

🎨 Leonie Voss — UI/UX Discussion Summary

Worked through 10 open UI/UX items with the team. All resolved.

Resolved items

  1. Textarea over contenteditable — Use <textarea> with…
marcel commented on issue marcel/familienarchiv#175 2026-04-05 10:13:33 +02:00
feat: Expandable metadata header with labeled "Details" toggle

🎨 Leonie Voss — UI/UX Discussion Summary

Worked through 8 open UI/UX items with the team. All resolved.

Resolved items

  1. Tap target height — Update AC from "min 44×28px" to **min…
marcel commented on issue marcel/familienarchiv#177 2026-04-05 09:36:08 +02:00
feat: Transcription read mode (clean split)

🔧 Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

  • No infrastructure impact — purely frontend. No new services, no new environment variables, no new Docker…
marcel commented on issue marcel/familienarchiv#177 2026-04-05 09:35:58 +02:00
feat: Transcription read mode (clean split)

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

  • Typography choice: Tinos at 16px — Tinos is a good serif reading font, metrically compatible with Times New Roman. At…
marcel commented on issue marcel/familienarchiv#177 2026-04-05 09:35:35 +02:00
feat: Transcription read mode (clean split)

🔒 Nora "NullX" Steiner — Application Security Engineer

Questions & Observations

  • Read-only rendering — minimal attack surface — this is a display-only feature. The text comes…
marcel commented on issue marcel/familienarchiv#177 2026-04-05 09:35:22 +02:00
feat: Transcription read mode (clean split)

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

  • Good AC coverage — 15 criteria, mostly concrete and testable. A few observations:

  • Missing edge cases: …

marcel commented on issue marcel/familienarchiv#177 2026-04-05 09:35:06 +02:00
feat: Transcription read mode (clean split)

🏗️ Markus Keller — Application Architect

Questions & Observations

  • No backend changes — this is purely frontend. The data comes from the same endpoint as transcribe mode (`GET…
marcel commented on issue marcel/familienarchiv#177 2026-04-05 09:34:53 +02:00
feat: Transcription read mode (clean split)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Dependency on #176 — this issue can't be implemented until the transcription block backend (issue #176)…
marcel commented on issue marcel/familienarchiv#176 2026-04-05 09:34:23 +02:00
feat: Annotation-backed collaborative transcription system

🔧 Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

  • Flyway migrations — two new migrations: create transcription_blocks table, alter document_comments to add…
marcel commented on issue marcel/familienarchiv#176 2026-04-05 09:34:07 +02:00
feat: Annotation-backed collaborative transcription system

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

  • Contenteditable styling — the block cards use contenteditable for text input. This is the most delicate UI element in…