marcel

marcel pushed to main at marcel/familienarchiv

2026-03-31 10:41:43 +02:00

2dd73cf594 test(LanguageSwitcher): add Vitest unit tests for inverted prop

53038dea68 fix(header): address PR review blockers

281934529e fix(header): consistent icon styling, focus rings, and responsive breakpoints

c905f136d2 test(header): add Playwright tests for brand-navy header

36bf591afe feat(forgot-password): add AuthHeader for consistent auth page branding

Compare 12 commits »

marcel closed issue marcel/familienarchiv#163

2026-03-31 10:41:43 +02:00

feat(header): replace white header with brand-navy header per design spec

marcel merged pull request marcel/familienarchiv#165

2026-03-31 10:41:42 +02:00

feat(header): replace white header with brand-navy header per design spec

marcel pushed to feat/issue-163-brand-navy-header at marcel/familienarchiv

2026-03-31 10:39:39 +02:00

2dd73cf594 test(LanguageSwitcher): add Vitest unit tests for inverted prop

53038dea68 fix(header): address PR review blockers

Compare 2 commits »

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:38:19 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🚀 Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

This is a pure frontend CSS change — no infra, no config, no deployment concerns. But a few pipeline observations:

…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:38:02 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🎨 Leonie Voss — UI/UX Design Lead

This issue is in my domain. The values and intent are right — a few things to tighten up before implementation.

Contrast values — good, with one…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:37:39 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🔐 Nora "NullX" Steiner — Application Security Engineer

Questions & Observations

No direct security vulnerabilities in this change — adding CSS custom properties and updating focus ring…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:37:20 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

The acceptance criteria say "verified with keyboard navigation" — who verifies and how? Manual keyboard…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:36:57 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

🏛️ Markus Keller — Application Architect

Questions & Observations

Token naming consistency: The existing system uses --c-* for raw color tokens and --color-* for Tailwind…

marcel commented on issue marcel/familienarchiv#167

2026-03-31 10:36:39 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

Global CSS vs. per-component Tailwind? The issue proposes two approaches: a global `:focus-visible {…

marcel opened issue marcel/familienarchiv#167

2026-03-31 10:19:57 +02:00

feat(focus-rings): branded focus ring tokens for light and dark mode

marcel commented on issue marcel/familienarchiv#166

2026-03-31 10:19:34 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🎨 Leonie Voss — UI/UX Design Lead · Discussion Summary

Worked through five open items from my earlier review. Outcomes below.

Resolved — fold into this issue

**1. Focus rings…

marcel commented on issue marcel/familienarchiv#166

2026-03-31 09:51:25 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

This is a pure frontend CSS change — no Docker config, no environment variables, no infrastructure touch. Zero deployment risk…

marcel commented on issue marcel/familienarchiv#166

2026-03-31 09:51:10 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

The spec is well-structured and the navy-tinted direction is exactly right — dark mode should feel like an extension of the…

marcel commented on issue marcel/familienarchiv#166

2026-03-31 09:50:38 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🔐 Nora "NullX" Steiner — Security Engineer

Observations

This is a pure CSS token change with no server-side logic, no authentication surface, and no data handling changes. From a…

marcel commented on issue marcel/familienarchiv#166

2026-03-31 09:50:23 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🧪 Sara Holt — QA Engineer

Questions & Observations

The WCAG failure is a regression gap: Issue 03 describes a contrast failure (#6b7280 on #1a1a1a = 3.2:1) that exists in the…

marcel commented on issue marcel/familienarchiv#166

2026-03-31 09:50:03 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🏗️ Markus Keller — Application Architect

Questions & Observations

Tailwind 4 @theme inline support: The implementation snippet uses `@theme inline { --color-header: var(--c-heade…

marcel commented on issue marcel/familienarchiv#166

2026-03-31 09:49:41 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

File name ambiguity: The issue says frontend/src/app.css (or layout.css). These are different files…

marcel opened issue marcel/familienarchiv#166

2026-03-31 09:47:34 +02:00

feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

marcel closed issue marcel/familienarchiv#68

2026-03-31 09:40:47 +02:00

As a user I want the new document form to lead with file upload and treat all metadata fields as optional so I can save a document quickly without filling everything out upfront