marcel

marcel commented on pull request marcel/familienarchiv#164

2026-03-30 18:26:09 +02:00

feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

This is a substantial, well-structured feature. The component decomposition is clean — `CorrespondenzP…

marcel created pull request marcel/familienarchiv#164

2026-03-30 18:21:04 +02:00

feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

marcel pushed to feat/issue-162-korrespondenz-redesign at marcel/familienarchiv

2026-03-30 18:20:33 +02:00

9d6c7b8605 test(DateInput): add Vitest specs for DateInput component and date utils

56d79c919e fix(PersonTypeahead): sync searchTerm when initialName prop changes

3318b5f1c6 fix(korrespondenz): larger empty state text, hide divider+chips when no history

71eaca9495 fix(korrespondenz): flush strips to top, larger year divider and row text

a3a7af123d fix(korrespondenz): scale up strip rows to readable sizes

Compare 10 commits »

marcel created branch feat/issue-162-korrespondenz-redesign in marcel/familienarchiv

2026-03-30 18:20:32 +02:00

marcel commented on issue marcel/familienarchiv#163

2026-03-30 18:15:23 +02:00

feat(header): replace white header with brand-navy header per design spec

🎨 Leonie Voss — UI/UX Designer — Discussion Summary

Worked through five open items from my earlier review. All resolved.

1. Header background & accent strip tokens Use bg-primary…

marcel commented on issue marcel/familienarchiv#163

2026-03-30 17:43:37 +02:00

feat(header): replace white header with brand-navy header per design spec

⚙️ Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

No infrastructure changes — this is a frontend-only CSS/Tailwind change. No Docker Compose changes, no…

marcel commented on issue marcel/familienarchiv#163

2026-03-30 17:43:16 +02:00

feat(header): replace white header with brand-navy header per design spec

🎨 Leonie Voss — UI/UX Designer

This issue is directly in my domain — the spec is detailed and well-considered. A few things I want to ensure we get right:

Questions & Observations

-…

marcel commented on issue marcel/familienarchiv#163

2026-03-30 17:42:46 +02:00

feat(header): replace white header with brand-navy header per design spec

🔐 Nora "NullX" Steiner — Security Engineer

Questions & Observations

Low security surface — this is a CSS/layout change with no new data flows, authentication changes, or backend…

marcel commented on issue marcel/familienarchiv#163

2026-03-30 17:42:21 +02:00

feat(header): replace white header with brand-navy header per design spec

🧪 Sara Holt — QA Engineer

Questions & Observations

No unit tests applicable here — CSS/styling changes don't produce meaningful Vitest unit test coverage. The test burden for…

marcel commented on issue marcel/familienarchiv#163

2026-03-30 17:41:57 +02:00

feat(header): replace white header with brand-navy header per design spec

🏗️ Markus Keller — Application Architect

Questions & Observations

Brand constant vs. semantic token: The issue correctly identifies that brand-navy is a brand constant, not a…

marcel commented on issue marcel/familienarchiv#163

2026-03-30 17:41:35 +02:00

feat(header): replace white header with brand-navy header per design spec

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

TDD challenge: This is a purely visual/CSS change — there's no meaningful unit test to write first. The…

marcel opened issue marcel/familienarchiv#163

2026-03-30 17:34:39 +02:00

feat(header): replace white header with brand-navy header per design spec

marcel pushed to main at marcel/familienarchiv

2026-03-30 17:32:24 +02:00

c61b08d6de docs(specs): add header/nav redesign spec

marcel commented on issue marcel/familienarchiv#162

2026-03-30 13:08:28 +02:00

feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

Implementation complete ✅

All 9 tasks implemented on branch feat/issue-162-korrespondenz-redesign.

Commits

marcel commented on issue marcel/familienarchiv#161

2026-03-30 12:46:47 +02:00

feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🎨 Leonie Voss — Design Review Discussion

Follow-up discussion resolving the open questions from my earlier review comment. All seven items were worked through with the team.

✅…

marcel commented on issue marcel/familienarchiv#161

2026-03-30 12:24:53 +02:00

feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

⚙️ Tobias Wendt — DevOps & Platform Engineer

No Infrastructure Changes Required

This is a pure frontend component change. No new services, no new environment variables, no new Docker…

marcel commented on issue marcel/familienarchiv#161

2026-03-30 12:24:29 +02:00

feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🎨 Leonie Voss — UI/UX Design Lead

Critical: Font Sizes Below Any Accessible Threshold

This is my primary concern with the spec as written. Several text sizes specified are dangerously…

marcel commented on issue marcel/familienarchiv#161

2026-03-30 12:23:52 +02:00

feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🔐 Nora "NullX" Steiner — Application Security Engineer

Attack Surface Assessment

This is a frontend-only UI component change with no new API endpoints, no new backend logic, and no new…

marcel commented on issue marcel/familienarchiv#161

2026-03-30 12:23:27 +02:00

feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🧪 Sara Holt — QA Engineer & Test Strategist

Test Strategy

This feature has significant logic complexity hiding behind its visual surface. Here's how I'd layer the test coverage:

**Unit…

marcel commented on issue marcel/familienarchiv#161

2026-03-30 12:22:58 +02:00

feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🏛️ Markus Keller — Application Architect

Scope Assessment

This is a pure frontend component change — no backend, no database, no new services. The scope is well-contained and the…