• Joined on 2026-03-17
marcel commented on issue marcel/mealprep#15 2026-04-03 09:28:12 +02:00
No password complexity requirements beyond minimum length

🔐 Sable — Security Engineer

Good issue — this is exactly the kind of low-severity finding that gets ignored until it isn't. Let me add some depth to both recommendations.

**BCrypt DoS —…

marcel commented on issue marcel/mealprep#3 2026-04-03 09:28:07 +02:00
Signup creates session but never authenticates the user

🎨 Atlas — UI/UX Designer

The fix choice here has a direct UX consequence that I want to flag as a design decision, not just a backend implementation detail.

**The two paths feel very…

marcel commented on issue marcel/mealprep#11 2026-04-03 09:28:04 +02:00
Unbounded limit/offset parameters allow resource exhaustion

🎨 Atlas — UI/UX Designer

Backend validation issue, but pagination parameters touch the UI in a few ways worth designing around.

Where pagination appears in the UI

  • Any recipe list…
marcel commented on issue marcel/mealprep#29 2026-04-03 09:28:01 +02:00
Frontend: J4 — Swap flow (action sheet + quick suggestions)

🔐 Sable — Security Engineer

The swap flow is planner-only and involves a write operation to the week plan. The primary risks are authorization bypass and the undo pattern creating a replay…

marcel commented on issue marcel/mealprep#15 2026-04-03 09:28:00 +02:00
No password complexity requirements beyond minimum length

🧪 QA Engineer — Password Complexity (Issue #15)

The current test coverage for password validation is presumably just the happy path and the @Size(min = 8) rejection. Here's what I'd want…

marcel commented on issue marcel/mealprep#7 2026-04-03 09:27:59 +02:00
Missing catch-all exception handler — stack traces leak to clients

👨‍💻 Kai — Frontend Engineer

Backend fix, but it directly affects what the SvelteKit frontend receives and has to handle. A few things I want to pin down:

**Current frontend behavior on…

marcel commented on issue marcel/mealprep#3 2026-04-03 09:27:58 +02:00
Signup creates session but never authenticates the user

🔒 Sable — Security Engineer

This is correctly rated Critical. The orphaned session is the most dangerous part — let me explain the attack surface clearly.

**The orphaned session attack…

marcel commented on issue marcel/mealprep#11 2026-04-03 09:27:55 +02:00
Unbounded limit/offset parameters allow resource exhaustion

🔒 Sable — Security Engineer

Two vulnerabilities in one issue — both exploitable with a single HTTP request, no authentication bypass required.

**Vulnerability 1: Denial of Service via…

marcel commented on issue marcel/mealprep#25 2026-04-03 09:27:53 +02:00
Frontend: B4 — Cook mode (full-screen step-by-step)

🔒 Sable — Security Engineer

B4 is simpler than C1 from a security standpoint, but the "Mark as cooked" write and the full-screen, navigation-free layout create a few specific concerns worth…

marcel commented on issue marcel/mealprep#15 2026-04-03 09:27:49 +02:00
No password complexity requirements beyond minimum length

🔧 Backend Engineer — Password Complexity (Issue #15)

Good catch. The BCrypt DoS vector is the more pressing of the two concerns. Let me break down both recommendations:

**BCrypt max length…

marcel commented on issue marcel/mealprep#3 2026-04-03 09:27:45 +02:00
Signup creates session but never authenticates the user

🧪 QA Engineer

Critical severity means I want this covered with both unit and integration tests before the fix ships. Here's the full test plan.

**Current behavior to confirm (regression…

marcel commented on issue marcel/mealprep#8 2026-04-03 09:27:42 +02:00
Login error responses enable account enumeration via HTTP status codes

🎨 Atlas — UI/UX Designer

The fix is purely backend, but it directly affects what the login screen communicates to the user. Let me make sure the UX intent is consistent:

**Error message…

marcel commented on issue marcel/mealprep#11 2026-04-03 09:27:40 +02:00
Unbounded limit/offset parameters allow resource exhaustion

🧪 QA Engineer

Two distinct failure modes here — each needs its own test, and both are easy to reproduce reproducibly.

Tests for the division-by-zero crash (limit=0)

  • `shouldReturn400…
marcel commented on issue marcel/mealprep#29 2026-04-03 09:27:39 +02:00
Frontend: J4 — Swap flow (action sheet + quick suggestions)

🧪 QA Engineer — Test Coverage Plan for J4 Swap Flow

The ≤3-tap constraint is testable and the swap logging requirement makes the data trail auditable. Here's what needs full coverage.

**Bac…

marcel commented on issue marcel/mealprep#25 2026-04-03 09:27:38 +02:00
Frontend: B4 — Cook mode (full-screen step-by-step)

🧪 QA Engineer

B4 looks simple on the surface, but it has some genuinely tricky test scenarios — async browser APIs, stateful progression, and a write at the end that feeds a downstream…

marcel commented on issue marcel/mealprep#15 2026-04-03 09:27:35 +02:00
No password complexity requirements beyond minimum length

👨‍💻 Kai — Frontend Engineer

This is a backend issue, but it has a direct frontend implication: whatever password rules the backend enforces, the signup form (A2) and the join-household form…

marcel commented on issue marcel/mealprep#3 2026-04-03 09:27:34 +02:00
Signup creates session but never authenticates the user

🏗️ Backend Engineer — Spring Boot / PostgreSQL Specialist

Marked Critical — correctly. The orphaned session is the dangerous part. Let me lay out the two fix paths precisely.

**Fix path A:…

marcel commented on issue marcel/mealprep#11 2026-04-03 09:27:29 +02:00
Unbounded limit/offset parameters allow resource exhaustion

🛠️ Backend Engineer

Two separate bugs in one issue — worth fixing together but tracking distinctly: a division-by-zero crash and an unbounded resource consumption vector.

**Fix for…

marcel commented on issue marcel/mealprep#8 2026-04-03 09:27:27 +02:00
Login error responses enable account enumeration via HTTP status codes

🔐 Sable — Security Engineer

This is a classic OWASP A07 (Authentication Failures) vulnerability and it's correctly labeled high. The attack scenario in the issue is accurate. A few things to…

marcel commented on issue marcel/mealprep#3 2026-04-03 09:27:24 +02:00
Signup creates session but never authenticates the user

👨‍💻 Kai — Frontend Engineer

This bug directly affects the signup → auto-login → redirect flow that the frontend depends on. I need clarity on the intended post-signup behavior before I…