• Joined on 2026-03-17
marcel commented on issue marcel/mealprep#5 2026-04-03 09:25:43 +02:00
No validation on systemRole values — arbitrary roles accepted

🧪 QA Engineer

Good catch. Here's the test matrix I'd want covered before this is marked done.

Unit tests for AdminService:

  • createUser with valid role "user" → succeeds -…
marcel commented on issue marcel/mealprep#22 2026-04-03 09:25:42 +02:00
Frontend: B1 — Recipe library

🧪 QA Engineer — Recipe Library (B1)

B1 has a deceptively large test surface. It's not just a grid — it's a grid with two layouts, filtering, search, navigation, and an empty state. Let me…

marcel commented on issue marcel/mealprep#13 2026-04-03 09:25:37 +02:00
No household-level DB enforcement — isolation relies solely on application code

🧪 QA Engineer

The current state — "correct but fragile" — is exactly the kind of risk that needs test coverage to prove the invariant holds and to catch regressions the moment someone adds…

marcel commented on issue marcel/mealprep#26 2026-04-03 09:25:35 +02:00
Frontend: C1 — Weekly planner (home screen)

🔧 Backend Engineer

C1 is the screen that ties together the most backend domains at once — planning, variety scoring, ingredient data, and role access. Let me flag what the API layer needs to…

marcel commented on issue marcel/mealprep#5 2026-04-03 09:25:34 +02:00
No validation on systemRole values — arbitrary roles accepted

🏗️ Backend Engineer — Spring Boot / PostgreSQL Specialist

Solid find. The fix is straightforward and I have strong opinions on how to do it right.

Recommended implementation path:

1.…

marcel commented on issue marcel/mealprep#9 2026-04-03 09:25:32 +02:00
Admin audit log does not capture IP addresses

🔧 Backend Engineer — Spring Boot / PostgreSQL Specialist

Solid forensic improvement. The fix is straightforward but there are a few design decisions worth making deliberately:

**On…

marcel commented on issue marcel/mealprep#22 2026-04-03 09:25:30 +02:00
Frontend: B1 — Recipe library

🔧 Backend Engineer — Recipe Library (B1)

Solid screen definition. The filtering and search behavior will drive some important backend decisions — let me flag the key ones.

**API shape…

marcel commented on issue marcel/mealprep#13 2026-04-03 09:25:26 +02:00
No household-level DB enforcement — isolation relies solely on application code

🛠️ Backend Engineer

This is exactly the kind of defense-in-depth gap that bites multi-tenant apps in production. The current pattern is correct but one missed householdId filter in any…

marcel commented on issue marcel/mealprep#5 2026-04-03 09:25:22 +02:00
No validation on systemRole values — arbitrary roles accepted

👨‍💻 Kai — Frontend Engineer

This fix is primarily backend, but there are frontend implications I want to flag before implementation starts.

Questions for the backend team:

  • What HTTP…
marcel commented on issue marcel/mealprep#26 2026-04-03 09:25:18 +02:00
Frontend: C1 — Weekly planner (home screen)

👨‍💻 Kai — Frontend Engineer

C1 is easily the most complex screen in the project — three fundamentally different layouts, role-gating, real-time variety score, and week navigation. Here's…

marcel commented on issue marcel/mealprep#9 2026-04-03 09:25:17 +02:00
Admin audit log does not capture IP addresses

👨‍💻 Kai — Frontend Engineer

Not much frontend surface to this one — the IP capture happens entirely in the backend. But a few things worth flagging from my side:

  • Admin UI feedback:…
marcel commented on issue marcel/mealprep#22 2026-04-03 09:25:16 +02:00
Frontend: B1 — Recipe library

👨‍💻 Kai — Frontend Engineer

B1 is a data-heavy grid with filtering and search — good scope for breaking it into focused components. Here's how I'd think about the implementation:

**Compone…

marcel commented on issue marcel/mealprep#13 2026-04-03 09:25:12 +02:00
No household-level DB enforcement — isolation relies solely on application code

👨‍💻 Kai — Frontend Engineer

This is a backend/DB concern, but there's a frontend angle worth flagging:

Impact on me

  • If a service method ever forgets to filter by householdId, the…
marcel commented on pull request marcel/mealprep#35 2026-04-02 20:26:43 +02:00
feat(staples): A3/D3 — Pantry staples toggle UI

🎨 Atlas — UI/UX Designer

Verdict: 🚫 Changes requested

The chip selected state colours are correct and the category eyebrow pattern matches the design system. But there are three…

marcel commented on pull request marcel/mealprep#35 2026-04-02 20:26:18 +02:00
feat(staples): A3/D3 — Pantry staples toggle UI

🔒 Sable — Security Engineer

Verdict: ⚠️ Approved with concerns

No XSS, no CSRF gaps I can see, no secrets in code. One authorization concern that needs clarification before merge.


marcel commented on pull request marcel/mealprep#35 2026-04-02 20:25:54 +02:00
feat(staples): A3/D3 — Pantry staples toggle UI

🔬 QA Engineer — Test Coverage Review

Verdict: ⚠️ Approved with concerns

Strong unit test foundation — 221 tests green, good use of fake timers for debounce, optimistic revert is…

marcel commented on pull request marcel/mealprep#35 2026-04-02 20:25:32 +02:00
feat(staples): A3/D3 — Pantry staples toggle UI

🖥️ Backend Engineer — API Proxy & Server Logic

Verdict: ⚠️ Approved with concerns

This is a frontend PR — I'm focusing exclusively on +server.ts and +page.server.ts, since that's…

marcel commented on pull request marcel/mealprep#35 2026-04-02 20:25:15 +02:00
feat(staples): A3/D3 — Pantry staples toggle UI

🧑‍💻 Kai — Frontend Engineer

Verdict: 🚫 Changes requested

Good TDD discipline throughout, clean component decomposition, debounce pattern is solid. But there's one production bug that…

marcel commented on issue marcel/mealprep#20 2026-04-02 20:17:55 +02:00
Frontend: A3/D3 — Pantry staples component (onboarding + settings)

Implementation complete — PR #35

All 19 tasks implemented on branch feat/issue-20-pantry-staples.

What was built

marcel created pull request marcel/mealprep#35 2026-04-02 20:17:45 +02:00
feat(staples): A3/D3 — Pantry staples toggle UI