marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/mealprep#33 2026-04-02 17:33:47 +02:00
Frontend: design system, navigation, auth guard, signup screen

🧪 QA Engineer — Test Coverage

Verdict: ⚠️ Approved with concerns

The auth flow was completely broken before this PR — no tests caught it. That gap needs to be addressed.

###…

marcel commented on pull request marcel/mealprep#33 2026-04-02 17:33:37 +02:00
Frontend: design system, navigation, auth guard, signup screen

🗄️ Backend Engineer — Spring Boot / PostgreSQL

Verdict: ⚠️ Approved with concerns

The auth fixes are architecturally sound and the session management approach is correct. A few things…

marcel commented on pull request marcel/mealprep#33 2026-04-02 17:33:31 +02:00
Frontend: design system, navigation, auth guard, signup screen

🧑‍💻 Kai — Frontend Engineer

Verdict: ⚠️ Approved with concerns

The auth fixes are correct and the approach is clean. A few things worth flagging.

Blockers

None.

Suggestions

…

marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 17:31:39 +02:00
0aa65214fc fix(auth): resolve broken signup/login flow end-to-end
ab3363eeec refactor(auth): use shared BrandPanel on login page
Compare 2 commits »
marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 16:21:46 +02:00
999e54de86 feat(auth): build login page with LoginForm, brand panel, and title
73acc0c638 feat(auth): add login server action with validation and redirect
c27c97ff7d feat(auth): add LoginForm component with validation and password toggle
Compare 3 commits »
marcel deleted branch feat/issue-173-document-topbar from marcel/familienarchiv 2026-04-02 16:13:57 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-02 16:13:56 +02:00
1a57ec2036 feat(topbar): add divider between sender/receiver block and action buttons
e362bc4977 feat(topbar): remove DocumentStatusChip — status dot has no value for users
01ba0d4121 feat(topbar): make PersonChip a link to the person detail page
2e6366faf7 feat(topbar): add topbar_overflow_suffix i18n key and use it in overflow pill button
9dd35999e0 fix(topbar): fix overflow pill popup clipped and hidden behind pdf viewer
Compare 32 commits »
marcel closed issue marcel/familienarchiv#173 2026-04-02 16:13:52 +02:00
feat(ui): implement responsive DocumentTopBar — final spec
marcel merged pull request marcel/familienarchiv#174 2026-04-02 16:13:50 +02:00
feat(topbar): responsive DocumentTopBar — issue #173
marcel commented on pull request marcel/mealprep#33 2026-04-02 15:08:35 +02:00
Frontend: design system, navigation, auth guard, signup screen

Review Fixes Applied

All reviewer concerns addressed. 122 tests pass, 0 type errors.

marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 15:08:18 +02:00
b3607ca47a test(auth): add password length boundary tests (7 fails, 8 passes)
7de18740f2 test(auth): add multi-error test for empty form submission
6d0f00c8fb feat(auth): add use:enhance and server error display to signup form
bd9e1334e0 feat(auth): add server-side validation to signup form action
82840bb420 fix(auth): center signup form on wide desktop screens
Compare 9 commits »
marcel commented on pull request marcel/mealprep#33 2026-04-02 14:53:49 +02:00
Frontend: design system, navigation, auth guard, signup screen

🗄️ Backend Engineer — Spring Boot / PostgreSQL

Verdict: ✅ Approved

Observations

This PR is frontend-only from my perspective. The backend integration points look correct:

  • **API…
marcel commented on issue marcel/mealprep#19 2026-04-02 14:53:48 +02:00
Frontend: A2 — Household setup + invite

🧑‍💻 Kai — Frontend Engineer — Implementation Discussion

Worked through all open frontend items. Everything resolved.

Resolved

  • Route group — No route group. A2 lives at…
marcel commented on pull request marcel/mealprep#33 2026-04-02 14:53:30 +02:00
Frontend: design system, navigation, auth guard, signup screen

🎨 Atlas — UI/UX Designer

Verdict: ⚠️ Approved with concerns

Blockers

None.

Concerns

  1. Submit button uses --green instead of --green-dark. Per the design system,…
marcel commented on pull request marcel/mealprep#33 2026-04-02 14:53:08 +02:00
Frontend: design system, navigation, auth guard, signup screen

🔒 Sable — Security Engineer

Verdict: 🚫 Changes requested

Blockers

  1. No server-side input validation. The form action in +page.server.ts:7-9 does `formData.get('displayName')…
marcel commented on pull request marcel/mealprep#33 2026-04-02 14:52:45 +02:00
Frontend: design system, navigation, auth guard, signup screen

🧪 QA Engineer — Test Coverage Review

Verdict: ⚠️ Approved with concerns

What's well covered

  • BrandPanel: 5 tests covering all visible content (logo, name, tagline, feature icons…
marcel commented on pull request marcel/mealprep#33 2026-04-02 14:52:22 +02:00
Frontend: design system, navigation, auth guard, signup screen

🧑‍💻 Kai — Frontend Engineer

Verdict: ⚠️ Approved with concerns

Blockers

None.

Concerns

  1. **SignupForm uses bg-[var(--green)] for the submit button, but the design…
marcel created pull request marcel/mealprep#33 2026-04-02 14:51:29 +02:00
Frontend: design system, navigation, auth guard, signup screen
marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 14:51:15 +02:00
bfa8f20fe3 test(auth): add no-nav-chrome regression test for signup page
596652d6e4 feat(auth): add signup page with form action
d3a8518298 feat(auth): add SignupForm component with validation and password toggle
d5d85d1156 rename backend service
e8fe69a543 feat(auth): add BrandPanel component for signup screen
Compare 7 commits »
marcel created branch feat/issue-16-design-system in marcel/mealprep 2026-04-02 14:51:14 +02:00