• Joined on 2026-03-17
marcel opened issue marcel/familienarchiv#163 2026-03-30 17:34:39 +02:00
feat(header): replace white header with brand-navy header per design spec
marcel pushed to main at marcel/familienarchiv 2026-03-30 17:32:24 +02:00
c61b08d6de docs(specs): add header/nav redesign spec
marcel commented on issue marcel/familienarchiv#162 2026-03-30 13:08:28 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

Implementation complete

All 9 tasks implemented on branch feat/issue-162-korrespondenz-redesign.

Commits

marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:46:47 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🎨 Leonie Voss — Design Review Discussion

Follow-up discussion resolving the open questions from my earlier review comment. All seven items were worked through with the team.


marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:24:53 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

⚙️ Tobias Wendt — DevOps & Platform Engineer

No Infrastructure Changes Required

This is a pure frontend component change. No new services, no new environment variables, no new Docker…

marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:24:29 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🎨 Leonie Voss — UI/UX Design Lead

Critical: Font Sizes Below Any Accessible Threshold

This is my primary concern with the spec as written. Several text sizes specified are dangerously…

marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:23:52 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🔐 Nora "NullX" Steiner — Application Security Engineer

Attack Surface Assessment

This is a frontend-only UI component change with no new API endpoints, no new backend logic, and no new…

marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:23:27 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🧪 Sara Holt — QA Engineer & Test Strategist

Test Strategy

This feature has significant logic complexity hiding behind its visual surface. Here's how I'd layer the test coverage:

**Unit…

marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:22:58 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

🏛️ Markus Keller — Application Architect

Scope Assessment

This is a pure frontend component change — no backend, no database, no new services. The scope is well-contained and the…

marcel commented on issue marcel/familienarchiv#161 2026-03-30 12:22:34 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation

👨‍💻 Felix Brandt — Senior Fullstack Developer

Component Decomposition First

The issue describes multiple distinct visual regions packed into one component. Before writing a single line…

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:53:13 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

Resolution — Implementation decisions

Phase 0 — Backend prerequisites (must merge before frontend work begins)

The frontend depends on two backend changes that do not exist yet:

**0a.…

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:31:59 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

⚙️ Tobias Wendt — DevOps & Platform Engineer

Route rename has no infrastructure impact — but the redirect does

The SvelteKit route move from conversations/ to korrespondenz/ is a…

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:31:37 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

🎨 Leonie Voss — UX Lead & Accessibility Strategist

Critical: font sizes are below the 12px minimum floor

Several sizes specified in this issue will be illegal in production:

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:31:03 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

🔒 Nora "NullX" Steiner — Application Security Engineer

Authorization gap on senderId / receiverId params — Medium risk

The URL params senderId and receiverId are user-controlled…

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:30:29 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

🧪 Sara Holt — QA Engineer & Test Strategist

The load function has no tests listed — that's the gap I care most about

Section 11 lists component rendering tests but +page.server.ts

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:29:59 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

🏗️ Markus Keller — Application Architect

The single-person mode API gap is the most important open question

The issue defers the backend work with "Option A / Option B / or return []"…

marcel commented on issue marcel/familienarchiv#162 2026-03-30 11:29:32 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode

👨‍💻 Felix Brandt — Senior Fullstack Developer

Component decomposition

The issue describes ConversationFilterBar.svelte as a single component, but I count at least three visually…

marcel commented on pull request marcel/familienarchiv#160 2026-03-30 11:24:47 +02:00
feat: Admin section redesign (Concept C) + Persons redesign (Concept A)

👨‍💻 Felix Brandt — Response to Review Feedback

All concerns addressed in commit 393cb52. Summary of what was done per reviewer:


Felix Brandt

Blockers fixed:

**`localStorage…

marcel opened issue marcel/familienarchiv#162 2026-03-30 10:54:57 +02:00
feat(ui): Korrespondenz redesign — compact strip, log cards, single-person mode
marcel commented on pull request marcel/familienarchiv#160 2026-03-30 10:53:57 +02:00
feat: Admin section redesign (Concept C) + Persons redesign (Concept A)

🛠️ Tobias Wendt (@tobiwendt) — DevOps & Platform Engineer

Approved

This is a pure frontend/backend application change with no infrastructure modifications. There are no new Docker…