• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#167 2026-03-31 10:36:57 +02:00
feat(focus-rings): branded focus ring tokens for light and dark mode

🏛️ Markus Keller — Application Architect

Questions & Observations

  • Token naming consistency: The existing system uses --c-* for raw color tokens and --color-* for Tailwind…
marcel commented on issue marcel/familienarchiv#167 2026-03-31 10:36:39 +02:00
feat(focus-rings): branded focus ring tokens for light and dark mode

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Global CSS vs. per-component Tailwind? The issue proposes two approaches: a global `:focus-visible {…
marcel opened issue marcel/familienarchiv#167 2026-03-31 10:19:57 +02:00
feat(focus-rings): branded focus ring tokens for light and dark mode
marcel commented on issue marcel/familienarchiv#166 2026-03-31 10:19:34 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🎨 Leonie Voss — UI/UX Design Lead · Discussion Summary

Worked through five open items from my earlier review. Outcomes below.


Resolved — fold into this issue

**1. Focus rings…

marcel commented on issue marcel/familienarchiv#166 2026-03-31 09:51:25 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

This is a pure frontend CSS change — no Docker config, no environment variables, no infrastructure touch. Zero deployment risk…

marcel commented on issue marcel/familienarchiv#166 2026-03-31 09:51:10 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

The spec is well-structured and the navy-tinted direction is exactly right — dark mode should feel like an extension of the…

marcel commented on issue marcel/familienarchiv#166 2026-03-31 09:50:38 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🔐 Nora "NullX" Steiner — Security Engineer

Observations

This is a pure CSS token change with no server-side logic, no authentication surface, and no data handling changes. From a…

marcel commented on issue marcel/familienarchiv#166 2026-03-31 09:50:23 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🧪 Sara Holt — QA Engineer

Questions & Observations

  • The WCAG failure is a regression gap: Issue 03 describes a contrast failure (#6b7280 on #1a1a1a = 3.2:1) that exists in the…
marcel commented on issue marcel/familienarchiv#166 2026-03-31 09:50:03 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

🏗️ Markus Keller — Application Architect

Questions & Observations

  • Tailwind 4 @theme inline support: The implementation snippet uses `@theme inline { --color-header: var(--c-heade…
marcel commented on issue marcel/familienarchiv#166 2026-03-31 09:49:41 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • File name ambiguity: The issue says frontend/src/app.css (or layout.css). These are different files…
marcel opened issue marcel/familienarchiv#166 2026-03-31 09:47:34 +02:00
feat(dark-mode): replace neutral-black tokens with navy-tinted palette + fix WCAG AA failure
marcel closed issue marcel/familienarchiv#68 2026-03-31 09:40:47 +02:00
As a user I want the new document form to lead with file upload and treat all metadata fields as optional so I can save a document quickly without filling everything out upfront
marcel commented on pull request marcel/familienarchiv#165 2026-03-31 09:25:19 +02:00
feat(header): replace white header with brand-navy header per design spec

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

No infrastructure, CI workflow, Docker Compose, or deployment configuration changes in this PR. Reviewing from a…

marcel commented on pull request marcel/familienarchiv#165 2026-03-31 09:25:06 +02:00
feat(header): replace white header with brand-navy header per design spec

🎨 Leonie Voss — UI/UX Design Lead

Verdict: 🚫 Changes requested

The navy header direction is right and I'm glad to see it. The mint avatar at 8.5:1 is excellent. Focus rings on all…

marcel commented on pull request marcel/familienarchiv#165 2026-03-31 09:24:34 +02:00
feat(header): replace white header with brand-navy header per design spec

🔐 Nora "NullX" Steiner — Security Engineer

Verdict: Approved

This PR is a pure visual/CSS change — header background color, nav state styling, avatar colors, and a new auth page…

marcel commented on pull request marcel/familienarchiv#165 2026-03-31 09:24:19 +02:00
feat(header): replace white header with brand-navy header per design spec

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

Good that tests exist — four E2E scenarios covering the most critical regression risks. Some gaps to address.

###…

marcel commented on pull request marcel/familienarchiv#165 2026-03-31 09:23:51 +02:00
feat(header): replace white header with brand-navy header per design spec

🏛️ Markus Keller — Application Architect

Verdict: Approved

This is a contained, frontend-only change. No new layers, no new dependencies, no backend or database involvement.…

marcel commented on pull request marcel/familienarchiv#165 2026-03-31 09:23:36 +02:00
feat(header): replace white header with brand-navy header per design spec

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

AuthHeader.svelte duplicates LanguageSwitcher internals — violates DRY

`AuthHea…

marcel pushed to feat/issue-163-brand-navy-header at marcel/familienarchiv 2026-03-30 22:54:37 +02:00
281934529e fix(header): consistent icon styling, focus rings, and responsive breakpoints
marcel created pull request marcel/familienarchiv#165 2026-03-30 22:21:59 +02:00
feat(header): replace white header with brand-navy header per design spec