Minor cleanup — double request on mount in NotificationBell — @mkeller
Right now onMount fires two parallel requests on every page load:
onMount(() => {
fetchNotificati…
Why Propagation.REQUIRES_NEW matters here — @mkeller
Short version: it makes sure a broken email server can never delete a user's comment.
The problem without it
`CommentService.p…
Follow-up Review — @mkeller
All blockers resolved. All medium-priority items addressed. Ready to merge.
✅ Blockers — resolved
Migration collapse: V16 is now a single clean…
SSE Implementation Plan — replacing polling in NotificationBell
This is an optional follow-up to point 5 in the review. The polling works fine for now, but here is a complete, concrete plan…
Code Review — @mkeller
Solid feature work. The separation between notification, mention, and deep-link concerns is clean. Tests are present and meaningful. Two issues need to be addressed…
Review — Leonie Voss, UI/UX & Accessibility
Verdict: APPROVE WITH COMMENTS — all 3 BLOCKERs and all 6 MAJORs from the previous round are resolved. Three findings remain: one to fix…
Test Scope — @saraholt
This is a meaty feature. Three backend endpoint changes, three new frontend components, a conditional render mode, and non-trivial accessibility requirements. Here's…
Architectural Review — @mkeller
Overall the spec is well-structured and the two-mode conditional render on a single route is the right call. Several things need tightening before implementati…