• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🚨 BLOCKER — Fragile mixed injection + ReflectionTestUtils hack

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — Notification failure can silently roll back the parent comment

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — Several service method paths are untested

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — notifyMentions() call path has no test coverage

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — setTimeout(100) magic delay for deep-link scroll is flaky

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

ℹ️ INFO — Unused method: findByRecipientIdOrderByCreatedAtDesc

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🚨 BLOCKER — User enumeration endpoint has no permission check

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — @Transient field + FetchType.LAZY = potential LazyInitializationException at runtime

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:44 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — debounceTimer not cleared on component destroy

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

ℹ️ INFO — Unused method: findByRecipientIdOrderByCreatedAtDesc

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — Stored XSS vector in renderBody: mention display names are not escaped

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

QA Review — Sara Holt, Senior QA Engineer

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — relativeTime() returns hard-coded German strings

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — aria-label="ungelesen" is hard-coded German

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — <div role="button"> does not handle the Space key

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — XSS coverage missing in renderBody test suite

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🚨 BLOCKER — User enumeration endpoint has no permission check

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — @Transient field + FetchType.LAZY = potential LazyInitializationException at runtime

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🚨 BLOCKER — Architecture violation: direct repository access across domain boundary

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🚨 BLOCKER — Fragile mixed injection + ReflectionTestUtils hack