• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — notifyMentions() call path has no test coverage

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — Several service method paths are untested

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — Checkbox preference values are unreliable without JS

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — debounceTimer not cleared on component destroy

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — setTimeout(100) magic delay for deep-link scroll is flaky

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

🔵 MINOR — search_returnsAtMostTenResults does not assert the count

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — No @RequirePermission on notification controller

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — PATCH /api/notifications/{id}/read missing 401 test

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 23:35:12 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

⚠️ MAJOR — Notification failure can silently roll back the parent comment

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

Review — @mkeller

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

Bug: actorName is never set — will always be null in every API response.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

N+1: findById inside a loop.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

N+1: same issue as notifyReplyfindById in a loop.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

Avoid returning the Notification entity directly from the controller.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

Layering violation: CommentService directly injects AppUserRepository.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

Dead code: the List<Notification> overload is never called.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

Hardcoded German strings bypass Paraglide.

marcel commented on pull request marcel/familienarchiv#127 2026-03-27 22:11:40 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)

href="#" scrolls the page to the top on click.

marcel created pull request marcel/familienarchiv#127 2026-03-27 20:38:57 +01:00
feat: notifications, @mentions, and comment deep-links (#71 #72 #73)
2bc3b3fb6c feat(#73): deep-link to specific comments via ?commentId= query param
55cf1fb0a4 feat(#72): add @mention support in comment editor
e455efa670 feat(#71): add notification bell + preferences UI
1615a4ffa5 feat(backend): add V17 migration, @mention storage, MentionDTO, user search endpoint, and tests
bc62f3b0af feat(backend): trigger reply notifications from CommentService
Compare 7 commits »