marcel

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:45:32 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Elicit — Requirements Engineer & Business Analyst

Verdict: Approved with concerns

I reviewed against the stated intent of #666 (render imprecise/unknown dates honestly, never…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:45:09 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Only one CI workflow touch, and it's a sensible addition. No infra, no Compose, no secrets, no image-tag changes in this…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:44:57 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Leonie Voss — UX & Accessibility Lead

Verdict: Approved with concerns

This is the honest-date feature done right for our dual audience — the 67-year-old researcher gets a date she can…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:44:37 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

Strong test layering. One coverage gap on the new behavior, and a portability note on the CI guard — both minor, neither…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:44:24 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

The XSS surface here is meta_date_raw — untrusted, verbatim spreadsheet text. I traced every place it reaches…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:44:03 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Markus Keller — Application Architect

Verdict: Approved

Presentation-layer change with one well-placed pure helper. Boundaries and docs check out.

Boundaries

`DocumentTitleFormatte…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:43:50 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved

I re-reviewed the current diff afresh (round 3). The three latest fixes are genuinely resolved and clean.

Verified…

marcel opened issue marcel/familienarchiv#678

2026-05-27 12:39:57 +02:00

Friendly app-level validation for a RANGE with end-before-start

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:39:46 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Review-fix round 2 applied (Felix Brandt)

Pushed 3 atomic commits (38f065bc..4bc96c37) addressing the round-2 concerns. Backend DocumentServiceTest (159) + DocumentControllerTest (98) =…

marcel pushed to feature/666-date-rendering at marcel/familienarchiv

2026-05-27 12:39:12 +02:00

4bc96c3772 ci(dates): widen {@html} raw-date guard to cover the raw prop

f99673321c test(dates): pin edit-form precision field binding to DocumentUpdateDTO

728078f1e5 fix(dates): preserve stored date precision when edit omits it

Compare 3 commits »

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:29:30 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Elicit — Requirements Engineer / Business Analyst

Verdict: Approved with concerns

Reviewing against the stated need (Closes #666: "render imprecise/unknown dates honestly everywhere,…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:29:08 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Only one infra-relevant change: a new CI guard step in .gitea/workflows/ci.yml.

CI step review

The {@html}-on-raw-da…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:28:59 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Leonie Voss — UX / Accessibility Lead

Verdict: Approved

This is exactly the honest-data presentation I'd ask for, and the a11y craft is solid. Reviewed against WCAG AA, the senior-on-a-sm…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:28:40 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

I assessed the test pyramid by reading (full backend suite + browser-project tests are CI-only here, per the project rule).…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:28:26 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved with concerns

The threat model here is XSS via meta_date_raw — untrusted verbatim spreadsheet text rendered to…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:28:03 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Markus Keller — Application Architect

Verdict: Approved

Reviewed against module boundaries, the Java↔TS parity contract, and the doc-currency table.

Drift guard — does the TS/Java…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:27:51 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved with concerns

I re-read the current diff end-to-end (not the old comments). The prior-round fixes are genuine and clean.…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:24:58 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Review fixes applied (Felix Brandt)

Pushed 4 atomic commits (b1b8fa4b..38f065bc) addressing every concern. Lint clean, formatter spec 29 pass (node), Java DocumentTitleFormatterTest…

marcel pushed to feature/666-date-rendering at marcel/familienarchiv

2026-05-27 12:24:39 +02:00

38f065bc60 docs(dates): record list-rows-omit-raw-provenance decision near render

6cc622b4db refactor(dates): type DocumentMultiSelect options without double-cast

4169373693 fix(dates): meet 48px touch target on RANGE end-date input

8ed5b1e9e3 fix(dates): make DAY precision locale-aware in formatDocumentDate

Compare 4 commits »

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:14:07 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Elicit — Requirements Engineer & Business Analyst

Verdict: warning Approved with concerns

Reviewing this as the requirements/acceptance-criteria lens for #666 ("render imprecise/unknown…