marcel

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:14:07 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Elicit — Requirements Engineer & Business Analyst

Verdict: warning Approved with concerns

Reviewing this as the requirements/acceptance-criteria lens for #666 ("render imprecise/unknown…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:13:43 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Tobias Wendt (@tobiwendt) — DevOps & Platform Engineer

Verdict: white_check_mark Approved

Only one infra-facing change in this PR: a new CI step in .gitea/workflows/ci.yml. I reviewed…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:13:31 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Sara Holt (@saraholt) — QA Engineer & Test Strategist

Verdict: warning Approved with concerns

Test strategy here is genuinely good: the drift-guard fixture is the kind of cross-stack…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:13:14 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Markus Keller (@mkeller) — Application Architect

Verdict: white_check_mark Approved

This is presentation logic done with the right boundaries. No schema change, no migration, no new enum…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:12:52 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Leonie Voss (@leonievoss) — UX & Accessibility Lead

Verdict: warning Approved with concerns

The honest-date direction is exactly right for our dual audience — a 67-year-old researcher…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:12:38 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Nora Steiner (@nullx) — Application Security Engineer

Verdict: white_check_mark Approved

This PR introduces one new untrusted-data sink — meta_date_raw, verbatim spreadsheet text —…

marcel commented on pull request marcel/familienarchiv#677

2026-05-27 12:12:24 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

Felix Brandt (@felixbrandt) — Senior Fullstack Developer

Verdict: warning Approved with concerns

Clean, well-factored work. The formatter is decomposed into small intent-revealing…

marcel created pull request marcel/familienarchiv#677

2026-05-27 12:09:46 +02:00

feat(dates): honest precision-aware date rendering (Phase 4, #666)

marcel created branch feature/666-date-rendering in marcel/familienarchiv

2026-05-27 12:09:25 +02:00

marcel pushed to feature/666-date-rendering at marcel/familienarchiv

2026-05-27 12:09:25 +02:00

b1b8fa4bed docs: note honest date formatter, title formatter and drift fixture

2bd5c82826 ci: guard against rendering meta_date_raw via {@html}

7245571ea8 feat(document): edit document date precision, end and raw

b56b9dfa74 feat(frontend): render honest precision dates in detail, list and search

6538c9e59a feat(frontend): add accessible DocumentDate render component

Compare 8 commits »

marcel deleted branch feature/669-modular-importer from marcel/familienarchiv

2026-05-27 11:34:33 +02:00

marcel closed issue marcel/familienarchiv#669

2026-05-27 11:34:31 +02:00

As the archive owner I want the importer rebuilt as modular loaders over the normalizer's canonical exports, so dates/people/tags import correctly and re-runs are idempotent

marcel merged pull request marcel/familienarchiv#674

2026-05-27 11:34:30 +02:00

feat(importing): rebuild importer as modular canonical loaders (Phase 3, #669)

marcel pushed to docs/import-migration at marcel/familienarchiv

2026-05-27 11:34:30 +02:00

e4a154406e docs: record owner decisions on re-import authority and path-escape

151d6aa03f test(importing): clean up committed rows after CanonicalImportIntegrationTest

fc53e777d5 docs(deployment): pin exact normalizer entrypoint command

4fa2b83c0d docs(adr-025): record document-authoritative collections and non-transactional orchestrator

e9ddaed76a refactor(person): unify fill-blank under preferHuman and clarify rowId trap

Compare 19 commits »

marcel opened issue marcel/familienarchiv#676

2026-05-27 11:21:19 +02:00

Importer file lookup walks the whole import dir per row (O(rows×tree))

marcel opened issue marcel/familienarchiv#675

2026-05-27 11:21:12 +02:00

Canonical importer can leave orphaned S3 objects when a document's file changes

marcel pushed to feature/669-modular-importer at marcel/familienarchiv

2026-05-27 11:20:42 +02:00

e4a154406e docs: record owner decisions on re-import authority and path-escape

marcel commented on pull request marcel/familienarchiv#674

2026-05-27 11:14:22 +02:00

feat(importing): rebuild importer as modular canonical loaders (Phase 3, #669)

Elicit — Requirements Engineer & Business Analyst

Verdict: Approved with concerns

I review requirements coverage and traceability, not code. This PR closes #669 (Phase 3 of "Handling the…

marcel commented on pull request marcel/familienarchiv#674

2026-05-27 11:14:02 +02:00

feat(importing): rebuild importer as modular canonical loaders (Phase 3, #669)

Leonie Voss — UI/UX Design Lead

Verdict: Approved

The frontend footprint is small — a follow-up to surface the two new backend states in the admin Import Status Card — and it's handled…

marcel commented on pull request marcel/familienarchiv#674

2026-05-27 11:13:51 +02:00

feat(importing): rebuild importer as modular canonical loaders (Phase 3, #669)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved with concerns

Backend-only change, no compose/CI/Dockerfile edits, so my surface is config, the runbook, and operational…