marcel

marcel commented on pull request marcel/familienarchiv#673

2026-05-27 09:26:25 +02:00

feat(schema): one migration + domain model for import/precision/identity (Phase 2, #671)

Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved with one concern

No Compose, CI workflow, image tags, secrets, ports, or volumes touched — so most of my checklist is N/A.…

marcel commented on pull request marcel/familienarchiv#673

2026-05-27 09:26:13 +02:00

feat(schema): one migration + domain model for import/precision/identity (Phase 2, #671)

Nora Steiner ("NullX") — Application Security Engineer

Verdict: ✅ Approved

This is a schema-and-DTO PR with no auth, endpoint, query-construction, or input-handling changes, so the…

marcel commented on pull request marcel/familienarchiv#673

2026-05-27 09:25:55 +02:00

feat(schema): one migration + domain model for import/precision/identity (Phase 2, #671)

Sara Holt — Senior QA Engineer

Verdict: ✅ Approved with concerns

This is a model migration-test PR. The V69 coverage in MigrationIntegrationTest is thorough and runs against real…

marcel commented on pull request marcel/familienarchiv#673

2026-05-27 09:25:43 +02:00

feat(schema): one migration + domain model for import/precision/identity (Phase 2, #671)

Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

TDD evidence is strong and the Java is clean. The "silent-false trap" tests in PersonRepositoryTest…

marcel commented on pull request marcel/familienarchiv#673

2026-05-27 09:25:31 +02:00

feat(schema): one migration + domain model for import/precision/identity (Phase 2, #671)

Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

The core architectural decisions here are exactly right, and I want to name what is done well before the…

marcel created pull request marcel/familienarchiv#673

2026-05-27 09:23:49 +02:00

feat(schema): one migration + domain model for import/precision/identity (Phase 2, #671)

marcel created branch feature/671-schema-foundation in marcel/familienarchiv

2026-05-27 09:23:28 +02:00

marcel pushed to feature/671-schema-foundation at marcel/familienarchiv

2026-05-27 09:23:28 +02:00

d959cb54f1 docs: record V69 schema foundation (DB diagrams, glossary, ADR-025)

6f5ca47543 feat(frontend): regenerate API types for precision/attribution/identity fields

c27c83f58c feat(document): add date precision/attribution fields to document DTOs

0f07a95bfe feat(person): project provisional through PersonSummaryDTO

662927f928 feat(schema): add V69 migration + DatePrecision enum + entity fields

Compare 5 commits »

marcel commented on issue marcel/familienarchiv#671

2026-05-27 09:22:48 +02:00

As the archive owner I want one Flyway migration and domain model carrying all import/precision/attribution/identity fields so downstream phases compile against a single, collision-free schema

Implemented on `feature/671-schema-foundation` (branched from `docs/import-migration`)

Schema foundation complete via red→green TDD. Five atomic commits:

662927f9 feat(schema):…

marcel deleted branch feature/670-normalizer-canonical-exports from marcel/familienarchiv

2026-05-27 08:58:50 +02:00

marcel pushed to docs/import-migration at marcel/familienarchiv

2026-05-27 08:58:48 +02:00

0398ebea2c docs(import): document file, date_end, personId contract fields

99d8229858 test(normalizer): reconcile tree personId with persons.xlsx 1:1

fee3c7e27d feat(normalizer): flag half-resolved RANGE for review

fa3f4167e9 refactor(normalizer): give date matchers a uniform MatchResult shape

a2b77e5bfa fix(normalizer): fail-closed on person_id zip length divergence

Compare 9 commits »

marcel closed issue marcel/familienarchiv#670

2026-05-27 08:58:47 +02:00

As the archive owner I want the normalizer's canonical exports to carry every field the importer needs (file, date-range end, person ids in the tree) so the loaders have a complete, joinable contract

marcel merged pull request marcel/familienarchiv#672

2026-05-27 08:58:47 +02:00

feat(normalizer): complete canonical exports for the importer (Phase 1, #670)