marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:07:57 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

📋 Elicit — Requirements Engineer (Round 2)

Verdict: ✅ Approved

All requirements from issue #662 are implemented. No gaps.

Full requirements trace

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:07:46 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🛠️ Tobias Wendt — DevOps & Platform Engineer (Round 2)

Verdict: ✅ Approved

Pure frontend feature, no infrastructure changes. LGTM.

Checked: Docker Compose (no changes), CI pipeline…

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:07:43 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

👨‍💻 Felix Brandt — Senior Fullstack Developer (Round 2)

Verdict: ✅ Approved

TDD, Svelte 5 runes, keyed iteration, component sizing — all correct. No blockers remaining.

Svelte 5…

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:07:31 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🏛️ Markus Keller — Senior Application Architect (Round 2)

Verdict: ✅ Approved

Architecture is clean throughout. No blockers.

Module boundaries

hasAnyDocuments() lives in…

d1d0acf029 fix(themen): add focus rings to child and 'weitere' links (WCAG 2.4.7)
marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:05:00 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: 🚫 Changes requested

The card and color bar design is excellent. Touch targets meet requirements. The root tag links have…

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:04:42 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ✅ Approved

Test pyramid is well-covered. The right tests are at the right layers.

Test coverage by layer

**Unit (Vitest…

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:04:25 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved with concerns

No exploitable vulnerabilities. One CSS injection smell worth documenting.

What I…

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:04:12 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

All acceptance criteria from issue #662 are implemented and verifiable.

Requirements coverage

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:04:01 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Pure frontend feature. No infrastructure changes. Nothing to flag.

What I checked

  • Docker Compose — No new…
marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:03:55 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

TDD evidence is present, Svelte 5 runes are used correctly, and the component structure is clean. One…

marcel commented on pull request marcel/familienarchiv#664 2026-05-25 18:03:39 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

🏛️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

Reviewed module boundaries, documentation currency, and SSR architecture. The implementation is clean.

What I…

marcel created pull request marcel/familienarchiv#664 2026-05-25 17:57:32 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen
fc53c69aaf docs(architecture): add /themen route and ThemenWidget to C4 frontend diagram
9084c8dd32 feat(themen): /themen dedicated page with root-tag cards and child rows
9d8e9c4531 feat(dashboard): add ThemenWidget to reader and editor sidebar layouts
1d032f52d9 feat(themen): ThemenWidget component with compact prop + browser tests
41754fc052 feat(dashboard): load tag tree for both reader and editor dashboard
Compare 8 commits »
marcel commented on issue marcel/familienarchiv#662 2026-05-25 17:56:55 +02:00
feat: Themen-Inhaltsverzeichnis — Dashboard-Widget + dedizierte Seite /themen

✅ Implementation complete — branch worktree-feat+issue-662-themen-inhaltsverzeichnis

What was built

8 commits, pure frontend — no backend changes needed.

marcel deleted branch worktree-fix+reader-dashboard-doc-undefined from marcel/familienarchiv 2026-05-25 17:54:45 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-25 17:54:43 +02:00
2e0eb40aec test(debounce): fix flaky onExit-cancels-debounce test
d9e01ef1ff fix(review): regenerate api.ts and fix spec type
2e0f85c360 fix(review): address reviewer concerns from PR #661
a1035171c2 fix(reader-dashboard): recentDocs items were always undefined for READ_ALL users
Compare 4 commits »
marcel merged pull request marcel/familienarchiv#661 2026-05-25 17:54:42 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined
2e0eb40aec test(debounce): fix flaky onExit-cancels-debounce test