marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
d9e01ef1ff fix(review): regenerate api.ts and fix spec type
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-25 17:00:56 +02:00
5efe3b8a7c feat(normalizer): parse Spanish month names + Month DD-YYYY hyphen form
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-25 16:53:23 +02:00
0f1f9055c3 docs(normalizer): add overrides/ README with structure + examples
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-25 16:46:31 +02:00
8cac63e938 feat(normalizer): drop unmatched-names.csv; unresolved-names is the names report
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-25 16:01:37 +02:00
97db718f81 docs(import): add unresolved-names plan + worklog entry
06127724de docs(normalizer): document unresolved-names.csv review report
7c017eca2a test(normalizer): assert unresolved stat key + drop duplicate assertion
97ab9e38df feat(normalizer): unresolved-names report + fix ambiguous-pair over-flagging
f10b80a03f feat(normalizer): build_given_names from register + supplement
Compare 7 commits »
marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:51:14 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

📋 Elicit — Requirements Engineer & Business Analyst

Verdict: ✅ Approved

The root cause is clearly documented in the PR description. The fix is tightly scoped. No new user-visible…

marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:51:02 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure, CI, or Docker Compose changes in this PR. The fix is entirely application-layer. LGTM from a…

marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:50:54 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

🎨 Leonie Voss — Senior UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

The fix resolves a crash that prevented READ_ALL users from using the homepage at all…

marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:50:39 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

Reviewed the full diff with an adversarial eye. No security concerns in this PR.

What I checked

**Data…

marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:50:29 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

🏛️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

The fix is architecturally correct. DocumentListItem is the right DTO for list endpoints — it's…

marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:50:16 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

Good regression coverage for the core bug. The server-side test in page.server.spec.ts clearly documents the…

marcel commented on pull request marcel/familienarchiv#661 2026-05-25 15:50:02 +02:00
fix(reader-dashboard): 500 crash for READ_ALL users — recentDocs always undefined

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

The core bug fix is clean and correct — the type alias swap in +page.server.ts is exactly the…

2e0f85c360 fix(review): address reviewer concerns from PR #661
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-25 15:07:54 +02:00
5ff0c25e10 chore: drop stray reader-dashboard test from this branch
marcel commented on pull request marcel/familienarchiv#663 2026-05-25 15:05:43 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🎨 Leonie Voss — UX & Accessibility

Verdict: ✅ Approved (mostly out of scope — LGTM)

There is no UI in this PR. No .svelte component, no route, no page, no rendered surface — so…

marcel commented on pull request marcel/familienarchiv#663 2026-05-25 15:05:26 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

I ran the suite (.venv/bin/python -m pytest tests/ -q) → 57 passed in 0.14s. For a pure-logic transform tool,…

marcel commented on pull request marcel/familienarchiv#663 2026-05-25 15:05:07 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

Adversarial pass, scoped honestly to what this thing actually is: an offline, local CLI that reads two…

marcel commented on pull request marcel/familienarchiv#663 2026-05-25 15:04:48 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

📋 "Elicit" — Requirements Engineer

Verdict: ✅ Approved

I traced the implementation back against the spec I authored (02-normalization-spec.md). This is a Brownfield artifact review:…

marcel commented on pull request marcel/familienarchiv#663 2026-05-25 15:04:28 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Mostly out of my lane — there's no Compose service, no CI job, no Caddy rule, no port, no secret, no infrastructure…

marcel commented on pull request marcel/familienarchiv#663 2026-05-25 15:04:12 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

I went through this Python the way I'd review any service: TDD evidence, naming, function size, guard…