marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat(#50): document & annotation comments #57

Merged
marcel merged 10 commits from feature/50-document-comments into main 2026-03-24 12:57:53 +01:00
Conversation 0 Commits 10 Files Changed 19 +1459 -15
marcel commented 2026-03-24 11:42:04 +01:00
Owner
Copy Link

Closes #50

Summary

  • Backend: Flyway migration, DocumentComment entity, CommentRepository, CommentService (with flat reply-to-root resolution, authorship checks, admin override), CommentController (8 endpoints for general + annotation comments), COMMENT_NOT_FOUND error code
  • Frontend: CommentThread component (post/reply/edit/delete, relative timestamps, „bearbeitet" label), AnnotationCommentPanel (floating panel on desktop, bottom-sheet modal on mobile), annotation comment count pill (bottom-right, bold, drop shadow), auto-open panel on annotation creation, confirm dialog before deleting annotation with comments, hover effect on annotation overlays, „Diskussion" section in document detail sidebar
  • i18n: new keys in de/en/es for all comment UI strings

Test plan

  • All 156 backend unit tests pass (./mvnw test)
  • Post a general comment on a document → appears in „Diskussion" sidebar
  • Edit a comment → „bearbeitet" label appears with timestamp
  • Reply → Reply button moves to the new last comment
  • Draw a new annotation → comment panel opens automatically
  • Click a different annotation → panel switches to the correct one
  • Comment count pill shows correct count, updates after posting/deleting
  • Delete annotation with comments → confirm dialog appears; cancel aborts
  • Hover over annotation → opacity and border highlight appear
  • Mobile: annotation comment panel renders as bottom-sheet modal

🤖 Generated with Claude Code

Closes #50 ## Summary - **Backend**: Flyway migration, `DocumentComment` entity, `CommentRepository`, `CommentService` (with flat reply-to-root resolution, authorship checks, admin override), `CommentController` (8 endpoints for general + annotation comments), `COMMENT_NOT_FOUND` error code - **Frontend**: `CommentThread` component (post/reply/edit/delete, relative timestamps, „bearbeitet" label), `AnnotationCommentPanel` (floating panel on desktop, bottom-sheet modal on mobile), annotation comment count pill (bottom-right, bold, drop shadow), auto-open panel on annotation creation, confirm dialog before deleting annotation with comments, hover effect on annotation overlays, „Diskussion" section in document detail sidebar - **i18n**: new keys in de/en/es for all comment UI strings ## Test plan - [ ] All 156 backend unit tests pass (`./mvnw test`) - [ ] Post a general comment on a document → appears in „Diskussion" sidebar - [ ] Edit a comment → „bearbeitet" label appears with timestamp - [ ] Reply → Reply button moves to the new last comment - [ ] Draw a new annotation → comment panel opens automatically - [ ] Click a different annotation → panel switches to the correct one - [ ] Comment count pill shows correct count, updates after posting/deleting - [ ] Delete annotation with comments → confirm dialog appears; cancel aborts - [ ] Hover over annotation → opacity and border highlight appear - [ ] Mobile: annotation comment panel renders as bottom-sheet modal 🤖 Generated with [Claude Code](https://claude.com/claude-code)
marcel added 9 commits 2026-03-24 11:42:05 +01:00
test(comments): add failing CommentServiceTest and V12 migration (red) 83e5a1fde5 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat(comments): add DocumentComment entity, CommentRepository, and CommentService (green) 48040dc7e4 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
test(comments): add failing CommentControllerTest (red) ee49bac2ef 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat(comments): add CommentController and CreateCommentDTO (green) 3e5d296b09 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat(comments): add CommentThread, annotation panel, Diskussion section, and i18n keys 1070e6e9ec 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix(comments): open panel on annotation creation and enlarge comment count pill 646674b06a 
- Auto-open AnnotationCommentPanel immediately after drawing a new annotation
- Move comment count pill to bottom-right corner (was centered at bottom)
- Increase pill size: font 11px bold, padding 2px 6px, min-width 20px, drop shadow

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat(comments): warn before deleting annotation with comments aaa9286612 
Show a native confirm() dialog when the annotation has ≥1 comment,
listing the count so the user knows what will be lost.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat(annotations): add hover effect — increased opacity and inset border on hover af57b4e530 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix(comments): remount AnnotationCommentPanel when switching annotations
Some checks failed
CI / Unit & Component Tests (push) Failing after 2m13s
Details
CI / Backend Unit Tests (push) Successful in 2m23s
Details
CI / E2E Tests (push) Failing after 24m41s
Details
CI / Unit & Component Tests (pull_request) Failing after 2m8s
Details
CI / Backend Unit Tests (pull_request) Successful in 2m8s
Details
CI / E2E Tests (pull_request) Has been cancelled
Details
fd03e56c85 
Wrap the panel in {#key activeAnnotationId} so Svelte destroys and
recreates it on every annotation change, triggering onMount and
loading the correct comments.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel added 1 commit 2026-03-24 12:28:08 +01:00
fix(e2e): fix annotation delete test and harden comments fetch
Some checks failed
CI / E2E Tests (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (push) Successful in 2m30s
Details
CI / Backend Unit Tests (push) Successful in 2m15s
Details
CI / E2E Tests (push) Successful in 22m47s
Details
CI / Unit & Component Tests (pull_request) Has been cancelled
Details
CI / Backend Unit Tests (pull_request) Has been cancelled
Details
34c66f80fc 
- Add aria-label="Kommentare anzeigen" to annotation container div so
  getByRole('button', { name: /annotation löschen/i }) no longer
  matches the container (its name was previously inherited from the
  child delete button, causing the test to click the wrong element)
- Wrap the server-side comments fetch in a .catch and try/catch so a
  network error or non-JSON response never crashes the document load

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit 34c66f80fc into main 2026-03-24 12:57:53 +01:00
marcel deleted branch feature/50-document-comments 2026-03-24 12:57:56 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#57
Delete Branch "feature/50-document-comments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?