marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:32:32 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

📋 Elicit — Requirements Engineer

Observations

  • The problem statement is concise and evidence-backed (run #1636 with 17-minute silent hang, run #1637 with 14-minute silent Chromium…
marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:32:22 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

🎨 Leonie Voss — UX Designer & Accessibility Strategist

This is a CI infrastructure change with no user-facing component. Checked: the proposed changes affect only `backend/src/test/resources/…

marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:32:19 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

🧪 Sara Holt — Senior QA Engineer

Observations

  • The logging fix directly improves test observability. Failures invisible in a truncated log are a false-negative factory — this is the…
marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:32:06 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

  • Surefire XML reports as CI artifacts: These contain test class names, method names, and exception stack traces…
marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:32:02 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

🔧 Tobias Wendt — DevOps & Platform Engineer

Observations

  • All four changes are the right call. This addresses confirmed, observed CI pain (runs #1636 and #1637) with minimal footprint…
marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:31:50 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • backend/src/test/resources/application.properties does not exist yet — this is a new file. No merging, no conflicts. -…
marcel commented on issue marcel/familienarchiv#570 2026-05-14 13:31:38 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs

🏗️ Markus Keller — Senior Application Architect

Observations

  • All four changes are targeted and non-invasive. No domain boundaries are crossed, no new infrastructure dependencies…
marcel commented on pull request marcel/familienarchiv#569 2026-05-14 13:25:26 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

Review concerns addressed — commits a2e925b7 + 120866bf

Backend (a2e925b7)

marcel pushed to feat/issue-533-mass-import-ux at marcel/familienarchiv 2026-05-14 13:25:03 +02:00
120866bf76 fix(admin/system): address review concerns in ImportStatusCard
a2e925b780 fix(import): exclude message field from API response; add auth boundary tests
Compare 2 commits »
marcel opened issue marcel/familienarchiv#570 2026-05-14 13:24:37 +02:00
ci: make backend test failures visible and prevent silent Playwright hangs
marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:53:14 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

What works well

✅ Spinner has role="status" + `aria-label={m.admin_system_import_status…

marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:52:57 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

Backend — MassImportServiceTest

✅ getStatus_hasStatusCode_IMPORT_IDLE_byDefault() — clear behavioral name,…

marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:52:41 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

Concern — Information Disclosure via message field (CWE-209, Low-Medium)

File:…

marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:52:27 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

📋 Elicit — Senior Requirements Engineer

Verdict: ⚠️ Approved with concerns

Requirements coverage from issue #533

marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:52:14 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No CI/CD workflow, Docker Compose, or infrastructure changes in this PR. Nothing to flag from the platform side.

###…

marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:52:09 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

None.

Suggestions

1. Business logic in template markup (`ImportStatusCard.svelt…

marcel commented on pull request marcel/familienarchiv#569 2026-05-14 12:51:56 +02:00
ui(admin/system): improve mass-import card (loading state, i18n, font size)

🏛️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

Documentation trigger check

marcel pushed to feat/issue-533-mass-import-ux at marcel/familienarchiv 2026-05-14 12:38:07 +02:00
3b2fae8188 feat(admin/system): extract ImportStatusCard — spinner, text-base count, statusCode i18n
8d17a2fcb3 feat(i18n): add structured import failure keys; split DONE display
70281d2c4b feat(import): add structured statusCode to ImportStatus — replaces raw German message
5646e739c2 fix(ci): run svelte-kit sync before lint to fix cache-hit tsconfig miss
Compare 4 commits »
marcel commented on pull request marcel/familienarchiv#567 2026-05-14 12:12:22 +02:00
fix(admin): clear unsaved-changes guard before redirect on groups/new and users/new

Review concerns addressed

Concern raised by @felix and @sara (non-blocking): SubmitFn type defined inline 4 times — twice in each spec file.

Fix (commit 2ca8428b): Extracted…

2ca8428be4 refactor(test): hoist SubmitFn to file-level type in unsaved-guard specs