marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#567 2026-05-14 12:02:07 +02:00
fix(admin): clear unsaved-changes guard before redirect on groups/new and users/new

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Clean, focused fix. The root cause diagnosis is correct — beforeNavigate was cancelling SvelteKit's internal…

marcel commented on issue marcel/familienarchiv#566 2026-05-14 12:00:23 +02:00
feat(admin): assign groups when creating an invite link

Form should still work, but we should show a warning why the groups are missing A. the group service should probably check if there are pending invites with the group it wants to delete and throw…

marcel created pull request marcel/familienarchiv#567 2026-05-14 11:59:08 +02:00
fix(admin): clear unsaved-changes guard before redirect on groups/new and users/new
07ae9b61fb fix(test): allow extra result properties in enhance callback type
1482cb7a06 fix(admin): clear unsaved-changes guard before redirect on users/new
9d77685721 fix(admin): clear unsaved-changes guard before redirect on groups/new
Compare 3 commits »
marcel created branch feat/issue-527-unsaved-warning-new-pages in marcel/familienarchiv 2026-05-14 11:58:52 +02:00
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:54:52 +02:00
feat(admin): assign groups when creating an invite link

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Requirements / Business Logic

  • Behavior when groups API fails at form load time —…
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:54:24 +02:00
feat(admin): assign groups when creating an invite link

📋 Elicit — Requirements Engineer

Observations

  • Issue quality is high. Clear user story, explicit current/desired behavior, Gherkin acceptance criteria, concrete implementation notes…
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:54:09 +02:00
feat(admin): assign groups when creating an invite link

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • Zero infrastructure impact. No new Docker services, no environment variables, no compose changes, no CI modifications. The…
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:53:59 +02:00
feat(admin): assign groups when creating an invite link

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

  • Reusing UserGroupsSection.svelte is the right call. Consistency across /admin/users/new and /admin/invites…
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:53:44 +02:00
feat(admin): assign groups when creating an invite link

🧪 Sara Holt — QA Engineer

Observations

  • The issue has well-written Gherkin acceptance criteria covering: form renders groups, invite with group → user has group on registration, invite…
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:53:31 +02:00
feat(admin): assign groups when creating an invite link

🔐 Nora "NullX" Steiner — Application Security Engineer

Observations

  • Group UUID validation is server-side and correct: InviteService.createInvite() calls `userService.findGroupsByI…
marcel closed issue marcel/familienarchiv#531 2026-05-14 11:53:22 +02:00
ci(nightly): post-deploy smoke test for /api/admin/import-status
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:53:16 +02:00
feat(admin): assign groups when creating an invite link

🏗️ Markus Keller — Application Architect

Observations

  • No schema changes, no migrations, no new packages. InviteToken already carries a Set<UUID> groupIds via `@ElementCollection…
marcel commented on issue marcel/familienarchiv#566 2026-05-14 11:53:03 +02:00
feat(admin): assign groups when creating an invite link

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • Backend is fully implemented (CreateInviteRequest.groupIds, InviteService.redeemInvite() → userService.createUser()…
marcel commented on issue marcel/familienarchiv#533 2026-05-14 11:45:48 +02:00
ui(admin/system): improve mass-import status card (loading state, i18n, font size)

Failure mode: explore possible Enums, so we get good errors we can act upon UX: show a counter

marcel opened issue marcel/familienarchiv#566 2026-05-14 11:41:11 +02:00
feat(admin): assign groups when creating an invite link
marcel commented on issue marcel/familienarchiv#533 2026-05-14 11:36:42 +02:00
ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Backend Design

  • Failure mode enumeration. The issue lists `IMPORT_FAILED_NO_SPREADSH…
marcel commented on issue marcel/familienarchiv#533 2026-05-14 11:36:27 +02:00
ui(admin/system): improve mass-import status card (loading state, i18n, font size)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • No infrastructure changes required. This is a pure service-layer + frontend change. No new Docker services, no config…
marcel commented on issue marcel/familienarchiv#533 2026-05-14 11:36:12 +02:00
ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Since this issue originates from my review comment on #526, let me be specific about what I found and what the fixes should look…

marcel commented on issue marcel/familienarchiv#533 2026-05-14 11:35:50 +02:00
ui(admin/system): improve mass-import status card (loading state, i18n, font size)

📋 Elicit — Requirements Engineer

Observations

  • The issue is well above the Definition of Ready bar. User story explicit, three discrete fixes scoped and independently testable, GWT…