marcel

marcel commented on issue marcel/familienarchiv#566

2026-05-14 11:53:03 +02:00

feat(admin): assign groups when creating an invite link

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

Backend is fully implemented (CreateInviteRequest.groupIds, InviteService.redeemInvite() → userService.createUser()…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:45:48 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

Failure mode: explore possible Enums, so we get good errors we can act upon UX: show a counter

marcel opened issue marcel/familienarchiv#566

2026-05-14 11:41:11 +02:00

feat(admin): assign groups when creating an invite link

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:36:42 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Backend Design

Failure mode enumeration. The issue lists `IMPORT_FAILED_NO_SPREADSH…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:36:27 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

No infrastructure changes required. This is a pure service-layer + frontend change. No new Docker services, no config…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:36:12 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Since this issue originates from my review comment on #526, let me be specific about what I found and what the fixes should look…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:35:50 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

📋 Elicit — Requirements Engineer

Observations

The issue is well above the Definition of Ready bar. User story explicit, three discrete fixes scoped and independently testable, GWT…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:35:30 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🧪 Sara Holt — QA Engineer & Test Automation Specialist

Observations

The checklist is solid. vitest-browser for the spinner, axe-playwright for a11y, visual regression at three…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:35:09 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

Both admin import endpoints are correctly secured. AdminController.java carries a class-level `@RequirePermiss…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:34:49 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

🏛️ Markus Keller — Application Architect

Observations

Domain boundary violation in the current design. The message: String field on ImportStatus (MassImportService.java:55)…

marcel commented on issue marcel/familienarchiv#533

2026-05-14 11:34:32 +02:00

ui(admin/system): improve mass-import status card (loading state, i18n, font size)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

The i18n is 75% done already. messages/{de,en,es}.json already has admin_system_import_status_idle, `admin_system_im…

marcel commented on issue marcel/familienarchiv#538

2026-05-14 11:30:51 +02:00

bug(test): flaky browser-mode test — admin edit-user unsaved-changes guard

🎨 Leonie Voss — UX Designer & Accessibility Strategist

No UX or accessibility concerns from this angle.

This is a pure test infrastructure fix. The "discard changes" flow itself — showing…

marcel commented on issue marcel/familienarchiv#538

2026-05-14 11:30:48 +02:00

bug(test): flaky browser-mode test — admin edit-user unsaved-changes guard

🔐 Nora "NullX" Steiner — Application Security Engineer

No security concerns from this angle.

The affected test exercises the unsaved-changes guard — a pure UX flow that calls goto() with…

marcel commented on issue marcel/familienarchiv#538

2026-05-14 11:30:43 +02:00

bug(test): flaky browser-mode test — admin edit-user unsaved-changes guard

🏗️ Markus Keller — Application Architect

Observations

No architectural concerns. This issue is entirely within the test layer — a single test assertion is in the wrong execution…

marcel commented on issue marcel/familienarchiv#538

2026-05-14 11:30:36 +02:00

bug(test): flaky browser-mode test — admin edit-user unsaved-changes guard

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

Flaky tests are CI debt. A test that passes 80–90% of the time trains the team to re-run pipelines rather than investigate…

marcel commented on issue marcel/familienarchiv#538

2026-05-14 11:30:28 +02:00

bug(test): flaky browser-mode test — admin edit-user unsaved-changes guard

🧪 Sara Holt — QA Engineer & Test Automation Specialist

Observations

This is the classic "await click, sync assert" anti-pattern in browser-mode testing. The problem is structural:…

marcel commented on issue marcel/familienarchiv#538

2026-05-14 11:30:18 +02:00

bug(test): flaky browser-mode test — admin edit-user unsaved-changes guard

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

Root cause confirmed. Line 256 (await page.getByRole('button', { name: /verwerfen/i }).click()) awaits the browser's…

marcel deleted branch ci/deduplicate-push-trigger from marcel/familienarchiv

2026-05-14 11:12:27 +02:00

marcel pushed to main at marcel/familienarchiv

2026-05-14 11:12:25 +02:00

bbbdf8cd09 ci: restrict push trigger to main — eliminate duplicate runs on feature branches

marcel merged pull request marcel/familienarchiv#565

2026-05-14 11:12:25 +02:00

ci: restrict push trigger to main — eliminate duplicate CI runs