• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#595 2026-05-15 11:34:53 +02:00
feat(backend): Sentry/GlitchTip error reporting + observability deploy wiring

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

Concern: Observability stack not covered by smoke tests

The smoke tests in both nightly.yml and release.yml

marcel commented on pull request marcel/familienarchiv#595 2026-05-15 11:34:45 +02:00
feat(backend): Sentry/GlitchTip error reporting + observability deploy wiring

🔐 Nora Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

Concern: GlitchTip has no security_headers — verify HSTS is set by the service itself

`infra/ca…

marcel commented on pull request marcel/familienarchiv#595 2026-05-15 11:34:40 +02:00
feat(backend): Sentry/GlitchTip error reporting + observability deploy wiring

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

This PR touches only CI workflows, Docker Compose configuration, and a Caddyfile — no application code, no frontend,…

marcel commented on pull request marcel/familienarchiv#595 2026-05-15 11:34:37 +02:00
feat(backend): Sentry/GlitchTip error reporting + observability deploy wiring

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

What's correct here

  • name: archiv-net in docker-compose.prod.yml is the essential fix. Without it, `docker-comp…
marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv 2026-05-15 11:27:38 +02:00
4c8a23ff14 devops(caddy): add Grafana and GlitchTip vhosts
marcel created pull request marcel/familienarchiv#595 2026-05-15 11:23:30 +02:00
feat(backend): Sentry/GlitchTip error reporting + observability deploy wiring
marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv 2026-05-15 11:23:10 +02:00
d7d225af77 devops(observability): wire observability stack into nightly and release deploys
marcel created branch feat/issue-580-sentry-backend in marcel/familienarchiv 2026-05-15 11:23:09 +02:00
marcel deleted branch feat/issue-580-sentry-backend from marcel/familienarchiv 2026-05-15 11:08:51 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-15 11:08:50 +02:00
4358997482 perf(test): replace DirtiesContext(AFTER_EACH_TEST_METHOD) with @Transactional
7c2e75facc fix(backend): switch to sentry-spring-boot-4:8.41.0 for Spring Boot 4/SF7 compatibility
7b05b9d5a0 test(context): assert SentryAutoConfiguration is excluded from Spring context
20edc0474c test(exception): verify handleGeneric captures exception in Sentry and returns 500
fa191b5c05 test(config): unit-test SentryConfig blank-DSN no-op and non-blank init paths
Compare 8 commits »
marcel closed issue marcel/familienarchiv#580 2026-05-15 11:08:48 +02:00
feat(backend): integrate sentry-spring-boot-starter for exception reporting to GlitchTip
marcel merged pull request marcel/familienarchiv#592 2026-05-15 11:08:48 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta
marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv 2026-05-15 10:34:00 +02:00
4358997482 perf(test): replace DirtiesContext(AFTER_EACH_TEST_METHOD) with @Transactional
marcel commented on pull request marcel/familienarchiv#592 2026-05-15 09:52:43 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

Reviewer concerns addressed — updated push 7c2e75fa

Felix / Sara blockers: test coverage for Sentry wiring

Added in commits fa191b5c and 20edc047:

  • GlobalExceptionHandlerTest —…
marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv 2026-05-15 09:52:28 +02:00
7c2e75facc fix(backend): switch to sentry-spring-boot-4:8.41.0 for Spring Boot 4/SF7 compatibility
7b05b9d5a0 test(context): assert SentryAutoConfiguration is excluded from Spring context
20edc0474c test(exception): verify handleGeneric captures exception in Sentry and returns 500
fa191b5c05 test(config): unit-test SentryConfig blank-DSN no-op and non-blank init paths
Compare 4 commits »
marcel commented on pull request marcel/familienarchiv#592 2026-05-15 09:30:26 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🎨 Leonie Voss — UX/UI Expert

Verdict: Approved

No frontend or UI changes in this PR — pure backend infrastructure integration.

Checked: no new routes, no new components, no i18n…

marcel commented on pull request marcel/familienarchiv#592 2026-05-15 09:30:23 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

Requirements Traceability (Issue #580)

Checking stated acceptance criteria against the implementation:

marcel commented on pull request marcel/familienarchiv#592 2026-05-15 09:30:18 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🧪 Sara Holt — QA Engineer / Tester

Verdict: 🚫 Changes requested

Blockers

Zero test coverage for SentryConfig — the class has two observable behaviours:

  1. When DSN is blank…
marcel commented on pull request marcel/familienarchiv#592 2026-05-15 09:30:05 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🚀 Tobias Wendt — DevOps Engineer

Verdict: ⚠️ Approved with concerns

Blockers

SENTRY_DSN is missing from .env.exampleSENTRY_TRACES_SAMPLE_RATE was added but…

marcel commented on pull request marcel/familienarchiv#592 2026-05-15 09:29:55 +02:00
feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🔐 Nora "NullX" Steiner — Security Expert

Verdict: Approved

Findings

send-default-pii: false (application.yaml:133) — correct. No IP addresses, usernames, request…