marcel

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 09:29:46 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🏛️ Markus Keller — Software Architect

Verdict: ✅ Approved

Findings

Placement is correct. SentryConfig lives in config/ — the designated home for infrastructure wiring. No…

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 09:29:36 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

No tests for SentryConfig.init() — this is a TDD violation. The @PostConstruct…

marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv

2026-05-15 09:25:20 +02:00

2139d600f5 fix(backend): exclude SentryAutoConfiguration — Spring Boot 4/SF7 bean name incompatibility

marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv

2026-05-15 08:55:42 +02:00

68e4ff4121 fix(backend): make sentry traces-sample-rate env-configurable

0a1d709c5f feat(backend): add sentry-spring-boot-starter-jakarta for GlitchTip error reporting

8a00d66435 fix(ci): set management.server.port=0 in test profile to fix 25-min test timeout

Compare 3 commits »

marcel pushed to main at marcel/familienarchiv

2026-05-15 08:55:06 +02:00

8a00d66435 fix(ci): set management.server.port=0 in test profile to fix 25-min test timeout

marcel closed issue marcel/familienarchiv#593

2026-05-15 08:55:06 +02:00

fix(ci): backend test suite 25-min timeout — management port TIME_WAIT regression from #576

marcel merged pull request marcel/familienarchiv#594

2026-05-15 08:55:05 +02:00

fix(ci): set management.server.port=0 in test profile to fix 25-min test timeout

marcel created pull request marcel/familienarchiv#594

2026-05-15 08:53:15 +02:00

fix(ci): set management.server.port=0 in test profile to fix 25-min test timeout

marcel pushed to fix/issue-593-management-port-zero at marcel/familienarchiv

2026-05-15 08:53:05 +02:00

8a00d66435 fix(ci): set management.server.port=0 in test profile to fix 25-min test timeout

marcel created branch fix/issue-593-management-port-zero in marcel/familienarchiv

2026-05-15 08:53:04 +02:00

marcel opened issue marcel/familienarchiv#593

2026-05-15 08:52:00 +02:00

fix(ci): backend test suite 25-min timeout — management port TIME_WAIT regression from #576

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:16:24 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

Blocker resolved in commit 5ee59ae9.

traces-sample-rate is now env-configurable via SENTRY_TRACES_SAMPLE_RATE (defaults to 1.0 if unset, preserving existing behaviour):

`backend/src/m…

marcel pushed to feat/issue-580-sentry-backend at marcel/familienarchiv

2026-05-15 08:16:18 +02:00

5ee59ae9f7 fix(backend): make sentry traces-sample-rate env-configurable

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:14:03 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

No UI changes in this PR. Backend-only: dependency addition, YAML configuration, and Docker Compose env var…

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:14:01 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

📋 Elena Richter — Requirements Engineer

Verdict: ✅ Approved

Spec compliance check vs. issue #580

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:13:55 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🛠️ Tobias — DevOps Engineer

Verdict: ⚠️ Approved with concerns

Blockers

traces-sample-rate: 1.0 — ops cannot tune without redeploy

At 100% sampling, every request…

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:13:48 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🧪 Sara Holt — QA Engineer & Test Automation Specialist

Verdict: ⚠️ Approved with concerns

Blockers

None — pure configuration, no testable logic at the unit layer.

Concerns

*…

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:13:40 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I checked

PII handling — send-default-pii: false ✅ Correct. Without this, Sentry captures…

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:13:27 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

None — the implementation is correct and minimal.

Suggestions

**`traces-sample-rat…

marcel commented on pull request marcel/familienarchiv#592

2026-05-15 08:13:20 +02:00

feat(backend): add Sentry/GlitchTip error reporting via sentry-spring-boot-starter-jakarta

🏗️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

Blockers

**traces-sample-rate: 1.0 is fine for dev but should be env-configurable for…