marcel

marcel commented on pull request marcel/familienarchiv#602

2026-05-16 00:24:41 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

The permanent-path approach is the right call. Bind mounts from ephemeral workspace paths have always…

marcel commented on pull request marcel/familienarchiv#602

2026-05-16 00:22:30 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

GitOps refactor — obs env model simplified (5 more commits)

After reviewing the secrets flow, the previous approach left a gap: Gitea secrets were written to .env.staging / .env.production…

marcel pushed to fix/issue-601-obs-stack-permanent at marcel/familienarchiv

2026-05-16 00:22:15 +02:00

53cf1837b2 fix(obs): set POSTGRES_HOST per environment — staging/prod use compose auto-names not archive-db

d83ed7254d docs(obs): document obs vs main stack env model, obs.env + obs-secrets.env approach

1ae4bfe325 ci(obs): GitOps obs env split in release — deploy to /opt/familienarchiv/, secrets fresh from Gitea

c5139851b8 ci(obs): GitOps obs env split in nightly — obs.env in git, secrets fresh from Gitea

f9baf02b86 feat(obs): add GF_SERVER_ROOT_URL to Grafana service

Compare 6 commits »

marcel commented on pull request marcel/familienarchiv#602

2026-05-16 00:02:35 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

Review concerns addressed

All open reviewer concerns have been resolved in 7 additional commits on this branch.

Blockers resolved

Markus — docs/DEPLOYMENT.md missing ✅

Added…

marcel pushed to fix/issue-601-obs-stack-permanent at marcel/familienarchiv

2026-05-16 00:02:16 +02:00

79735e23e0 ci(obs): assert obs-loki/prometheus/grafana/tempo are healthy after stack up

df37113d38 ci(obs): add compose config dry-run before obs stack up to catch .env substitution errors

c7d2eeb3f0 docs(ci): harden runner-config.yaml security comment for /opt/familienarchiv/ write access

4e94d85d7e docs(adr): add ADR-016 for obs stack co-location and CI-push config sync

dec6b8139b docs(c4): update l2-containers obs boundary to show /opt/familienarchiv/ permanent path

Compare 7 commits »

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:51:46 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

Reviewing against the acceptance criteria in issue #601, including additions from the two findings comments.

###…

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:51:31 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

No concerns from my angle.

This PR is entirely server-side infrastructure — CI workflow steps, runner…

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:51:26 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The fix addresses the root failure mode. The --wait flag on docker compose up provides implicit…

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:51:15 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

No new application-layer vulnerabilities introduced. The infrastructure changes have one…

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:51:01 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

No application code changes — pure infrastructure. The implementation is clean and the scope is…

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:50:53 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

🏗️ Markus Keller — Application Architect

Verdict: 🚫 Changes requested

The architectural decision is correct: the observability stack is persistent infrastructure and must be colocated…

marcel commented on pull request marcel/familienarchiv#602

2026-05-15 23:50:40 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

The root cause fix is solid — stable bind mounts at /opt/familienarchiv/ survive workspace wipes by…

marcel pushed to fix/issue-601-obs-stack-permanent at marcel/familienarchiv

2026-05-15 21:59:44 +02:00

7e52494880 fix(ci): deploy obs configs to /opt/familienarchiv/ before starting stack

marcel created pull request marcel/familienarchiv#602

2026-05-15 21:46:48 +02:00

fix(obs): Tempo processors schema fix + configurable Postgres host and Grafana port

marcel created branch fix/issue-601-obs-stack-permanent in marcel/familienarchiv

2026-05-15 21:46:33 +02:00

marcel pushed to fix/issue-601-obs-stack-permanent at marcel/familienarchiv

2026-05-15 21:46:33 +02:00

1181b97f94 fix(obs): make Postgres host configurable and fix PORT_GRAFANA default

458968ded5 fix(obs): remove invalid processors block from tempo metrics_generator

Compare 2 commits »

marcel commented on issue marcel/familienarchiv#601

2026-05-15 21:42:41 +02:00

devops: move observability stack out of CI workspace into /opt/familienarchiv/

🔍 Second round of findings — full migration attempt tonight

After the first recovery comment, a full docker compose up -d was attempted from /opt/familienarchiv/. Five more issues…

marcel commented on issue marcel/familienarchiv#601

2026-05-15 21:31:40 +02:00

devops: move observability stack out of CI workspace into /opt/familienarchiv/

🔍 Additional findings from tonight's recovery — update scope

While attempting to bring up the full observability stack after fixing Loki, three more issues were found. All should be…

marcel commented on issue marcel/familienarchiv#601

2026-05-15 21:22:05 +02:00

devops: move observability stack out of CI workspace into /opt/familienarchiv/

🗳️ Decision Queue — Action Required

1 decision needs your input before implementation starts.

Infrastructure

**How should config changes in infra/observability/ reach the…

marcel commented on issue marcel/familienarchiv#601

2026-05-15 21:21:47 +02:00

devops: move observability stack out of CI workspace into /opt/familienarchiv/

📋 Elicit — Requirements Engineer

Observations

"Syncing" is ambiguous in AC #5. The criterion "a deploy script or Makefile target handles syncing infra/observability/ from git to…