marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/familienarchiv#376 2026-04-29 21:13:55 +02:00
feat: auto-open transcription panel when navigating from mission-control cards

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • The change is minimal and well-scoped: two href updates (one in SegmentationColumn.svelte:39, one in `TranscriptionColumn.…
marcel opened issue marcel/familienarchiv#376 2026-04-29 21:12:27 +02:00
feat: auto-open transcription panel when navigating from mission-control cards
marcel commented on issue marcel/familienarchiv#364 2026-04-29 21:00:10 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🏛️ Markus Keller — Architect follow-up discussion

Decisions reached on two structural backend items:

✅ 1. Domain boundary: alias lookup goes on PersonService

RelationshipService…

marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:56:00 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

👨‍💻 Felix Brandt — Developer follow-up discussion

Decisions reached on three open implementation items:

✅ 1. i18n key: reuse person_born_name_prefix

The existing key already returns…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:50:35 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

The hover-card persistence and the maiden name fix are significant UX improvements for the…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:50:22 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The PR adds solid tests for the backend mention replacement and for the placeholder behavior. But two new…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:50:04 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

I audited the diff for OWASP Top 10 issues, authorization gaps, and data exposure risks. No vulnerabilities…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:49:53 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

The PR description is unusually thorough — seven distinct bug fixes, each with a root cause explanation and a…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:49:32 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

This PR touches one infrastructure-adjacent file (vite.config.ts) and otherwise makes application-layer changes.…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:49:25 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

I checked each change against layer rules, module boundaries, and the data model. All clean.

What I checked

**`@Elemen…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:49:11 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

1. void value dependency in $effect is fragile (PersonMentionEditor.svelte)

``…

marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:47:00 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🎨 Leonie Voss — UX/Accessibility follow-up discussion

Decisions reached on the four open UX items:

✅ 1. Maiden name on the SVG tree node card

Show geb. Schmidt directly on the node…

marcel commented on pull request marcel/familienarchiv#375 2026-04-29 20:40:08 +02:00
fix: hover card maiden name false positive, editor placeholder on non-empty content, mention persistence

Round 2 review concerns addressed — fb6bffd7…96d9ff5d

All open blockers and actionable suggestions from the second review round resolved in three commits.

✅ @saraholt / @felixbrandt —…

marcel pushed to fix/hover-card-placeholder-maiden-name at marcel/familienarchiv 2026-04-29 20:39:50 +02:00
96d9ff5db1 fix(PersonHoverCard): move chip colon into DOM for consistent screen reader announcement
0113367d05 refactor(TranscriptionReadView): remove dead else branch in handleMentionLeave
fb6bffd7ee test(TranscriptionService): verify clear() removes prior mentions before applying DTO
Compare 3 commits »
marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:34:34 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🗳️ Decision Queue — Action Required

1 decision needs your input before implementation starts.

Frontend Architecture

  • **SVG tree node card vs. side panel only for maiden name…
marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:34:21 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🚀 Tobias Wendt — DevOps & Platform Engineer

Observations

  • No infrastructure changes required. This is a pure application feature — no new services, no Docker Compose changes, no…
marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:34:12 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

📋 Elicit — Requirements Engineer

Observations

  • Component naming is imprecise. The issue references "D3 force graph node labels", "StammbaumPage.svelte", and "StammbaumCard". None…
marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:34:01 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

  • SVG layout cannot fit three text lines at NODE_H=56. Current node: name at y=22, dates at y=40, box bottom…
marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:33:46 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

  • The N+1 acceptance criterion is manual. "Verified by checking Hibernate SQL log for a tree with 5+ persons" means running…
marcel commented on issue marcel/familienarchiv#364 2026-04-29 20:33:35 +02:00
feat(stammbaum): show maiden name (geb. Schmidt) below person name in tree and side panel

🔒 Nora Steiner — Application Security Engineer

Observations

  • maidenName is historical personal data of deceased persons (1899–1950). In the project's context (family-only…