marcel

marcel created branch fix/hover-card-placeholder-maiden-name in marcel/familienarchiv

2026-04-29 18:27:48 +02:00

marcel pushed to fix/hover-card-placeholder-maiden-name at marcel/familienarchiv

2026-04-29 18:27:48 +02:00

835dc77382 fix(transcription): persist mentionedPersons on block update; eager-load collection

37edac4da6 fix(hover-card): maiden name false positive, placeholder on non-empty editor, card persistence

Compare 2 commits »

marcel commented on issue marcel/familienarchiv#370

2026-04-29 17:24:51 +02:00

feat(person-mention): discoverability hint for the @ trigger in the editor

🎨 Leonie Voss — UI/UX Design Lead

Walked through the discoverability hint design with Marcel. The original "muted line below the textarea" framing turned out to be a worse fit than expected…

marcel closed issue marcel/familienarchiv#374

2026-04-29 16:57:00 +02:00

GET /api/persons leaks PersonSummaryDTO.notes to typeahead clients (CWE-200)

marcel deleted branch feat/person-mentions-issue-362-frontend-b2 from marcel/familienarchiv

2026-04-29 16:55:57 +02:00

marcel closed issue marcel/familienarchiv#372

2026-04-29 16:55:55 +02:00

Person mention: decouple display text from person name to preserve original wording

marcel pushed to main at marcel/familienarchiv

2026-04-29 16:55:54 +02:00

49443ad16a docs(PersonMentionEditor): document client-side fetch exception inline

e6844c403c feat(MentionDropdown): restore "Neue Person anlegen" empty-state link

f1932fd5f6 fix(person-mention): WCAG 1.4.11 contrast for mention pill and dropdown ring

ba88febc77 fix(PersonMentionEditor): guard setEditable effect against re-entry loop

fa7b97acdc test(PersonMentionEditor): assert no HTML injection via mention displayName

Compare 17 commits »

marcel merged pull request marcel/familienarchiv#373

2026-04-29 16:55:53 +02:00

feat: decouple person-mention display text from person name (#372)

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:30:24 +02:00

feat: decouple person-mention display text from person name (#372)

Cycle-2 implementation summary

Two review/fix cycles run (1 of the 8-cycle budget consumed in cycle 2; cycle 3 was a re-review with zero blockers and is the loop exit).

Per-cycle "what…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:29:41 +02:00

feat: decouple person-mention display text from person name (#372)

Elicit — Requirements Engineer (cycle 2 re-review)

Verdict: Approved

Every cycle-1 OQ has either been resolved in this PR or properly deferred with traceability. The PR description now…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:29:02 +02:00

feat: decouple person-mention display text from person name (#372)

Tobias Wendt — DevOps & Platform Engineer (cycle 2 re-review)

Verdict: Approved with concerns

Cycle 2 made no infrastructure or build changes — purely UI/i18n/test-surface fixes. My…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:28:39 +02:00

feat: decouple person-mention display text from person name (#372)

Leonie Voss — UX Designer & Accessibility Strategist (cycle 2 re-review)

Verdict: Approved

All three accessibility issues I raised in cycle 1 are addressed. The disabled state is now…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:28:00 +02:00

feat: decouple person-mention display text from person name (#372)

Sara Holt — Senior QA Engineer (cycle 2 re-review)

Verdict: Approved with concerns

Cycle 2 added five new tests with strong assertions and removed the dead personMention.spec.ts that…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:27:28 +02:00

feat: decouple person-mention display text from person name (#372)

Nora Steiner ("NullX") — Application Security Engineer (cycle 2 re-review)

Verdict: Approved

All four cycle-1 concerns acknowledged; three resolved in this PR, one deferred to a…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:27:00 +02:00

feat: decouple person-mention display text from person name (#372)

Markus Keller — Senior Application Architect (cycle 2 re-review)

Verdict: Approved with concerns

Cycle 2 addresses the inline-comment piece of my CLAUDE.md "no client-side API fetch"…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:26:32 +02:00

feat: decouple person-mention display text from person name (#372)

Felix Brandt — Senior Fullstack Developer (cycle 2 re-review)

Verdict: Approved

Both blockers from my cycle-1 review are gone. Dead code (personMention.ts + spec) deleted in 4ac94b2f;…

marcel pushed to feat/person-mentions-issue-362-frontend-b2 at marcel/familienarchiv

2026-04-29 16:25:43 +02:00

49443ad16a docs(PersonMentionEditor): document client-side fetch exception inline

e6844c403c feat(MentionDropdown): restore "Neue Person anlegen" empty-state link

f1932fd5f6 fix(person-mention): WCAG 1.4.11 contrast for mention pill and dropdown ring

ba88febc77 fix(PersonMentionEditor): guard setEditable effect against re-entry loop

fa7b97acdc test(PersonMentionEditor): assert no HTML injection via mention displayName

Compare 8 commits »

marcel opened issue marcel/familienarchiv#374

2026-04-29 16:22:31 +02:00

GET /api/persons leaks PersonSummaryDTO.notes to typeahead clients (CWE-200)

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:06:42 +02:00

feat: decouple person-mention display text from person name (#372)

Elicit — Requirements Engineer (Brownfield review)

Verdict: Approved with concerns

This PR resolves issue #372 ("Person mention: decouple display text from person name") with a…

marcel commented on pull request marcel/familienarchiv#373

2026-04-29 16:06:06 +02:00

feat: decouple person-mention display text from person name (#372)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved with concerns

Bundle-size and dependency-management considerations dominate this review. The Tiptap stack is appropriate for…