marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#371 2026-04-29 08:41:16 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

47 new tests across the right layers (unit on mention.ts, component on PersonHoverCard and TranscriptionReadView, e2e…

marcel commented on pull request marcel/familienarchiv#371 2026-04-29 08:40:42 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved with concerns

The XSS hardening here is unambiguously good. escapeHtml is correct (escapes & < > " ' in the…

marcel commented on pull request marcel/familienarchiv#371 2026-04-29 08:40:09 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)

Elicit — Senior Requirements Engineer

Verdict: Approved with concerns

I'm in Brownfield mode here, reviewing PR-B2 against issue #362 expectations. This PR-B2 description is dense,…

marcel commented on pull request marcel/familienarchiv#371 2026-04-29 08:39:34 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Frontend-only change. No Compose deltas, no CI workflow changes, no image tags, no volumes, no env vars, no secrets. There is…

marcel commented on pull request marcel/familienarchiv#371 2026-04-29 08:39:25 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved with concerns

Read every changed line. TDD evidence is solid — 47 tests with named, sentence-style assertions; `mention.spec.t…

marcel commented on pull request marcel/familienarchiv#371 2026-04-29 08:38:56 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)

Markus Keller — Senior Application Architect

Verdict: Approved with concerns

This is a well-bounded frontend-only change. The module boundary between the rendering helper (mention.ts),…

marcel commented on issue marcel/familienarchiv#362 2026-04-29 08:30:35 +02:00
feat: Person @mentions in transcription blocks with hover card

PR-B2 (Frontend, read-mode + hover card) opened — #371

http://heim-nas:3005/marcel/familienarchiv/pulls/371

Implements the PR-B2 scope from the consolidated plan in [#362#issuecomment-533…

marcel created pull request marcel/familienarchiv#371 2026-04-29 08:30:14 +02:00
feat(person-mention): PR-B2 — read-mode rendering + hover card (issue #362)
marcel created branch feat/person-mentions-issue-362-frontend-b2 in marcel/familienarchiv 2026-04-29 08:29:35 +02:00
ae868f4110 test(e2e): person-mention read mode hover (B20) and tap (B21)
1fd38830fe feat(person-mention): TranscriptionReadView wires hover card and click nav
c9c395eb59 feat(person-mention): PersonHoverCard with skeleton/error/loaded states
c247e1e971 feat(person-mention): .person-mention global CSS for read-mode anchors
eb6e21f032 feat(person-mention): renderTranscriptionBody for safe read-mode HTML
Compare 5 commits »
marcel deleted branch feat/person-mentions-issue-362-frontend-b1 from marcel/familienarchiv 2026-04-29 08:05:54 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-29 08:05:50 +02:00
b4b46a0a79 test(person-mention): boundary cases for whitespace + newline triggers
ba73387d50 refactor(transcription): extract saveBlockWithConflictRetry into a util
d9c7abf2ab test(autosave): observe saving→saved transition in B12 retry path
7fc56022ae test(person-mention): assert popup degrades to empty state on fetch reject
e8ba840560 test(person-mention): drive editor specs via fake timers
Compare 26 commits »
marcel merged pull request marcel/familienarchiv#369 2026-04-29 08:05:49 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)
marcel commented on pull request marcel/familienarchiv#369 2026-04-29 01:27:29 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)

🏁 Cycle 2 — Final Status

All cycle-1 concerns triaged and addressed. Cycle-2 review verdicts (above):

marcel opened issue marcel/familienarchiv#370 2026-04-29 01:26:59 +02:00
feat(person-mention): discoverability hint for the @ trigger in the editor
marcel commented on pull request marcel/familienarchiv#369 2026-04-29 01:26:18 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)

📋 Requirements Engineer — Cycle 2 Re-Review

Verdict: ✅ Approved

Walking through my cycle-1 asks against the updated PR description:

marcel commented on pull request marcel/familienarchiv#369 2026-04-29 01:25:59 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)

⚙️ DevOps — Cycle 2 Re-Review

Verdict: ✅ LGTM

Cycle 2's diff is still entirely frontend code — 11 files touched (8 svelte/ts, 3 i18n JSONs). Zero changes to:

  • Dockerfile /…
marcel commented on pull request marcel/familienarchiv#369 2026-04-29 01:25:48 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)

🎨 Leonie Werner — Cycle 2 Re-Review

Verdict: ⚠️ Approved with one remaining concern

Six of my seven cycle-1 concerns are addressed cleanly:

marcel commented on pull request marcel/familienarchiv#369 2026-04-29 01:25:22 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)

🧪 Tester — Cycle 2 Re-Review

Verdict: ✅ Approved

Every concern I raised has a corresponding commit + assertion:

marcel commented on pull request marcel/familienarchiv#369 2026-04-29 01:25:02 +02:00
feat: person @mentions edit-mode infrastructure (PR-B1, #362)

🛡️ Sina Tariq — Cycle 2 Re-Review

Verdict: ✅ Approved

Walking through my cycle-1 concerns: