marcel

marcel pushed to feat/person-mentions-issue-362-backend at marcel/familienarchiv

2026-04-28 23:46:51 +02:00

091f6c7592 migration(transcription): add unique constraint on (block_id, person_id) sidecar

3a6f90441e test(transcription): add null-text edge case for rewriteBlockText guard

Compare 2 commits »

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:46:42 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

Review-fix round 4 — all open concerns addressed

4 new commits pushed. 1451/1451 backend tests green (was 1449 — +2 new tests from the null-text test and the V57 migration path exercised…

marcel opened issue marcel/familienarchiv#367

2026-04-28 23:46:21 +02:00

security(transcription): CWE-79 — escapeHtml required for @mention rendering in PR-B

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:13:23 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

📋 Elicit — Requirements Engineer & Business Analyst

Verdict: ⚠️ Approved with concerns

The PR is well-scoped and transparent about its boundaries. The "PR-A backend / PR-B frontend"…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:13:08 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure changes, no new services, no CI pipeline modifications. The Flyway migration is clean and follows the…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:12:57 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🎨 Leonie Voss — Senior UX Designer & Accessibility Strategist

Verdict: ✅ Approved

This is a backend-only PR. No Svelte components, no CSS, no page routes changed. The three frontend…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:12:41 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🧪 Sara Holt — Senior QA Engineer & Test Strategist

Verdict: ✅ Approved

This is one of the better-tested PRs I've seen in this codebase. All three layers are covered, test names are…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:12:22 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

The security lockdown (@RequirePermission(READ_ALL) on the GET endpoints) is the right call…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:12:02 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🏗️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

The event-based decoupling is architecturally sound. ADR-006 is thorough and clearly argues the tradeoffs. The…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:11:48 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Strong TDD evidence across all three test layers. Code is clean and modern throughout. A few things worth flagging.

#…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 23:06:56 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

Review-fix round 3 — all open concerns addressed

4 new commits pushed. 1450/1450 backend tests green (was 1449 — +1 new test).

Addressed in this round

marcel pushed to feat/person-mentions-issue-362-backend at marcel/familienarchiv

2026-04-28 23:06:41 +02:00

13e0801b30 refactor(transcription): extract rewriteBlockText from propagation loop

4c3aa159c5 test(transcription): add updateBlock 400 test for null personId in mention

eb51155b4e test(transcription): rename latency floor test to reflect 5s assertion

43f474fc5b refactor(repository): remove dead findByMentionedPersons_PersonId derived query

Compare 4 commits »

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:37:48 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

This is a backend-only PR with no Svelte components, no CSS changes, and no new routes. My review is…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:37:32 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I reviewed

Migration, CI implications, infrastructure footprint, and the architectural choice to stay…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:37:12 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

Test pyramid assessment

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:36:49 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

What I reviewed

Requirements traceability from issue #362 (locked consolidation plan) through to the implemented…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:36:25 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I audited

Authorization changes, input validation pipeline, the text-rewrite regex, JPQL query…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:36:00 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

TDD evidence

Tests precede implementation — 1446/1446 green, coverage spans: controller-slic…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:35:36 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

🏛️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

What I looked at

Full diff across all 24 changed files, plus ADR-006. Primary lens: module boundaries,…

marcel commented on pull request marcel/familienarchiv#366

2026-04-28 22:24:48 +02:00

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362)

Review-fix round 2 — all open concerns addressed

6 new commits pushed. 1449/1449 backend tests green (was 1447 — +2 new tests).