cb93f55396
refactor(stammbaum): StammbaumSidePanel composes AddRelationshipForm — removes inline form duplication
3cfaae06da
feat(stammbaum): AddRelationshipForm accepts onSubmit callback prop for fetch-based submission
📌 Pinned summary — read this instead of all comments above
For LLM agents and human readers: this single comment consolidates every locked decision, rationale, plan task, and…
dd505554ac
refactor(stammbaum): StammbaumSidePanel composes AddRelationshipForm — removes inline form duplication
c8b2c8c0a3
feat(stammbaum): AddRelationshipForm accepts onSubmit callback prop for fetch-based submission
Round 6 concerns addressed
All three open blockers resolved. Backend: 1420/1420 green. Frontend: 1255/1255 pass + 2 pre-existing unrelated failures (`hilfe/transkription/page.svelte.spe…
📋 Elicit — Plan Review
Plan-level requirements check. The earlier review (#5267) flagged five spec-level gaps, four of which were resolved in #5294 (multi-word detection, OQ-1 deterministic…
🚀 Tobias Wendt — Plan Review
Earlier review (#5266) confirmed no infra changes. The plan now drops hypersistence-utils (good — no new dep to vet). Two operational items the plan…
🎨 Leonie Voss — Plan Review
The earlier UX decisions (#5291) are well-reflected in the plan. Five gaps from the user-experience side.
Observations
- **B9 puts focus styles in…
🧪 Sara Holt — Plan Review
The test plan is comprehensive (24 tasks across 47 items, 21 are tests). Six gaps I'd add before merge.
Observations
- No optimistic-lock test. `Transcript…
🔐 Nora "NullX" Steiner — Plan Review
XSS escaping is well-handled in B1/B4. Two new issues from the plan that the earlier review didn't surface.
Observations
- **
GET /api/persons/{id}…
👨💻 Felix Brandt — Plan Review (Self-Review)
Stepping back to review my own implementation plan with fresh eyes.
Observations
- A5 oversimplifies
displayNamechange detection.…
🏗️ Markus Keller — Plan Review
Reviewing the implementation plan in #5321 against the architectural decisions locked in #5290.
Observations
- **
Person.displayNameis a computed…
👨💻 Felix Brandt — Implementation Plan
Decisions consolidated from the four discussion follow-ups (Markus, Leonie, Felix-dev, Nora). Plan is split into PR A — Backend then **PR B —…
📋 Elicit — Requirements Engineer
Verdict: ⚠️ Approved with concerns
What I checked
Requirements traceability, scope completeness against issue #358, edge case coverage, NFR…
🎨 Leonie Voss — UX Designer & Accessibility Strategist
Verdict: ⚠️ Approved with concerns
What I checked
Semantic HTML, touch targets, WCAG accessibility, ARIA attributes,…
🔧 Tobias Wendt — DevOps & Platform Engineer
Verdict: ✅ Approved
What I checked
Migration safety, Docker Compose/infra impact, new dependencies, secrets handling, and CI…
🧪 Sara Holt — QA Engineer
Verdict: ⚠️ Approved with concerns
What I checked
Test pyramid coverage, test naming, factory function usage, determinism, test layer correctness,…
🔒 Nora "NullX" Steiner — Security Engineer
Verdict: ✅ Approved
What I checked
Authorization on all 7 new endpoints, input validation, enum injection vector, client-side API…
👨💻 Felix Brandt — Senior Fullstack Developer
Verdict: ⚠️ Approved with concerns
What I checked
TDD evidence, naming, function size, Svelte 5 patterns, guard clauses,…
🏗️ Markus Keller — Senior Application Architect
Verdict: ✅ Approved
What I checked
Layer discipline, module boundaries, schema design, transport choices, package structure,…