Review concerns addressed
All open concerns from the multi-persona review have been resolved. Here's a summary:
Sara — Year-range validation (frontend blocker)
Concern: No…
91f82fe4cb
test(stammbaum): year-range validation test for AddRelationshipForm — toYear before fromYear shows alert
🎨 Leonie Voss — UI/UX Design Lead & Accessibility Strategist
Verdict: ⚠️ Approved with concerns
The page layout is responsive-aware, touch targets are correctly sized, and the empty…
📋 Elicit — Requirements Engineer
Verdict: ⚠️ Approved with concerns
The implementation traces well to the issue spec. All seven test plan items from the PR description are present in…
🧪 Sara Holt — QA Engineer & Test Strategist
Verdict: ⚠️ Approved with concerns
The test pyramid is well-shaped and the test quality is high. My concerns are about coverage gaps at the…
🔐 Nora "NullX" Steiner — Application Security Engineer
Verdict: ✅ Approved
No exploitable vulnerabilities found. The permission model is correctly applied and the ownership check on…
🔧 Tobias Wendt — DevOps & Platform Engineer
Verdict: ✅ Approved
Clean from an infrastructure perspective. No new services, no new ports, no Compose changes, no CI workflow changes. The…
👨💻 Felix Brandt — Senior Fullstack Developer
Verdict: ⚠️ Approved with concerns
TDD evidence is strong and the implementation follows clean code principles in most places. One…
🏛️ Markus Keller — Senior Application Architect
Verdict: ⚠️ Approved with concerns
This is a well-structured feature. The layering rule is honoured — RelationshipService always goes…
Round 5 concerns addressed
Three remaining open items from the last review round resolved. Backend: 1419/1419 green. Frontend: 841/841 pass + 2 pre-existing unrelated failures…
0d1b3ca94a
test(stammbaum): component tests for StammbaumCard — heading, empty state, toggle, error display
85c2264d76
test(stammbaum): component tests for StammbaumSidePanel — displayName, empty state, loading indicator
7e0dd18322
fix(stammbaum): i18n inline add-form in StammbaumSidePanel — replace 5 hardcoded German strings with m.relation_form_*() keys
👨💻 Felix Brandt — Senior Fullstack Developer
Developer discussion follow-up — six implementation-level items resolved.
✅ Item 1 — Multi-word name detection: fix it
**Decision:…
Round 4 concerns addressed
All open blockers and the two actionable suggestions resolved. Backend: 1419/1419 green. Frontend: 2 pre-existing failures remain in the wider suite (`confirm.sve…
31255642c5
fix(stammbaum): responsive /stammbaum layout — hidden md:block aside + fixed bottom sheet on mobile
1eebea5fcf
fix(stammbaum): i18n AddRelationshipForm — wire Paraglide for type/year labels and optgroup captions
4ccdeeb63c
fix(stammbaum): V55 adds unique_spouse_pair index — symmetric SPOUSE_OF enforced at DB level
cec4241350
test(stammbaum): happy-path controller tests for GET /api/network, GET inferred-rels, POST+DELETE relationships
🎨 Leonie Voss — UX Designer & Accessibility Strategist
UI/accessibility discussion — five open items from my earlier review, all resolved.
✅ Item 1 — <button> → <a href>…
🏗️ Markus Keller — Architecture Discussion Follow-up
Four open architectural items discussed and resolved. Decisions below supersede the open options in the Decision Queue for the architectur…
📋 Elicit — Requirements Engineer & Business Analyst
Verdict: ⚠️ Approved with concerns
The implementation covers the core requirements from #358 comprehensively. I identified two…
⚙️ Tobias Wendt — DevOps & Platform Engineer
Verdict: ✅ Approved
No infrastructure or CI changes in this PR. All the new code runs inside the existing Spring Boot container and…
🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate
Verdict: ⚠️ Approved with concerns
The overall visual language is coherent and the SVG tree accessibility is thoughtfully…