marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:38:27 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

Fast-follow — Sara's two remaining gaps closed (52f0babb)

Both untested page-internal bits are now extracted into pure, unit-tested helpers (document/transcription/):

  • **t no-active-re…
marcel pushed to feat/issue-327-transcribe-shortcuts at marcel/familienarchiv 2026-06-04 17:38:18 +02:00
52f0babb2e refactor(transcribe): extract t-mark + draw-cue policy into tested helpers (#327)
marcel deleted branch feat/issue-726-auto-title-sync from marcel/familienarchiv 2026-06-04 17:32:52 +02:00
marcel pushed to main at marcel/familienarchiv 2026-06-04 17:32:51 +02:00
0693cfddd1 fix(document): enlarge auto-title helper to 14px and assert its localized text (#726)
f656f7c1ff test(document): close review-flagged coverage gaps for auto-title sync (#726)
7316c51d4a refactor(document): share skip-null date-field resolution between save and projection (#726)
cf457cb96f docs(document): ADR-031 + glossary/c4/api_tests for auto-title sync (#726)
83e0afb466 feat(document): explain auto-generated title under the edit title field (#726)
Compare 9 commits »
marcel closed issue marcel/familienarchiv#726 2026-06-04 17:32:50 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + einmaliger Backfill)
marcel merged pull request marcel/familienarchiv#727 2026-06-04 17:32:50 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)
marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:31:38 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🧪 Sara — QA Engineer (re-review)

Verdict: Approve. My top ask — wrap-around coverage — is closed with a clean pure-helper unit suite, and the headline "delete exactly once" claim is…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:31:21 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

⚙️ DevOps (re-review)

✅ LGTM (still). The follow-up commits (7199575a..74124dcc) add nothing operational — confirmed no dependency, CI, or config drift.

  • **No infra/config/dependency…
marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:31:13 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

📋 Requirements Engineer (re-review)

Verdict: Approve — all 15 acceptance rows now met. My round-1 blocker is resolved; the two intentional deviations remain acceptably documented.

I…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:30:58 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🔒 Nora — Security Engineer (re-review)

Verdict: LGTM — approve. Re-reviewed the round-2 fixes (7199575a..74124dcc). They are frontend-only and introduce **no new security or…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:30:50 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🎨 Leonie — UX / Accessibility (re-review)

Verdict: ✅ Approve. Both my round-1 blockers are cleared, and every suggestion I'd hoped to see landed is in. Clean, accessible keyboard layer…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:30:46 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🏛️ Markus — Software Architect (re-review)

✅ Approved

Re-reviewed the current head (74124dcc) through the architecture lens only — layer boundaries, coupling, module placement,…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:30:45 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

👨‍💻 Felix Brandt — Senior Fullstack Developer (re-review)

✅ Approved. All four of my round-1 items are resolved or declined with sound rationale, and the refactor that resolves them is…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:19:17 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

Review follow-up — blockers + concerns addressed

Thanks all. Pushed 5 commits (7199575a..74124dcc) resolving every blocker and the substantive concerns. All touched specs green (57 tests:…

marcel pushed to feat/issue-327-transcribe-shortcuts at marcel/familienarchiv 2026-06-04 17:18:59 +02:00
74124dcc5d polish(transcribe): review nits — kbd size, focus ring, guard, action doc (#327)
f7bc3ccfc1 test(transcribe): prove Delete fires once via real shape + action (#327)
194340c716 refactor(transcribe): extract region navigation into a tested pure helper (#327)
39ef5f2d83 fix(transcribe): hide the "?" hint on touch-only devices (#327)
7199575a11 fix(transcribe): localise Delete key cap + annotation label, clarify Esc row (#327)
Compare 5 commits »
marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:16:33 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

Review concerns addressed — pushed 7316c51…0693cfd

Thanks all. No blockers were raised; here's how the concerns landed.

Fixed

  • projectedState drift (Markus, Felix, Sara) —…
marcel pushed to feat/issue-726-auto-title-sync at marcel/familienarchiv 2026-06-04 17:16:16 +02:00
0693cfddd1 fix(document): enlarge auto-title helper to 14px and assert its localized text (#726)
f656f7c1ff test(document): close review-flagged coverage gaps for auto-title sync (#726)
7316c51d4a refactor(document): share skip-null date-field resolution between save and projection (#726)
Compare 3 commits »
marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:08:31 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

📋 Requirements Engineer

**Verdict: Request changes — 14 of 15 acceptance rows met; one row ("touch-only devices") is unmet, and two intentional deviations are acceptable but require…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:08:26 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🧪 Sara — QA Engineer

Verdict: Approve with reservations. The action layer is genuinely well-tested (20 clean, sentence-named cases, real teardown, leak + stale-state checks). My concern…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:08:17 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

👨‍💻 Felix Brandt — Senior Fullstack Developer

⚠️ Approved with concerns — clean, well-tested, idiomatic Svelte 5. The action design (stateless input→callback translator owning the…