• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:07:49 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🎨 Leonie — UX / Accessibility

Verdict: Solid, accessible keyboard layer — native <dialog>, real focus management, aria-keyshortcuts, reduced-motion all done right. Two real issues…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:07:45 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

⚙️ DevOps

LGTM — frontend-only change, nothing operational to flag. No new dependencies, no CI/build/config changes, no env or secret touches. The new e2e spec fits the existing…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:07:39 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🔒 Nora — Security Engineer

Verdict: LGTM. Frontend-only keyboard-shortcut feature with effectively zero new security surface — no network/auth changes, no untrusted data rendered…

marcel commented on pull request marcel/familienarchiv#728 2026-06-04 17:07:27 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)

🏛️ Markus — Software Architect

Approved

I reviewed this purely through the architecture lens: layer boundaries, coupling, module responsibilities, and domain separation. This is a…

marcel created pull request marcel/familienarchiv#728 2026-06-04 17:05:36 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay (#327)
marcel commented on issue marcel/familienarchiv#327 2026-06-04 17:04:08 +02:00
feat(transcribe): keyboard shortcuts for the transcribe power path + cheatsheet overlay

Implemented on feat/issue-327-transcribe-shortcuts (worktree off main)

All 8 shortcuts, the cheatsheet overlay, the Esc ladder, and the annotation-Delete discoverability addendum are in.…

marcel pushed to feat/issue-327-transcribe-shortcuts at marcel/familienarchiv 2026-06-04 17:03:48 +02:00
6cd500ed8f test(transcribe): e2e coverage for shortcuts + cheatsheet a11y (#327)
1cc302b289 feat(transcribe): surface the "?" shortcut tip in the coach card (#327)
bc89426063 feat(transcribe): wire keyboard shortcuts into the document panel (#327)
ee728e3522 feat(transcribe): add ShortcutCheatsheet dialog overlay (#327)
52920a5aba feat(transcribe): add transcribeShortcuts keyboard action (#327)
Compare 6 commits »
marcel created branch feat/issue-327-transcribe-shortcuts in marcel/familienarchiv 2026-06-04 17:03:47 +02:00
marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:02:36 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

I came at this PR with the adversarial assumption that the backfill matcher is the soft underbelly — it…

marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:01:56 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

📋 Elicit — Requirements Engineer / Business Analyst

Verdict: Approved

I reviewed PR #727 strictly against issue #726: every FR, every NFR, the non-goals, and each Gherkin scenario…

marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:01:54 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

This is a genuinely well-built test suite — the pyramid is right (fast Mockito unit layer carries the…

marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:01:47 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

🏛️ Markus Keller — Application Architect

Verdict: Approved

I reviewed this strictly through the architecture lens: layer boundaries, the documentimporting dependency direction,…

marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:01:43 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

Verdict: Approved

I reviewed the FR-TITLE-005 helper line through the UX/accessibility lens: tone for the 60+ audience,…

marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:01:27 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

I read the full diff (24 files, +1037/-33) and the touched files on disk. This is the cleanest PR I've reviewed in a…

marcel commented on pull request marcel/familienarchiv#727 2026-06-04 17:01:13 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

The operational story is genuinely good for a one-shot maintenance endpoint: it reuses the established…

marcel created pull request marcel/familienarchiv#727 2026-06-04 16:59:05 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + Backfill) (#726)
marcel commented on issue marcel/familienarchiv#726 2026-06-04 16:47:18 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + einmaliger Backfill)

Implemented on feat/issue-726-auto-title-sync

All acceptance criteria covered with red/green TDD; backend tests green (293 across the touched classes incl. a Testcontainers postgres:16

marcel created branch feat/issue-726-auto-title-sync in marcel/familienarchiv 2026-06-04 16:46:51 +02:00
marcel pushed to feat/issue-726-auto-title-sync at marcel/familienarchiv 2026-06-04 16:46:51 +02:00
cf457cb96f docs(document): ADR-031 + glossary/c4/api_tests for auto-title sync (#726)
83e0afb466 feat(document): explain auto-generated title under the edit title field (#726)
12db7b3596 test(document): integration-test title backfill against real Postgres (#726)
26b45f1c78 feat(document): one-time backfill endpoint for stale auto-titles (#726)
e6ce00035e feat(document): regenerate auto-title on save when date/location change (#726)
Compare 6 commits »
marcel opened issue marcel/familienarchiv#726 2026-06-04 15:23:20 +02:00
Dokumenttitel automatisch mit Datum/Ort synchronisieren (Save-time + einmaliger Backfill)