• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#723 2026-06-03 22:47:19 +02:00
fix(transcription): remove annotation canvas delete button that obscured text (#722)

👨‍💻 Felix Brandt — Fullstack Developer (SvelteKit · Spring Boot · Python)

⚠️ Approved with concerns

Clean, focused removal. The on-canvas <button> and the now-orphaned `deleteVisible…

marcel commented on pull request marcel/familienarchiv#723 2026-06-03 22:47:17 +02:00
fix(transcription): remove annotation canvas delete button that obscured text (#722)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Approved

Frontend-only change, no infra/CI/Compose/observability surface touched. I reviewed it purely for CI gate behaviour and e2e…

marcel commented on pull request marcel/familienarchiv#723 2026-06-03 22:46:57 +02:00
fix(transcription): remove annotation canvas delete button that obscured text (#722)

🏛️ Markus Keller — Application Architect

⚠️ Approved with concerns (one minor, non-blocking)

A clean subtraction. This is a pure UI-control removal with no impact on layer boundaries,…

marcel created pull request marcel/familienarchiv#723 2026-06-03 22:39:36 +02:00
fix(transcription): remove annotation canvas delete button that obscured text (#722)
63854a80c9 fix(transcription): remove annotation canvas delete button that obscured text (#722)
marcel opened issue marcel/familienarchiv#722 2026-06-03 22:32:01 +02:00
fix(transcription): remove annotation canvas delete button that obscures text
marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:05:22 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

🗳️ Decision Queue — Action Required

_2 decisions need your input before the availability/retention ACs are testable. Everything else this round is a concrete recommendation or a text fix —…

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:05:07 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

🎨 Leonie Voss — UI/UX Design Lead

No UI concerns — confirmed again

I re-verified the full scope: host systemd timer, shell scripts, Flyway role migration, ntfy/Uptime Kuma push, GPG,…

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:04:59 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

📋 Elicit — Requirements Engineer

This is now a model infrastructure issue — NFR-OBS-001 added, restore AC rephrased to "most recent available dump," OCR volumes explicitly excluded, runbook…

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:04:45 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

🧪 Sara Holt — QA Engineer & Test Strategist

The AC section is now genuinely testable — failure paths, the rotation N+1 criterion, the dry-run gate, and the restore-most-recent rephrase are…

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:04:28 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

🔒 Nora "NullX" Steiner — Application Security Engineer

The security section now carries everything from my last pass — GPG asymmetric, backup_reader, one-direction Tailscale ACL, the…

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:04:11 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

🔧 Tobias Wendt — DevOps & Platform Engineer

Decision B (host systemd timer) is the right call for backup-lifecycle independence, and the body captures the --newer-than 48h / no---remove

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:03:49 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

👨‍💻 Felix Brandt — Senior Fullstack Developer

The script structure, dry-run, and env-var discipline sections are exactly what I'd write myself — nothing to add there. Three concrete…

marcel commented on issue marcel/familienarchiv#502 2026-06-03 21:03:32 +02:00
devops: nightly backup pipeline — pg_dump + mc mirror over Tailscale to heim-nas

🏗️ Markus Keller — Senior Application Architect

The issue is in excellent shape now — the four decisions are recorded and scope is tight. Two corrections and one structural flag before…

marcel deleted branch feat/issue-560-shared-vimock-mocks from marcel/familienarchiv 2026-06-03 11:38:24 +02:00
marcel merged pull request marcel/familienarchiv#719 2026-06-03 11:38:23 +02:00
Consolidate shared vi.mock bodies + migrate confirm/notification specs (#560)
marcel pushed to main at marcel/familienarchiv 2026-06-03 11:38:23 +02:00
27b6d58632 test(notification): make setNotifications authoritative in bell a11y tests
4db2e97490 revert(test): abandon shared-mock dedup — infeasible in vitest browser mode
25b23843c9 fix(test): load shared mocks via vi.hoisted, not a static import
ad067d2e0e refactor(notification): provide notification store via context + fixture
29015ee864 test: inject real ConfirmService via context (batch 2/2)
Compare 17 commits »
marcel closed issue marcel/familienarchiv#560 2026-06-03 11:38:23 +02:00
Consolidate shared vi.mock bodies into __mocks__/ via sync factories + migrate confirm/notification specs to test-fixtures
marcel pushed to feat/issue-560-shared-vimock-mocks at marcel/familienarchiv 2026-06-03 10:32:24 +02:00
30a8e36563 test(notification): make setNotifications authoritative in bell a11y tests