• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#360 2026-04-28 11:25:08 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

📋 Elicit — Requirements Engineer

Verdict: Approved

All stated acceptance criteria from the issue are met. I walked through the test plan line by line against the implementation.

###…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 11:24:51 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Clean migration, correct indexing strategy, no infrastructure changes needed.

Migration (V54)

**Column…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 11:24:45 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

The backend test suite is the strongest part of this PR. The frontend component tests are solid. The controller test…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 11:24:23 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

No injection vectors, no auth bypasses, no critical vulnerabilities. Two patterns worth…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 11:24:11 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Strong TDD evidence throughout. The BFS tests are well-constructed and the red-then-green discipline…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 11:23:56 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🏛️ Markus Keller — Senior Application Architect

Verdict: Approved

End-to-end implementation is solid. Architecture decisions are well-reasoned. A few observations worth calling…

marcel closed issue marcel/familienarchiv#266 2026-04-28 11:19:03 +02:00
fix(ocr): regenerate TypeScript types so TriggerSenderTrainingDTO.personId is non-optional
marcel closed issue marcel/familienarchiv#313 2026-04-28 11:19:03 +02:00
test(briefwechsel): capture visual-regression baselines for the row layout
marcel closed issue marcel/familienarchiv#224 2026-04-28 11:19:02 +02:00
feat: show top conversation pairs on briefwechsel entry state
marcel closed issue marcel/familienarchiv#338 2026-04-28 11:18:28 +02:00
feat(briefwechsel): discovery landing grid + gap markers
marcel pushed to feat/stammbaum-issue-358 at marcel/familienarchiv 2026-04-28 11:16:35 +02:00
707b6e002f refactor(stammbaum): extract RelationshipChip and AddRelationshipForm
1f62f9eda8 fix(stammbaum): WCAG min font-size and 44px touch targets
9a33d1ae71 fix(stammbaum): i18n for year-range labels in StammbaumCard
d6a5cdc41b fix(stammbaum): structured error codes in RelationshipController
dcdf270bf6 fix(stammbaum): resolve persons via PersonService in RelationshipInferenceService
Compare 5 commits »
marcel commented on pull request marcel/familienarchiv#360 2026-04-28 10:45:09 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

Review concerns addressed

All 5 open reviewer concerns resolved. Full test suites green: 1409/1409 backend, 1111/1111 frontend.


Cross-domain layering violation —…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:42:04 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

The core feature (storing and displaying family relationships) is well-specified and implemented. A few requirements…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:41:44 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🖥️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

No infrastructure, CI, or Docker Compose changes in this PR. The only things I care about here are the Flyway migration…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:41:36 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

The overall visual direction is coherent with the brand. The side panel layout, card pattern, and chip styles…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:41:21 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

Test coverage for this feature is substantially better than average for a feature of this scope. The 18 BFS unit…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:41:07 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

The write-side security is solid. Authorization controls are in the right places. The…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:40:48 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

🏗️ Markus Keller — Senior Application Architect

Verdict: 🚫 Changes requested

The feature is architecturally well-scoped: a dedicated relationship/ package with its own entity,…

marcel commented on pull request marcel/familienarchiv#360 2026-04-28 08:40:33 +02:00
feat(stammbaum): family network — graph, badge, edit card, /stammbaum page (#358)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Solid feature delivery. TDD evidence is strong (18 inference tests, 8 service tests, 7 integration…

marcel pushed to feat/stammbaum-issue-358 at marcel/familienarchiv 2026-04-28 08:36:31 +02:00
a57fd81c5f style(stammbaum): widen side panel to 320px so longer names don't clip
800bddd604 fix(stammbaum): iterative generation + spouse-adjacent block layout
Compare 2 commits »