marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel opened issue marcel/familienarchiv#355 2026-04-27 08:12:37 +02:00
feat(transcription): E2E test for bulk "Alle als fertig markieren" action
marcel pushed to feat/issue-345-bulk-mark-reviewed at marcel/familienarchiv 2026-04-27 08:12:20 +02:00
c641d704a8 merge: resolve conflict with origin/main + fix WCAG AA contrast + add API test
5b18b87450 test(security): add 403 permission test for annotation DELETE endpoint
bfa8b9c147 fix(viewer): move delete button inside annotation bounds to prevent edge clipping
3a94d62c74 test(viewer): verify delete button click does not bubble to onclick
163e99016a fix(viewer): check res.ok on orphaned annotation DELETE to surface errors
Compare 15 commits »
marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:11:39 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

Review Complete — All Personas Approved ✅

The multi-persona review loop has concluded. All 7 reviewers approved without blockers.

What was reviewed

The two commits pushed at 21:51…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:11:24 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

Reviewing against the acceptance criteria implied by issue #343 (dropdown clipping) and the PR description.

Requirements…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:11:12 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

This PR touches no infrastructure files — no docker-compose.yml, no CI workflow, no Dockerfile, no environment…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:11:03 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Strategist

Verdict: ✅ Approved

This PR is exactly the kind of change I want to see: fixing a real usability failure (clipped…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:10:46 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ✅ Approved

The two commits posted after the first review round addressed every concern I would have raised. I'm confirming the test…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:10:29 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

This PR touches only frontend UI components — no authentication, no authorization, no server-side data…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:10:20 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

This PR is frontend-only — no backend changes, no new services, no transport protocol decisions. I'm checking component…

marcel commented on pull request marcel/familienarchiv#350 2026-04-27 08:10:08 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Overall this is clean, well-scoped work. The fixed-positioning pattern mirrors PersonMultiSelect correctly, ARIA…

marcel deleted branch feat/issue-339-delete-icon-on-annotation from marcel/familienarchiv 2026-04-26 21:56:41 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-26 21:56:41 +02:00
5b18b87450 test(security): add 403 permission test for annotation DELETE endpoint
bfa8b9c147 fix(viewer): move delete button inside annotation bounds to prevent edge clipping
3a94d62c74 test(viewer): verify delete button click does not bubble to onclick
163e99016a fix(viewer): check res.ok on orphaned annotation DELETE to surface errors
d6f3ca5c43 feat(viewer): show delete icon on annotation for direct block deletion (#339)
Compare 5 commits »
marcel closed issue marcel/familienarchiv#339 2026-04-26 21:56:39 +02:00
feat(viewer): show delete icon directly on transcription annotation
marcel merged pull request marcel/familienarchiv#348 2026-04-26 21:56:38 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)
marcel pushed to main at marcel/familienarchiv 2026-04-26 21:54:48 +02:00
108edff8d2 feat(persons): show merge panel inline on edit page, remove Gefahrenzone accordion
marcel deleted branch feat/issue-342-person-merge-inline from marcel/familienarchiv 2026-04-26 21:54:48 +02:00
marcel closed issue marcel/familienarchiv#342 2026-04-26 21:54:46 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible
marcel merged pull request marcel/familienarchiv#347 2026-04-26 21:54:46 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)
marcel deleted branch feat/issue-340-pagination-page-jump from marcel/familienarchiv 2026-04-26 21:53:22 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-26 21:53:22 +02:00
3d3fe8d626 fix(pagination): add sr-only span to preserve aria-current on mobile AT
31e5573eab fix(pagination): hide mobile page label from AT tree with aria-hidden
934a00feb3 fix(pagination): use stable key in {#each} and fix duplicate page number bug
be27489618 test(pagination): fix test name typo and add totalPages===2 boundary test
4e486a31cf feat(pagination): add numbered page-jump buttons to document search
Compare 5 commits »