marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel closed issue marcel/familienarchiv#344 2026-04-26 21:45:52 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon
marcel merged pull request marcel/familienarchiv#351 2026-04-26 21:45:50 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)
marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:45:47 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

Leonie (UX/Accessibility) — Round 2 Review

Reviewing the accessibility changes across commits 451904da and dc7e5a1f.

Mobile AT fix analysis:

Round 1 flagged: the original code had…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:45:27 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

Sara (QA) — Round 2 Review

Reviewing test suite completeness after all 5 commits.

Test inventory (24 tests):

Core rendering:

  • renders the page-of-total label for the current page…
marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:45:06 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

Felix (Developer) — Round 2 Review

Reviewing the full set of 5 commits end-to-end.

pageWindow algorithm (commit d97b62c0) — the bridge logic is now correct. Threshold change from…

marcel pushed to feat/issue-340-pagination-page-jump at marcel/familienarchiv 2026-04-26 21:44:39 +02:00
dc7e5a1fd0 fix(pagination): add sr-only span to preserve aria-current on mobile AT
marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:40:39 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🗳️ Decision Queue — PR #346 (Round 2)

Updated status after the three follow-up commits. Overall verdict: ⚠️ Approved with concerns (Leonie, Elicit). One new blocker surfaced.

###…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:40:19 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

All four original acceptance criteria remain met. The follow-up commits address Decision Queue items 1–3 and 5. One…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:40:00 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure changes in the follow-up commits. The three new commits are frontend-only: two spec changes and one…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:39:57 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

The Decision Queue items are addressed. The algorithm fix and the key stabilization are invisible to users. The…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:39:36 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🧪 Sara Holt — QA Engineer

Verdict: ✅ Approved

The test suite improvements from the Decision Queue are clean. All items that were in scope are addressed.

What was addressed

**DQ…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:39:25 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🔒 Nora "NullX" Steiner — Security Engineer

Verdict: ✅ Approved

No new security surface introduced in the follow-up commits.

Audit of follow-up changes

Algorithm fix — The…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:39:09 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

The follow-up commits are coherent and stay within the component boundary established in the original PR. No layer…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:38:55 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

The Decision Queue items have been addressed correctly in three atomic commits. Each concern became exactly one…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:38:34 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🔄 Review Round 2 — All Blockers Resolved

Four follow-up commits were pushed addressing the concerns from Round 1:

marcel pushed to feat/issue-340-pagination-page-jump at marcel/familienarchiv 2026-04-26 21:38:21 +02:00
451904daeb fix(pagination): hide mobile page label from AT tree with aria-hidden
d97b62c072 fix(pagination): use stable key in {#each} and fix duplicate page number bug
92241447ae test(pagination): fix test name typo and add totalPages===2 boundary test
Compare 3 commits »
251b5503a2 test(security): add 403 permission test for annotation DELETE endpoint
007ec65dbd fix(viewer): move delete button inside annotation bounds to prevent edge clipping
e95a9312e8 test(viewer): verify delete button click does not bubble to onclick
f22596a29d fix(viewer): check res.ok on orphaned annotation DELETE to surface errors
Compare 4 commits »
marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:33:56 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

📋 Decision Queue

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:33:44 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

This PR is entirely frontend and backend application code — no Docker Compose changes, no CI…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:33:34 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

Blockers

1. No test for the unchecked fetch response in the orphaned-annotation branch

`handle…